René's URL Explorer Experiment


Title: File source `get_histroical_features` get wrong result · Issue #3360 · feast-dev/feast · GitHub

Open Graph Title: File source `get_histroical_features` get wrong result · Issue #3360 · feast-dev/feast

X Title: File source `get_histroical_features` get wrong result · Issue #3360 · feast-dev/feast

Description: Expected Behavior if Feast has data with same keys, then run get_historical_features' get latest data by created time' but it doesn't work expected way Current Behavior if duplicated data on same keys are over 3 copies (diffrent 'created...

Open Graph Description: Expected Behavior if Feast has data with same keys, then run get_historical_features' get latest data by created time' but it doesn't work expected way Current Behavior if duplicated data on same k...

X Description: Expected Behavior if Feast has data with same keys, then run get_historical_features' get latest data by created time' but it doesn't work expected way Current Behavior if duplicated da...

Opengraph URL: https://github.com/feast-dev/feast/issues/3360

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"File source `get_histroical_features` get wrong result ","articleBody":"## Expected Behavior \r\n- if Feast has data with same keys, then run `get_historical_features'  get latest data by `created time'  \r\n- but it doesn't work expected way\r\n\r\n## Current Behavior\r\n- if duplicated data on same keys are over 3 copies (diffrent 'created time') , feast cannot give right result\r\n\r\n## Steps to reproduce\r\n```\r\ndata = pd.read_parquet(\"data/driver_stats.parquet\")\r\n\r\nnew_data = data.copy()\r\nnew_data['avg_daily_trips'] = new_data['avg_daily_trips'] + 1000\r\nnew_data['event_timestamp'] = new_data['event_timestamp']\r\nnew_data['created'] = pd.Timestamp.now()\r\n\r\nmerged_df = pd.concat([data, new_data]).reset_index(drop=True)\r\nmerged_df.to_parquet(\"./data/driver_stats.parquet\")\r\n\r\nstore = FeatureStore(\".\")\r\nentity_df = pd.DataFrame.from_dict(\r\n        {\r\n            # entity's join key -> entity values\r\n            \"driver_id\": [1001, 1002, 1003],\r\n            # \"event_timestamp\" (reserved key) -> timestamps\r\n            \"event_timestamp\": [\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n            ]\r\n        }\r\n    )\r\ntraining_df = store.get_historical_features(\r\n        entity_df=entity_df,\r\n        features=[\r\n            \"driver_hourly_stats:conv_rate\",\r\n            \"driver_hourly_stats:acc_rate\",\r\n            \"driver_hourly_stats:avg_daily_trips\"\r\n        ],\r\n    ).to_df()\r\ntraining_df # it is right, result has (plus+1000) datas\r\n```\r\n\u003cimg width=\"742\" alt=\"스크린샷 2022-11-24 오후 12 50 40\" src=\"https://user-images.githubusercontent.com/32768535/203689933-52334d04-24ec-453c-af69-da169896541c.png\">\r\n\r\n-------\r\n```\r\nnew_data = data.copy()\r\nnew_data['avg_daily_trips'] = new_data['avg_daily_trips'] + 10000\r\nnew_data['event_timestamp'] = new_data['event_timestamp']\r\nnew_data['created'] = pd.Timestamp.now()\r\n# this \"merged_df\" which is merged by pd.concat is above one.\r\nmerged_df = pd.concat([merged_df, new_data]).reset_index(drop=True)\r\nmerged_df.to_parquet(\"./data/driver_stats.parquet\")\r\n\r\nstore = FeatureStore(\".\")\r\nentity_df = pd.DataFrame.from_dict(\r\n        {\r\n            # entity's join key -> entity values\r\n            \"driver_id\": [1001, 1002, 1003],\r\n            # \"event_timestamp\" (reserved key) -> timestamps\r\n            \"event_timestamp\": [\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n                datetime(2022, 11, 20, 23, 00, 42),\r\n            ]\r\n        }\r\n    )\r\ntraining_df = store.get_historical_features(\r\n        entity_df=entity_df,\r\n        features=[\r\n            \"driver_hourly_stats:conv_rate\",\r\n            \"driver_hourly_stats:acc_rate\",\r\n            \"driver_hourly_stats:avg_daily_trips\"\r\n        ],\r\n    ).to_df()\r\ntraining_df \r\n```\r\nabove is wrong, in my pc result is\r\n\u003cimg width=\"746\" alt=\"스크린샷 2022-11-24 오후 12 50 26\" src=\"https://user-images.githubusercontent.com/32768535/203689907-f88aa9a4-760e-4a2f-8710-76f85428939b.png\">\r\n\r\n### Specifications\r\n\r\n- Version: Feast SDK Version: \"feast 0.26.0\"\r\n- Platform: M1 mac\r\n- Subsystem: local\r\n\r\n## Possible Solution\r\n- This problem seems to have arisen because of pandas sorting & drop_duplicates. but i'm not sure.\r\n- if it is not a but, let me know how to fix that.","author":{"url":"https://github.com/GyuminJack","@type":"Person","name":"GyuminJack"},"datePublished":"2022-11-24T03:53:40Z","url":"https://github.com/feast-dev/feast/issues/3360"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:781c7829-cf70-c786-bccf-d3f94b4012ee
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDF50:1D85AC:EC9281:1427AF9:6AFE9535
html-safe-noncea71be73a749f029a54d8fd4d587e70969c1dd75195936ada249059fc5e26fa62
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjUwOjFEODVBQzpFQzkyODE6MTQyN0FGOTo2QUZFOTUzNSIsInZpc2l0b3JfaWQiOiI1NTQ1NzU0NTE5OTE0MDU5MDYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccaf0c97b813d118d81233240d655230e24f24d5c458ab8545034f124f97c0fcf
hovercard-subject-tagissue:1462716719
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3360/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de1144db33dbf3141929926f3772b5771181274aa9dbdf54f6996f7ae4be7ea4/feast-dev/feast/issues/3360
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de1144db33dbf3141929926f3772b5771181274aa9dbdf54f6996f7ae4be7ea4/feast-dev/feast/issues/3360
og:image:altExpected Behavior if Feast has data with same keys, then run get_historical_features' get latest data by created time' but it doesn't work expected way Current Behavior if duplicated data on same k...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGyuminJack
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/3360#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3360
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3360
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/3360
Reloadhttps://github.com/feast-dev/feast/issues/3360
Reloadhttps://github.com/feast-dev/feast/issues/3360
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3360
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3360
File source get_histroical_features get wrong result https://github.com/feast-dev/feast/issues/3360#top
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
wontfixThis will not be worked onhttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22wontfix%22
https://github.com/GyuminJack
GyuminJackhttps://github.com/GyuminJack
on Nov 24, 2022https://github.com/feast-dev/feast/issues/3360#issue-1462716719
https://user-images.githubusercontent.com/32768535/203689933-52334d04-24ec-453c-af69-da169896541c.png
https://user-images.githubusercontent.com/32768535/203689907-f88aa9a4-760e-4a2f-8710-76f85428939b.png
GyuminJackhttps://github.com/GyuminJack
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
on Nov 24, 2022https://github.com/feast-dev/feast/issues/3360#event-7882320461
https://github.com/seunggabi
seunggabihttps://github.com/seunggabi
on Jan 30, 2023https://github.com/feast-dev/feast/issues/3360#issuecomment-1408803716
https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/file.py#L205-L208https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/file.py#L205-L208
https://github.com/apps/stale
stalehttps://github.com/apps/stale
on Jun 10, 2023https://github.com/feast-dev/feast/issues/3360#issuecomment-1585592753
stalehttps://github.com/apps/stale
wontfixThis will not be worked onhttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22wontfix%22
on Jun 10, 2023https://github.com/feast-dev/feast/issues/3360#event-9490480927
stalehttps://github.com/apps/stale
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 17, 2023https://github.com/feast-dev/feast/issues/3360#event-10391665917
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/3360
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3360
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
wontfixThis will not be worked onhttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22wontfix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.