Title: `get_online_features` forces online stores to make multiple network calls · Issue #3259 · feast-dev/feast · GitHub
Open Graph Title: `get_online_features` forces online stores to make multiple network calls · Issue #3259 · feast-dev/feast
X Title: `get_online_features` forces online stores to make multiple network calls · Issue #3259 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. When using get_online_features, if features from multiple feature views are requested, the FeatureStore._get_online_features implementation groups the features by the feature...
Open Graph Description: Is your feature request related to a problem? Please describe. When using get_online_features, if features from multiple feature views are requested, the FeatureStore._get_online_features implement...
X Description: Is your feature request related to a problem? Please describe. When using get_online_features, if features from multiple feature views are requested, the FeatureStore._get_online_features implement...
Opengraph URL: https://github.com/feast-dev/feast/issues/3259
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`get_online_features` forces online stores to make multiple network calls","articleBody":"**Is your feature request related to a problem? Please describe.**\r\n\r\nWhen using `get_online_features`, if features from multiple feature views are requested, the `FeatureStore._get_online_features` implementation groups the features by the feature-view they belong to and calls the online store's `online_read` method for each of those groups sequentially.\r\n\r\nThis means that if the online store has the ability to fetch all the data for all the feature-views in one network call, that opportunity is not provided to the online store. For example, in the upcoming BigTable online store implementation, data for different feature-views that share the same entities is colocated. I strongly suspect that it would be faster to fetch all the data in one go than it would be to make multiple sequential network calls.\r\n\r\n**Describe the solution you'd like**\r\n\r\nOne solution would be to allow the `OnlineStore` to have a separate method (perhaps called `online_read_all` or something) that could get all the information regarding all the feature_views and the requested features in one shot (instead of splitting that information across the multiple calls to `online_read`). If the `OnlineStore` does not implement the `online_read_all` method, then we can default to calling the various `online_read` methods sequentially. This way, we don't break the API of the current online stores.\r\n\r\nAdditionally, in the `FeatureStore._get_online_features` method, we could potentially consider performing all the `online_read`s concurrently. This way, all the existing online stores will experience a potentially free performance lift.\r\n\r\n**Describe alternatives you've considered**\r\n\r\nNothing is currently broken, so the alternative is to just not do anything.\r\n\r\nAlternatively, a worse solution would be to provide a `hint` to the existing online_read method about the other feature views and their requested features. The `online_read` method could then make a single API call for all of it, cache it somewhere and return only the relevant parts. I'm not too keen on this idea though, since a cleaner API option is still available.\r\n\r\nAnother alternative would be for any of the online stores to just get data for all the feature views ahead of time (for the same entity keys) in one network call and cache it. I'm not 100% sure if this would actually lead to a reasonable performance gain in all scenarios since there's inherent waste here.\r\n\r\n**Additional context**\r\n\r\nN/A\r\n","author":{"url":"https://github.com/chhabrakadabra","@type":"Person","name":"chhabrakadabra"},"datePublished":"2022-09-28T18:44:42Z","url":"https://github.com/feast-dev/feast/issues/3259"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d4015a88-110b-4d6b-62e3-c499a7ec1727 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AABE:3DB40C:24C9C1:3293B9:6AFE951F |
| html-safe-nonce | b0b3bf77818982ff66eef2a9f7c5eb75da06723f92edbd2f5d5b79cb8cff7149 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUJFOjNEQjQwQzoyNEM5QzE6MzI5M0I5OjZBRkU5NTFGIiwidmlzaXRvcl9pZCI6IjY3NzIzMDMzMzAzMjEyNzQxNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5d210a262a9978a72db60cb86316c9bdb80c42649e6097e0f0320728013656a3 |
| hovercard-subject-tag | issue:1389799269 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3259/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fab93f2a29d7bbb24f36c8d588a361205daa2a386e4f3cd7596adbc888c50708/feast-dev/feast/issues/3259 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fab93f2a29d7bbb24f36c8d588a361205daa2a386e4f3cd7596adbc888c50708/feast-dev/feast/issues/3259 |
| og:image:alt | Is your feature request related to a problem? Please describe. When using get_online_features, if features from multiple feature views are requested, the FeatureStore._get_online_features implement... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chhabrakadabra |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width