René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Push api call to a push source that doesn't exist returns 200","articleBody":"## Expected Behavior \r\nWhen we `POST` to a push source that doesn't exist like so\r\n```\r\ncurl -X POST \"http://localhost:6566/push\" -d '{\r\n    \"push_source_name\": \"push_source_name_that_does_not_exist\",\r\n    \"df\": {\r\n            \"some_entity\": [1001],\r\n            \"event_timestamp\": [\"2022-05-13 10:59:42\"],\r\n            \"created\": [\"2022-05-13 10:59:42\"],\r\n            ...\r\n    },\r\n    \"to\": \"online_and_offline\",\r\n  }' | jq\r\n```\r\nI'd expect an error. It is a valid format to the correct endpoint, but is an entity that doesn't exist. A [422 unprocessable entity](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422) error would probably make sense here.\r\n\r\n## Current Behavior\r\nMethod `FeatureStore().push` receives a [`push_source_name`](https://github.com/feast-dev/feast/blob/7c50ab510633c11646b6ff04853f3f26942ad646/sdk/python/feast/feature_store.py#L1418) indicating which feature views are impacted by the new data being pushed. The set of feature views is filtered down [here](https://github.com/feast-dev/feast/blob/7c50ab510633c11646b6ff04853f3f26942ad646/sdk/python/feast/feature_store.py#L1437-L1445). If a push source name is provided that doesn't actually exist then the resulting set is empty, the loop is skipped and the function is a no-op. This successful return means that the [`/push` call in feature_server.py](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_server.py#L95-L100) never throws to return an error code.\r\n\r\n## Steps to reproduce\r\n* start a local feature server\r\n* make a push call to a push source that does not exist\r\n\r\n### Specifications\r\n\r\n- Version:\r\n- Platform:\r\n- Subsystem:\r\n\r\n## Possible Solution\r\n* Raise a custom exception when no push source is found with the provided name\r\n* Catch that exception in the feature server\r\n* Return 422 in that case\r\n\r\nIf this is considered reasonable, I'm happy to make the contribution myself.","author":{"url":"https://github.com/robhowley","@type":"Person","name":"robhowley"},"datePublished":"2022-09-13T20:20:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/3210/feast/issues/3210"}