Title: Wrong condition in to_snowflake method of snowflake provider · Issue #3045 · feast-dev/feast · GitHub
Open Graph Title: Wrong condition in to_snowflake method of snowflake provider · Issue #3045 · feast-dev/feast
X Title: Wrong condition in to_snowflake method of snowflake provider · Issue #3045 · feast-dev/feast
Description: Expected Behavior to_snowflake should ignore on_demand_feature_views if on_demand_feature_views is an empty list Current Behavior to_snowflake runs on_demand_feature_views code because on_demand_feature_views is set to [] here Steps to r...
Open Graph Description: Expected Behavior to_snowflake should ignore on_demand_feature_views if on_demand_feature_views is an empty list Current Behavior to_snowflake runs on_demand_feature_views code because on_demand_fe...
X Description: Expected Behavior to_snowflake should ignore on_demand_feature_views if on_demand_feature_views is an empty list Current Behavior to_snowflake runs on_demand_feature_views code because on_demand_fe...
Opengraph URL: https://github.com/feast-dev/feast/issues/3045
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong condition in to_snowflake method of snowflake provider","articleBody":"## Expected Behavior \r\n[to_snowflake](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/snowflake.py#L430) should ignore on_demand_feature_views if on_demand_feature_views is an empty list\r\n\r\n## Current Behavior\r\n\r\nto_snowflake runs on_demand_feature_views code because on_demand_feature_views is set to [] [here](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/snowflake.py#L387)\r\n\r\n## Steps to reproduce\r\n\r\n### Specifications\r\n\r\n- Version: 0.23.0\r\n- Platform: feast SDK\r\n- Subsystem:\r\n\r\n## Possible Solution\r\n\r\n`if self.on_demand_feature_views is not None: ` =\u003e `if self.on_demand_feature_views is not []: `\r\n\r\n","author":{"url":"https://github.com/floOnfido","@type":"Person","name":"floOnfido"},"datePublished":"2022-08-09T13:36:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/3045/feast/issues/3045"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:fff3c4b1-e9e9-ad42-5089-da7934d60e91 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EBA8:181429:33AF0AB:48CA7DA:69792FCC |
| html-safe-nonce | 7b4803d585707fd60019ba125bffc6f9c2e391edd76335d17d05757ef99083ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkE4OjE4MTQyOTozM0FGMEFCOjQ4Q0E3REE6Njk3OTJGQ0MiLCJ2aXNpdG9yX2lkIjoiNjg0OTAxMzI4MDE1MzM1MDA5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 44548b79e132e0cab3fe336bdf34cb52e02ef141319431cb7fbd133ab32c76db |
| hovercard-subject-tag | issue:1333271903 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3045/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cb48c143141c40daec5426abf32dafe1e670df22b6f272fc97f864eacf170176/feast-dev/feast/issues/3045 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cb48c143141c40daec5426abf32dafe1e670df22b6f272fc97f864eacf170176/feast-dev/feast/issues/3045 |
| og:image:alt | Expected Behavior to_snowflake should ignore on_demand_feature_views if on_demand_feature_views is an empty list Current Behavior to_snowflake runs on_demand_feature_views code because on_demand_fe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | floOnfido |
| hostname | github.com |
| expected-hostname | github.com |
| None | 15417fb272585d09f7c894f2a869ba34cc4c7ded898af9dccaa85542b9adb711 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 535f4866a7b2e3d762bd599bffe50a3cfb0702b2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width