Title: basicConfig is called at the module level · Issue #2664 · feast-dev/feast · GitHub
Open Graph Title: basicConfig is called at the module level · Issue #2664 · feast-dev/feast
X Title: basicConfig is called at the module level · Issue #2664 · feast-dev/feast
Description: Expected Behavior import feast logging.basicConfig(level=level, format=FORMAT) logging.error("msg") should print logging message according to FORMAT Current Behavior It uses the format defined in feast at the module level. Steps to repro...
Open Graph Description: Expected Behavior import feast logging.basicConfig(level=level, format=FORMAT) logging.error("msg") should print logging message according to FORMAT Current Behavior It uses the format defined in f...
X Description: Expected Behavior import feast logging.basicConfig(level=level, format=FORMAT) logging.error("msg") should print logging message according to FORMAT Current Behavior It uses the format de...
Opengraph URL: https://github.com/feast-dev/feast/issues/2664
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"basicConfig is called at the module level","articleBody":"## Expected Behavior \r\n\r\n```\r\nimport feast\r\nlogging.basicConfig(level=level, format=FORMAT)\r\nlogging.error(\"msg\")\r\n```\r\n\r\nshould print logging message according to `FORMAT`\r\n\r\n## Current Behavior\r\n\r\nIt uses the format defined in `feast` at the module level.\r\n\r\n## Steps to reproduce\r\n\r\nSame as in \"Expected Behavior\"\r\n\r\n### Specifications\r\n\r\n- Version: 0.18.1\r\n- Platform: Linux\r\n- Subsystem: -\r\n\r\n## Possible Solution\r\n\r\nI see that `basicConfig` is called here: https://github.com/feast-dev/feast/blob/c9eda79c7b1169ef05a481a96f07960c014e88b9/sdk/python/feast/cli.py#L84 so it is possible that simply removing this call here is enough: https://github.com/feast-dev/feast/blob/0ca62970dd6bc33c00bd5d8b828752814d480588/sdk/python/feast/__init__.py#L30\r\n\r\nIf there are any other entry points that need to set up logging, they should call the function, but the call in `__init__.py` must be removed.","author":{"url":"https://github.com/elshize","@type":"Person","name":"elshize"},"datePublished":"2022-05-11T12:33:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2664/feast/issues/2664"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:41315342-82eb-aed7-3e1b-e1225e0a0e79 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C4B2:2BC8E3:7C38F:B05FA:6978A2CB |
| html-safe-nonce | fbc44c8de5c1a8b42a1e1326fe0f29ed24b0fef1bf423b8f67110692f55174e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEIyOjJCQzhFMzo3QzM4RjpCMDVGQTo2OTc4QTJDQiIsInZpc2l0b3JfaWQiOiIxODQ1MTgwOTg1MDcxMTQ5NzcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f5832dab3c0b95a70ed940bf490b953b36326a21fc83de49d7f8a79d7bfc2466 |
| hovercard-subject-tag | issue:1232567312 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/2664/issue_layout |
| twitter:image | https://opengraph.githubassets.com/592ffc6762efe49c45f01aef0f5d435860a7a29f7d3128a43a7b429eb9e3b24e/feast-dev/feast/issues/2664 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/592ffc6762efe49c45f01aef0f5d435860a7a29f7d3128a43a7b429eb9e3b24e/feast-dev/feast/issues/2664 |
| og:image:alt | Expected Behavior import feast logging.basicConfig(level=level, format=FORMAT) logging.error("msg") should print logging message according to FORMAT Current Behavior It uses the format defined in f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | elshize |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8aa86d87c47054170094daaf9699b27a28a8448 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width