Title: Feature repo setup for Java integration tests is broken · Issue #2522 · feast-dev/feast · GitHub
Open Graph Title: Feature repo setup for Java integration tests is broken · Issue #2522 · feast-dev/feast
X Title: Feature repo setup for Java integration tests is broken · Issue #2522 · feast-dev/feast
Description: Expected Behavior The feature repo that is set up for Java integration tests with docker compose (see feast/java/serving/src/test/resources/docker-compose/feast10) should rely on the most recent Feast code (e.g. for a PR, it should pull ...
Open Graph Description: Expected Behavior The feature repo that is set up for Java integration tests with docker compose (see feast/java/serving/src/test/resources/docker-compose/feast10) should rely on the most recent Fe...
X Description: Expected Behavior The feature repo that is set up for Java integration tests with docker compose (see feast/java/serving/src/test/resources/docker-compose/feast10) should rely on the most recent Fe...
Opengraph URL: https://github.com/feast-dev/feast/issues/2522
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Feature repo setup for Java integration tests is broken","articleBody":"## Expected Behavior\r\n\r\nThe feature repo that is set up for Java integration tests with docker compose (see `feast/java/serving/src/test/resources/docker-compose/feast10`) should rely on the most recent Feast code (e.g. for a PR, it should pull from the latest commit on the PR).\r\n\r\n## Current Behavior\r\n\r\nInstead, the feature repo pulls from `main`: `RUN git clone https://github.com/feast-dev/feast.git /root/feast`. This means that breaking changes might not be caught. As an example, #2488 made a breaking change, but the Java integration tests still passed on the PR; once the PR was merged in, the tests began to fail.\r\n\r\n## Steps to reproduce\r\n\r\n### Specifications\r\n\r\n- Version:\r\n- Platform:\r\n- Subsystem:\r\n\r\n## Possible Solution\r\n\r\nPull code from the latest commit on the PR instead of `main`.\r\n","author":{"url":"https://github.com/felixwang9817","@type":"Person","name":"felixwang9817"},"datePublished":"2022-04-11T17:22:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/2522/feast/issues/2522"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f764cdf3-f346-9417-fb45-e6d92e83d005 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E7CA:14E4A5:227046F:30A45D1:6978FD75 |
| html-safe-nonce | 607d8de86ee16cee475608c5df8633a0de6b3fb0c8221a42863cee1716e0d53a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0NBOjE0RTRBNToyMjcwNDZGOjMwQTQ1RDE6Njk3OEZENzUiLCJ2aXNpdG9yX2lkIjoiMzAyNzc2MzYyODMxMzQ3NjQ2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0c3fb2610f10aadbed6359637070cab5e26dd9860a6814fc4176d4ec6d19324d |
| hovercard-subject-tag | issue:1200286429 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/2522/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d0d2f81d546d2c1daf35c956dbe8f8e7d686c89fb50745cbc9ab6334e15134c3/feast-dev/feast/issues/2522 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d0d2f81d546d2c1daf35c956dbe8f8e7d686c89fb50745cbc9ab6334e15134c3/feast-dev/feast/issues/2522 |
| og:image:alt | Expected Behavior The feature repo that is set up for Java integration tests with docker compose (see feast/java/serving/src/test/resources/docker-compose/feast10) should rely on the most recent Fe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | felixwang9817 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6d9b384ce19e0ac9756580c70eae9a3359939e77ff05c731561090d13085b2b7 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56ad33f6fdc0d0fb49c96b3c46ed74c55d926471 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width