René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Materialization and serving fail when using Redis cluster for the online store","articleBody":"## Expected Behavior \r\nUsing a Redis cluster as the online storage should work without errors.\r\n\r\n## Current Behavior\r\nUsing a Redis cluster as the online storage no longer works after updating from 0.17.0 to 0.18.0. The issue happens whenever Feast tries to connect to the Redis cluster - e.g. during `feast materialize` or during feature serving. The exact error that is raised looks like this:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"/usr/local/bin/feast\", line 8, in \u003cmodule\u003e\r\n    sys.exit(cli())\r\n  File \"/usr/local/lib/python3.7/site-packages/click/core.py\", line 1128, in __call__\r\n    return self.main(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/click/core.py\", line 1053, in main\r\n    rv = self.invoke(ctx)\r\n  File \"/usr/local/lib/python3.7/site-packages/click/core.py\", line 1659, in invoke\r\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n  File \"/usr/local/lib/python3.7/site-packages/click/core.py\", line 1395, in invoke\r\n    return ctx.invoke(self.callback, **ctx.params)\r\n  File \"/usr/local/lib/python3.7/site-packages/click/core.py\", line 754, in invoke\r\n    return __callback(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/click/decorators.py\", line 26, in new_func\r\n    return f(get_current_context(), *args, **kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/cli.py\", line 444, in materialize_command\r\n    end_date=utils.make_tzaware(datetime.fromisoformat(end_ts)),\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/usage.py\", line 269, in wrapper\r\n    return func(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/feature_store.py\", line 1087, in materialize\r\n    tqdm_builder=tqdm_builder,\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/infra/passthrough_provider.py\", line 168, in materialize_single_feature_view\r\n    lambda x: pbar.update(x),\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/infra/passthrough_provider.py\", line 86, in online_write_batch\r\n    self.online_store.online_write_batch(config, table, data, progress)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/usage.py\", line 280, in wrapper\r\n    raise exc.with_traceback(traceback)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/usage.py\", line 269, in wrapper\r\n    return func(*args, **kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/infra/online_stores/redis.py\", line 184, in online_write_batch\r\n    client = self._get_client(online_store_config)\r\n  File \"/usr/local/lib/python3.7/site-packages/feast/infra/online_stores/redis.py\", line 164, in _get_client\r\n    self._client = RedisCluster(**kwargs)\r\n  File \"/usr/local/lib/python3.7/site-packages/redis/cluster.py\", line 517, in __init__\r\n    **kwargs,\r\n  File \"/usr/local/lib/python3.7/site-packages/redis/cluster.py\", line 1125, in __init__\r\n    self.populate_startup_nodes(startup_nodes)\r\n  File \"/usr/local/lib/python3.7/site-packages/redis/cluster.py\", line 1251, in populate_startup_nodes\r\n    self.startup_nodes[n.name] = n\r\nAttributeError: 'dict' object has no attribute 'name'\r\n```\r\n\r\n## Steps to reproduce\r\n- Install Feast version 0.18.0\r\n- Set up a Redis cluster as the online store:\r\n\r\n```yaml\r\nonline_store:\r\n  type: redis\r\n  redis_type: redis_cluster\r\n  connection_string: \"host1:port1,host2:port2,host3:port3\"\r\n```\r\n\r\n- Run `feast materialize`\r\n\r\n### Specifications\r\n\r\n- Version: 0.18.0\r\n- Platform: Linux\r\n\r\n## Possible Solution\r\nSome investigation revealed that versions 0.17.0 and 0.18.0 differ in the sense that 0.18.0 uses `RedisCluster` from `redis.cluster` instead of `rediscluster`. As a result, the code [here](https://github.com/feast-dev/feast/blob/144f25c6dae6dbc4181ffa13fba1714c0baddab3/sdk/python/feast/infra/online_stores/redis.py#L164) breaks because the new `RedisCluster` instance expects to receive a list of `ClusterNode` instead of a list of dicts. Temporarily we worked around this issue by creating a custom online store (by copying all of the code in the linked file 😁 ) and changing it like so:\r\n\r\n```diff\r\n+ from redis.cluster import ClusterNode\r\n\r\n...\r\n\r\n-               kwargs[\"startup_nodes\"] = startup_nodes\r\n+               kwargs[\"startup_nodes\"] = [ClusterNode(**node) for node in startup_nodes]\r\n                self._client = RedisCluster(**kwargs)\r\n```\r\n\r\nThis worked for us, but I'm not sure if this is the best approach in general because I'm not too familiar with the codebase yet.","author":{"url":"https://github.com/vstrimaitis","@type":"Person","name":"vstrimaitis"},"datePublished":"2022-02-09T15:31:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/2297/feast/issues/2297"}