Title: Online store batch read/write interface · Issue #2281 · feast-dev/feast · GitHub
Open Graph Title: Online store batch read/write interface · Issue #2281 · feast-dev/feast
X Title: Online store batch read/write interface · Issue #2281 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. The current OnlineStore read and write interfaces are batched with respect to entity rows, but not with respect to feature views: @abstractmethod def online_read( self, confi...
Open Graph Description: Is your feature request related to a problem? Please describe. The current OnlineStore read and write interfaces are batched with respect to entity rows, but not with respect to feature views: @abs...
X Description: Is your feature request related to a problem? Please describe. The current OnlineStore read and write interfaces are batched with respect to entity rows, but not with respect to feature views: @abs...
Opengraph URL: https://github.com/feast-dev/feast/issues/2281
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Online store batch read/write interface","articleBody":"**Is your feature request related to a problem? Please describe.**\r\n\r\nThe current `OnlineStore` read and write interfaces are batched with respect to entity rows, but not with respect to feature views:\r\n```\r\n@abstractmethod\r\ndef online_read(\r\n self,\r\n config: RepoConfig,\r\n table: FeatureView,\r\n entity_keys: List[EntityKeyProto],\r\n requested_features: Optional[List[str]] = None,\r\n) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:\r\n\r\n@abstractmethod\r\ndef online_write_batch(\r\n self,\r\n config: RepoConfig,\r\n table: FeatureView,\r\n data: List[\r\n Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]\r\n ],\r\n progress: Optional[Callable[[int], Any]],\r\n) -> None:\r\n```\r\n\r\nThis makes it difficult to do store-specific optimizations. For example, batching Redis retrievals could lead to a significant speedup.\r\n\r\n**Describe the solution you'd like**\r\n\r\nIntroduce non-breaking (e.g. non-abstract) methods to the `OnlineStore` interface:\r\n```\r\n@abstractmethod\r\ndef online_read(\r\n self,\r\n config: RepoConfig,\r\n tables: List[FeatureView],\r\n entity_keys: List[EntityKeyProto],\r\n requested_features: Optional[List[str]] = None,\r\n) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:\r\n\r\n@abstractmethod\r\ndef online_write_batch(\r\n self,\r\n config: RepoConfig,\r\n tables: List[FeatureView],\r\n data: List[\r\n Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]\r\n ],\r\n progress: Optional[Callable[[int], Any]],\r\n) -> None:\r\n```\r\n\r\n**Describe alternatives you've considered**\r\nN/A\r\n\r\n**Additional context**\r\nThis is partially motivated by #2254. In particular, having a batch interface would allow for greater optimizations to the Redis online store implementation.","author":{"url":"https://github.com/felixwang9817","@type":"Person","name":"felixwang9817"},"datePublished":"2022-02-03T23:42:26Z","url":"https://github.com/feast-dev/feast/issues/2281"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:410b8089-cc47-a2c7-3a4e-e68ada927ce3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9C38:2D746B:4CD1AD:67BC95:6AFEA265 |
| html-safe-nonce | 7341b4918b28c2867bab71a73e54b6c38d8a4c6eb33f86d4c9a8cc4798e69c2f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzM4OjJENzQ2Qjo0Q0QxQUQ6NjdCQzk1OjZBRkVBMjY1IiwidmlzaXRvcl9pZCI6IjMwMjA1MzYwNjU5NjMyMzc5ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b909c8cc9b7193e252d152e5b39ba17c249d983259dcd4d46f5e50d739c9509a |
| hovercard-subject-tag | issue:1123664962 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/2281/issue_layout |
| twitter:image | https://opengraph.githubassets.com/da5bb62c439aa4cd06635b0f8fedce9fd31ee918d8096c01f1ef0f55fc432c2b/feast-dev/feast/issues/2281 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/da5bb62c439aa4cd06635b0f8fedce9fd31ee918d8096c01f1ef0f55fc432c2b/feast-dev/feast/issues/2281 |
| og:image:alt | Is your feature request related to a problem? Please describe. The current OnlineStore read and write interfaces are batched with respect to entity rows, but not with respect to feature views: @abs... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | felixwang9817 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width