Title: registry.db doesn't work in S3 subdirectory with Java Feature Server · Issue #2239 · feast-dev/feast · GitHub
Open Graph Title: registry.db doesn't work in S3 subdirectory with Java Feature Server · Issue #2239 · feast-dev/feast
X Title: registry.db doesn't work in S3 subdirectory with Java Feature Server · Issue #2239 · feast-dev/feast
Description: Expected Behavior registry.db should be fetched by java feature server in any valid S3 location. Current Behavior Java feature server can only fetch registry.db if it is in the root directory of the S3 bucket. Steps to reproduce Set regi...
Open Graph Description: Expected Behavior registry.db should be fetched by java feature server in any valid S3 location. Current Behavior Java feature server can only fetch registry.db if it is in the root directory of th...
X Description: Expected Behavior registry.db should be fetched by java feature server in any valid S3 location. Current Behavior Java feature server can only fetch registry.db if it is in the root directory of th...
Opengraph URL: https://github.com/feast-dev/feast/issues/2239
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"registry.db doesn't work in S3 subdirectory with Java Feature Server","articleBody":"## Expected Behavior \r\nregistry.db should be fetched by java feature server in any valid S3 location.\r\n\r\n## Current Behavior\r\nJava feature server can only fetch registry.db if it is in the root directory of the S3 bucket.\r\n\r\n## Steps to reproduce\r\nSet registry java config to a nested s3 path such as \"s3://bucket/child_directory/registry.db\" and the server will throw a \"No Such Key\" error. However, something like \"s3://bucket/registry.db\" works.\r\n\r\n### Specifications\r\n\r\n- Version: \r\n- Platform:\r\n- Subsystem:\r\n\r\n## Possible Solution\r\n\r\nThe issue seems to be in feast.serving.registry.S3RegistryFile.java lines 35-36:\r\n\r\n String[] split = url.replace(\"s3://\", \"\").split(\"/\");\r\n this.s3Object = this.s3Client.getObject(split[0], split[1]);\r\n\r\nThe current code splits and uses the element at index 1, which may or may not be the registry.db file. Instead, we should join back the last n-1 elements of the split array. Something like this:\r\n\r\n String[] split = url.replace(\"s3://\", \"\").split(\"/\");\r\n String objectPath = String.join(\"/\", java.util.Arrays.copyOfRange(split, 1, split.length));\r\n this.s3Object = this.s3Client.getObject(split[0], objectPath);\r\n","author":{"url":"https://github.com/shumway743","@type":"Person","name":"shumway743"},"datePublished":"2022-01-26T02:10:35Z","url":"https://github.com/feast-dev/feast/issues/2239"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:71f9f579-a70b-9cb0-22ba-376fa424cb3c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B8C2:320C6A:6C3F87:921DFD:6AFEABC9 |
| html-safe-nonce | 46475573862ee06eb61dc2e8a4ca19590128beba319971b94c6ca414bef2ccc7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEMyOjMyMEM2QTo2QzNGODc6OTIxREZEOjZBRkVBQkM5IiwidmlzaXRvcl9pZCI6IjI0Njk1NDA1OTU2NjQ1OTU5MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dd8956c536387bcfc40e120693060d8029af50d62e70d65c08796ea726ba6358 |
| hovercard-subject-tag | issue:1114551732 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/2239/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d75356ba503e80d71ac4e6e27a3fb506456dc6f21eb4dfef8b0f75a5f57e3c64/feast-dev/feast/issues/2239 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d75356ba503e80d71ac4e6e27a3fb506456dc6f21eb4dfef8b0f75a5f57e3c64/feast-dev/feast/issues/2239 |
| og:image:alt | Expected Behavior registry.db should be fetched by java feature server in any valid S3 location. Current Behavior Java feature server can only fetch registry.db if it is in the root directory of th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shumway743 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width