René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_softmax.py` does not test `argmax` and `latency` implementations; `latency` fails","articleBody":"## Quick summary\n1. `test_softmax.py` does not actually test non-default implementations (`argmax` and `latency`).\n2. If we fix that, tests for `latency` fail, reporting low accuracy.\n\n## Details\n\n### Steps to Reproduce\n\n1. Clone the hls4ml repository\n2. Checkout the main branch, commit hash: 6900257f\n3. Run `pytest test/pytest/test_softmax.py`\n4. Go e.g. to `test/pytest/test_softmax_test_softmax_9,6-input_shape6-18,8-io_parallel-False-latency-Vivado/parameters.h`, line 29, see:\n```\n    static const nnet::softmax_implementation implementation = nnet::softmax_implementation::stable;\n```\ninstead of expected `nnet::softmax_implementation::latency`.\n\n5. Now, if we replace the line\nhttps://github.com/fastmachinelearning/hls4ml/blob/6900257ff794958b834afbaa41e7c75821d3094e/test/pytest/test_softmax.py#L47\nwith\n```\n    cfg['LayerName']['softmax']['implementation'] = strategy\n```\nthen all `latency` tests fail with messages like:\n```\nAccuracy hls4ml relative to keras: 0.1908\n```\n\n6. Now, if we replace https://github.com/fastmachinelearning/hls4ml/blob/6900257ff794958b834afbaa41e7c75821d3094e/test/pytest/test_softmax.py#L19\nwith\n```\n    return np.clip(d, -32, 0)\n```\nthe the tests pass.\n\n(Catapult backend fails on my laptop because it doesn't create .so file, but that's unrelated).","author":{"url":"https://github.com/vasdommes","@type":"Person","name":"vasdommes"},"datePublished":"2026-02-19T21:00:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1443/hls4ml/issues/1443"}