René's URL Explorer Experiment


Title: ✨ Raise a more clear error when a type is not valid by ddanier · Pull Request #425 · fastapi/sqlmodel · GitHub

Open Graph Title: ✨ Raise a more clear error when a type is not valid by ddanier · Pull Request #425 · fastapi/sqlmodel

X Title: ✨ Raise a more clear error when a type is not valid by ddanier · Pull Request #425 · fastapi/sqlmodel

Description: SQL databases in Python, designed for simplicity, compatibility, and robustness. - ✨ Raise a more clear error when a type is not valid by ddanier · Pull Request #425 · fastapi/sqlmodel

Open Graph Description: Currently using Dict[...], List[...] or Union[...] will break with an error stating that issubclass() cannot be used for non types. This is something users won't understand and I think SQLModel...

X Description: Currently using Dict[...], List[...] or Union[...] will break with an error stating that issubclass() cannot be used for non types. This is something users won't understand and I think SQLM...

Opengraph URL: https://github.com/fastapi/sqlmodel/pull/425

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74848456-b987-6f7f-1305-b4d2dffaf47d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FBE:1FBC18:8BDC6C:C5D141:6AFE1B00
html-safe-nonce488abdbdd10e90d0dda802f0a3d458f3d533c7170d5284b8acdcc8a20b75dcfb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkJFOjFGQkMxODo4QkRDNkM6QzVEMTQxOjZBRkUxQjAwIiwidmlzaXRvcl9pZCI6IjY3NjQyNzgxODM5Mjg2NjY4ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace22e32defa8c4b8b3e162d1517edc645a1a3cd875fe3d44142ae2331c3d1b3e9
hovercard-subject-tagpull_request:1039861442
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fastapi/sqlmodel/425/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/80ef69c243cfa203cca982d220fa36b055b1b2fa99743fc6eb8610cd450b328c/fastapi/sqlmodel/pull/425
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80ef69c243cfa203cca982d220fa36b055b1b2fa99743fc6eb8610cd450b328c/fastapi/sqlmodel/pull/425
og:image:altCurrently using Dict[...], List[...] or Union[...] will break with an error stating that issubclass() cannot be used for non types. This is something users won't understand and I think SQLModel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameddanier
hostnamegithub.com
expected-hostnamegithub.com
Noned0525ab1464526bf4532a5551aa348cf100dff75ef808a96fc67a08b1d946aa9
turbo-cache-controlno-cache
go-importgithub.com/fastapi/sqlmodel git https://github.com/fastapi/sqlmodel.git
octolytics-dimension-user_id156354296
octolytics-dimension-user_loginfastapi
octolytics-dimension-repository_id399495186
octolytics-dimension-repository_nwofastapi/sqlmodel
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id399495186
octolytics-dimension-repository_network_root_nwofastapi/sqlmodel
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef3993a71fa20f7be8e167132fbf9619bc66e12
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/fastapi/sqlmodel/pull/425#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffastapi%2Fsqlmodel%2Fpull%2F425
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffastapi%2Fsqlmodel%2Fpull%2F425
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fastapi%2Fsqlmodel
Reloadhttps://github.com/fastapi/sqlmodel/pull/425
Reloadhttps://github.com/fastapi/sqlmodel/pull/425
Reloadhttps://github.com/fastapi/sqlmodel/pull/425
fastapihttps://github.com/fastapi
sqlmodelhttps://github.com/fastapi/sqlmodel
Codehttps://github.com/fastapi/sqlmodel
Issues1 (1)https://github.com/fastapi/sqlmodel/issues
Pull requests53 (53)https://github.com/fastapi/sqlmodel/pulls
Discussionshttps://github.com/fastapi/sqlmodel/discussions
Actionshttps://github.com/fastapi/sqlmodel/actions
Projectshttps://github.com/fastapi/sqlmodel/projects
Security and qualityhttps://github.com/fastapi/sqlmodel/security
Insightshttps://github.com/fastapi/sqlmodel/insights
https://github.com/fastapi/sqlmodel
tiangolohttps://github.com/tiangolo
fastapi:mainhttps://github.com/fastapi/sqlmodel/tree/main
ddanier:fix-get_sqlachemy_typehttps://github.com/ddanier/sqlmodel/tree/fix-get_sqlachemy_type
Conversationhttps://github.com/fastapi/sqlmodel/pull/425
Commits11 (11)https://github.com/fastapi/sqlmodel/pull/425/commits
Checkshttps://github.com/fastapi/sqlmodel/pull/425/checks
Files changedhttps://github.com/fastapi/sqlmodel/pull/425/files
✨ Raise a more clear error when a type is not validhttps://github.com/fastapi/sqlmodel/pull/425#top
tiangolohttps://github.com/tiangolo
fastapi:mainhttps://github.com/fastapi/sqlmodel/tree/main
ddanier:fix-get_sqlachemy_typehttps://github.com/ddanier/sqlmodel/tree/fix-get_sqlachemy_type
https://github.com/ddanier
ddanierhttps://github.com/ddanier
Aug 29, 2022https://github.com/fastapi/sqlmodel/pull/425#issue-1354485787
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
ddanierhttps://github.com/ddanier
August 29, 2022 17:20https://github.com/fastapi/sqlmodel/pull/425#commits-pushed-0024745
https://github.com/ddanier
Add failing test for test_get_sqlachemy_type()https://github.com/fastapi/sqlmodel/pull/425/commits/0024745ef94bcfb3b98a6ebeffe904f894ccddfa
0024745https://github.com/fastapi/sqlmodel/pull/425/commits/0024745ef94bcfb3b98a6ebeffe904f894ccddfa
https://github.com/ddanier
Fix get_sqlachemy_type() not checking for a valid type firsthttps://github.com/fastapi/sqlmodel/pull/425/commits/57f5112149e46e8ee6a3e02003064eb74598d706
57f5112https://github.com/fastapi/sqlmodel/pull/425/commits/57f5112149e46e8ee6a3e02003064eb74598d706
https://github.com/ddanier
Add Union type to testshttps://github.com/fastapi/sqlmodel/pull/425/commits/7967bcb48393aeea1e1ece2e4b64b8eb5fb22e36
7967bcbhttps://github.com/fastapi/sqlmodel/pull/425/commits/7967bcb48393aeea1e1ece2e4b64b8eb5fb22e36
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 29, 2022https://github.com/fastapi/sqlmodel/pull/425#issuecomment-1230473622
7967bcbhttps://github.com/fastapi/sqlmodel/commit/7967bcb48393aeea1e1ece2e4b64b8eb5fb22e36
https://630cda8afbefa94f41c70df1--sqlmodel.netlify.apphttps://630cda8afbefa94f41c70df1--sqlmodel.netlify.app
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 29, 2022https://github.com/fastapi/sqlmodel/pull/425#issuecomment-1230473652
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
Codecovhttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
(ea79c47)https://app.codecov.io/gh/tiangolo/sqlmodel/commit/ea79c47c0ed34fc878600c3eaad6909106a0cf4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
(55c10b5)https://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
55c10b5https://github.com/fastapi/sqlmodel/commit/55c10b5b97142875044b35ac4c3b91ce4e910de9
4e376dfhttps://github.com/fastapi/sqlmodel/commit/4e376dfed450e2ead5042877742dc785a216841c
4e376dfhttps://github.com/fastapi/sqlmodel/commit/4e376dfed450e2ead5042877742dc785a216841c
Fileshttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
tests/test_get_sqlachemy_type.pyhttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez#diff-dGVzdHMvdGVzdF9nZXRfc3FsYWNoZW15X3R5cGUucHk=
sqlmodel/main.pyhttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez#diff-c3FsbW9kZWwvbWFpbi5weQ==
2 files with indirect coverage changeshttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/tiangolo/sqlmodel/pull/425?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebasti%C3%A1n+Ram%C3%ADrez
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.com/ddanier
Run isort to make linter happy 👍🤞https://github.com/fastapi/sqlmodel/pull/425/commits/55c10b5b97142875044b35ac4c3b91ce4e910de9
55c10b5https://github.com/fastapi/sqlmodel/pull/425/commits/55c10b5b97142875044b35ac4c3b91ce4e910de9
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 29, 2022https://github.com/fastapi/sqlmodel/pull/425#issuecomment-1230648980
55c10b5https://github.com/fastapi/sqlmodel/commit/55c10b5b97142875044b35ac4c3b91ce4e910de9
https://630cfc073e4a7000b12222dd--sqlmodel.netlify.apphttps://630cfc073e4a7000b12222dd--sqlmodel.netlify.app
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.com/daniil-berg
daniil-berghttps://github.com/daniil-berg
Sep 9, 2022 https://github.com/fastapi/sqlmodel/pull/425#ref-pullrequest-1367043017
🐛 Fix enum type checks ordering in get_sqlalchemy_type #442 https://github.com/fastapi/sqlmodel/pull/442
https://github.com/tiangolo
tiangolohttps://github.com/tiangolo
bug https://github.com/fastapi/sqlmodel/issues?q=state%3Aopen%20label%3Abug
Oct 22, 2023https://github.com/fastapi/sqlmodel/pull/425#event-10733178614
tiangolohttps://github.com/tiangolo
October 22, 2023 21:33https://github.com/fastapi/sqlmodel/pull/425#commits-pushed-cebd3a5
https://github.com/tiangolo
🔀 Merge branch 'main' into pr/ddanier/425https://github.com/fastapi/sqlmodel/pull/425/commits/cebd3a59e9348f4c23728689e2de401368b5563c
cebd3a5https://github.com/fastapi/sqlmodel/pull/425/commits/cebd3a59e9348f4c23728689e2de401368b5563c
https://github.com/tiangolo
🚚 Rename function get_sqlaclhemy_typehttps://github.com/fastapi/sqlmodel/pull/425/commits/99a837e130112c1b85bdbcc6ddb28e512fa4119c
99a837ehttps://github.com/fastapi/sqlmodel/pull/425/commits/99a837e130112c1b85bdbcc6ddb28e512fa4119c
https://github.com/tiangolo
🚚 Rename get_sqlalchemy_typehttps://github.com/fastapi/sqlmodel/pull/425/commits/fd816bf0672f279395f112134d3b8cab285d39f7
fd816bfhttps://github.com/fastapi/sqlmodel/pull/425/commits/fd816bf0672f279395f112134d3b8cab285d39f7
https://github.com/tiangolo
✅ Update tests, use complete full use caseshttps://github.com/fastapi/sqlmodel/pull/425/commits/2694e5d1d1eb778eb3f654f915136648df4f1274
2694e5dhttps://github.com/fastapi/sqlmodel/pull/425/commits/2694e5d1d1eb778eb3f654f915136648df4f1274
https://github.com/tiangolo
🐛 Fix implementation for complete use caseshttps://github.com/fastapi/sqlmodel/pull/425/commits/6ad38cbf0903f4269142ef017c00fb50fcd7e961
6ad38cbhttps://github.com/fastapi/sqlmodel/pull/425/commits/6ad38cbf0903f4269142ef017c00fb50fcd7e961
https://github.com/tiangolo
tiangolohttps://github.com/tiangolo
Oct 23, 2023https://github.com/fastapi/sqlmodel/pull/425#event-10736260895
https://github.com/tiangolo
tiangolohttps://github.com/tiangolo
feature https://github.com/fastapi/sqlmodel/issues?q=state%3Aopen%20label%3Afeature
bug https://github.com/fastapi/sqlmodel/issues?q=state%3Aopen%20label%3Abug
Oct 23, 2023https://github.com/fastapi/sqlmodel/pull/425#event-10736261591
tiangolohttps://github.com/tiangolo
October 23, 2023 10:32https://github.com/fastapi/sqlmodel/pull/425#commits-pushed-47eaf08
https://github.com/tiangolo
🎨 Fix formathttps://github.com/fastapi/sqlmodel/pull/425/commits/47eaf081b5e8f1dcbe3f4036a779f404e0f0bcef
47eaf08https://github.com/fastapi/sqlmodel/pull/425/commits/47eaf081b5e8f1dcbe3f4036a779f404e0f0bcef
https://github.com/tiangolo
🎨 Format testshttps://github.com/fastapi/sqlmodel/pull/425/commits/4e376dfed450e2ead5042877742dc785a216841c
4e376dfhttps://github.com/fastapi/sqlmodel/pull/425/commits/4e376dfed450e2ead5042877742dc785a216841c
https://github.com/tiangolo
tiangolohttps://github.com/tiangolo
Oct 23, 2023https://github.com/fastapi/sqlmodel/pull/425#issuecomment-1774527318
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.com/tiangolo
tiangolohttps://github.com/tiangolo
840fd08https://github.com/fastapi/sqlmodel/commit/840fd08ab2f803d4e8fb67c7587a59621473c715
Oct 23, 2023https://github.com/fastapi/sqlmodel/pull/425#event-10736342264
https://github.com/ddanier
ddanierhttps://github.com/ddanier
October 23, 2023 08:26https://github.com/fastapi/sqlmodel/pull/425#event-10737398572
https://github.com/ddanier
ddanierhttps://github.com/ddanier
Oct 23, 2023https://github.com/fastapi/sqlmodel/pull/425#issuecomment-1774679074
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.co/hiddenchars
https://github.com/fastapi/sqlmodel/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffastapi%2Fsqlmodel%2Fpull%2F425
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
feature https://github.com/fastapi/sqlmodel/issues?q=state%3Aopen%20label%3Afeature
Please reload this pagehttps://github.com/fastapi/sqlmodel/pull/425
https://github.com/ddanier
https://github.com/tiangolo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.