René's URL Explorer Experiment


Title: LLVM 18 by csegarragonz · Pull Request #123 · faasm/cpp · GitHub

Open Graph Title: LLVM 18 by csegarragonz · Pull Request #123 · faasm/cpp

X Title: LLVM 18 by csegarragonz · Pull Request #123 · faasm/cpp

Description: In this PR we move the WASM LLVM version to 18 and the native one to 17. As much as it hurts, recent changes in wasi-libc drop support for LLVM < 15. This means that we cannot keep up to date with upstream wasi-libc, which is necessary for an integrity issue that I am seeing with OpenMP execution. In summary, I would like to re-build wasi-libc with atomics (and shared memory) support. I could either patch this on top of our current version of wasi-libc, or rebase to the latest commit, and build from there. The former sounds appealing, but I think the latter is the safest strategy long-term. In addition, it more and more seems that re-entrant WASM modules (i.e. WASM modules that will be concurrently operated on by different threads) and non-re-entrant WASM modules have incompatible toolchains. To this extent, I change our sysroot structure to match more that of wasi-sdk. Now, we support having different targets for different WASM features (that are incompatible with each other). This also deems obsolete the old THREAD_MODEL=faasm that we used to have, allowing to have co-existing purely non-reentrant sysroot and a re-entrant one. In this PR we have: /usr/local/faasm/llvm-sysroot/{include,lib}/wasm32-wasi: for non-atomic, non-threaded code. /usr/local/faasm/llvm-sysroot/{include,lib}/wasm32-wasi-threads: for atomic WASM. Note that, in the latter, we still disable native WASM threads by carefully linking with out own pthread implementation rather than wasi-libcs. This should also greatly simplify our diff with upstream wasi-libc.

Open Graph Description: In this PR we move the WASM LLVM version to 18 and the native one to 17. As much as it hurts, recent changes in wasi-libc drop support for LLVM < 15. This means that we cannot keep up to date wi...

X Description: In this PR we move the WASM LLVM version to 18 and the native one to 17. As much as it hurts, recent changes in wasi-libc drop support for LLVM &lt; 15. This means that we cannot keep up to dat...

Opengraph URL: https://github.com/faasm/cpp/pull/123

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:fb2fe619-2778-ab8d-bb99-2c2af19621c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE76C:16C596:4E8C289:689B5F0:6A6555E0
html-safe-nonce1d98090ff0485040905cdd4802ace5edaa64bde93da629bc8c85872e9a9beb13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzZDOjE2QzU5Njo0RThDMjg5OjY4OUI1RjA6NkE2NTU1RTAiLCJ2aXNpdG9yX2lkIjoiMjEwMTkxNTE4OTIzNTc2Njc1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3fa81a35348a58334d18307b4d4328689d0e51e7ba483890937e950ee6dd929a
hovercard-subject-tagpull_request:1719746736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
twitter:imagehttps://avatars.githubusercontent.com/u/19322012?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19322012?s=400&v=4
og:image:altIn this PR we move the WASM LLVM version to 18 and the native one to 17. As much as it hurts, recent changes in wasi-libc drop support for LLVM < 15. This means that we cannot keep up to date wi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/faasm/cpp git https://github.com/faasm/cpp.git
octolytics-dimension-user_id72010129
octolytics-dimension-user_loginfaasm
octolytics-dimension-repository_id290212556
octolytics-dimension-repository_nwofaasm/cpp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id290212556
octolytics-dimension-repository_network_root_nwofaasm/cpp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffaasm%2Fcpp%2Fpull%2F123%2Fcommits%2Fa61d8b082c92cf5173bdc84c344327a2400a4044
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffaasm%2Fcpp%2Fpull%2F123%2Fcommits%2Fa61d8b082c92cf5173bdc84c344327a2400a4044
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=faasm%2Fcpp
Reloadhttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Reloadhttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Reloadhttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Please reload this pagehttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
faasm https://github.com/faasm
cpphttps://github.com/faasm/cpp
Notifications https://github.com/login?return_to=%2Ffaasm%2Fcpp
Fork 7 https://github.com/login?return_to=%2Ffaasm%2Fcpp
Star 6 https://github.com/login?return_to=%2Ffaasm%2Fcpp
Code https://github.com/faasm/cpp
Issues 0 https://github.com/faasm/cpp/issues
Pull requests 0 https://github.com/faasm/cpp/pulls
Actions https://github.com/faasm/cpp/actions
Projects https://github.com/faasm/cpp/projects
Security and quality 0 https://github.com/faasm/cpp/security
Insights https://github.com/faasm/cpp/pulse
Code https://github.com/faasm/cpp
Issues https://github.com/faasm/cpp/issues
Pull requests https://github.com/faasm/cpp/pulls
Actions https://github.com/faasm/cpp/actions
Projects https://github.com/faasm/cpp/projects
Security and quality https://github.com/faasm/cpp/security
Insights https://github.com/faasm/cpp/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffaasm%2Fcpp%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffaasm%2Fcpp%2Fissues%2Fnew%2Fchoose
csegarragonzhttps://github.com/csegarragonz
mainhttps://github.com/faasm/cpp/tree/main
llvm-17https://github.com/faasm/cpp/tree/llvm-17
Conversation 0 https://github.com/faasm/cpp/pull/123
Commits 36 https://github.com/faasm/cpp/pull/123/commits
Checks 0 https://github.com/faasm/cpp/pull/123/checks
Files changed https://github.com/faasm/cpp/pull/123/files
Please reload this pagehttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
LLVM 18 https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044#top
Show all changes 36 commits https://github.com/faasm/cpp/pull/123/files
bd60141 gh: bump code version csegarragonz Feb 9, 2024 https://github.com/faasm/cpp/pull/123/commits/bd60141594134de928cdac69a66fa2924b6c22ca
1158e8b faasmtools: bump llvm version csegarragonz Feb 9, 2024 https://github.com/faasm/cpp/pull/123/commits/1158e8b26948809de5e1f2a83bdd38ecaacc1e07
2aa9661 llvm: changes for latest wasi-libc and wasi-sdk csegarragonz Feb 12, 2024 https://github.com/faasm/cpp/pull/123/commits/2aa96617e17e3d2a58112dc31b4e2e910ffbf48b
6afffa4 llvm: install libclang_rt.builitins-wasm32.a csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/6afffa4b4b277ba97570415caa7fc78ebff31e6a
9969423 cmake: change system name from Wasm to WASI to align with wasi-sdk csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/9969423335be3a4eda4e95193c0991bfc294224a
a61d8b0 faasmtools: enable linker feature sign extension as it is the default… csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
852fc4a libs: install in /lib/wasm32-wasi and copy imports appropria… csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/852fc4a05af2d8b6005c5932682242d43f8b3dc9
53f6567 docker: enable some features csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/53f656787e66ece3320b6e7d8d85aed310b42c2d
4c65d67 libs: install libraries and headers in the right location csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/4c65d67b2ce82d2bf0868e649c5fc442268d6e40
29403d4 llvm: fix libclanv_rt.builitins installation csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/29403d4c3530eaad60090221b66ac2a15d348806
f7fe16b mpi: more fixes to the cmake file csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/f7fe16ba21ec581c61f7eab6f314fc8d0baf1928
65cc765 wasi: attempt at having two different targets for threads and non-thr… csegarragonz Feb 13, 2024 https://github.com/faasm/cpp/pull/123/commits/65cc765563dc1ad263646ff2fdf60384e1e27bc6
0f0125d func: comment out temporarily disabled functions csegarragonz Feb 15, 2024 https://github.com/faasm/cpp/pull/123/commits/0f0125d4d07c741cd0efae2c8418e88505de88a1
4242785 func: move threaded functions to separate top-level directory csegarragonz Feb 16, 2024 https://github.com/faasm/cpp/pull/123/commits/4242785d5b1055087c3b5338cbd3a17acfe5dc4e
d69921e tasks: configurable compilation for different targets csegarragonz Feb 16, 2024 https://github.com/faasm/cpp/pull/123/commits/d69921e69fb5ab8930c8cac028b30827ab7cca15
47be01e threads: support for pthread apis csegarragonz Feb 16, 2024 https://github.com/faasm/cpp/pull/123/commits/47be01e5285de6c93a85d6c9726f9aa45751d31d
0b67978 cpython: changes to make cpython build work csegarragonz Feb 19, 2024 https://github.com/faasm/cpp/pull/123/commits/0b6797865c49d0691f67a55424f415541ad84ee3
022ab93 llvm: add c compiler target flag for compiler-rt build csegarragonz Feb 19, 2024 https://github.com/faasm/cpp/pull/123/commits/022ab931403dd0099897fc32911adaf9e80bd958
eaaf4d5 libs: fix use of (auto)conf with different sysroots csegarragonz Feb 19, 2024 https://github.com/faasm/cpp/pull/123/commits/eaaf4d5cd5b1ea440f25d09a7c1bb82aac0169b3
6cf9946 more fixes csegarragonz Feb 19, 2024 https://github.com/faasm/cpp/pull/123/commits/6cf99463223b22c274314b22304578bbfdaf7309
ca0d78e faasmtools: change default target when building a threaded application csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/ca0d78e543d2188f5f89077b64735749619a9be5
2ca4ee6 llvm: bump to version 18 rc2 to fix the frontend bug with openmp csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/2ca4ee64a6870249189ec90d0a1f25fb448e7413
17e844e llvm: no harm in using clang-18 to build llvm-18 csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/17e844e97384b6e6ac8d6e81d4636cf06c8b9674
676ce38 llvm: use clang-17 for native compilation csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/676ce382ad4a78b4107b0d3f2f16539686398a94
5a2ec10 nits: fix python formatting csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/5a2ec10605cc265268bebcffd01f228bc6a70476
c785471 nits: fix cpp formatting csegarragonz Feb 20, 2024 https://github.com/faasm/cpp/pull/123/commits/c78547194fba8f44583fd6d5c47d3abb2a0c5f4c
1460297 nit: run python formatting csegarragonz Feb 21, 2024 https://github.com/faasm/cpp/pull/123/commits/14602974377c90869e835387f7ff0cb16fb227e1
4b6e62f func: build all threads func csegarragonz Feb 21, 2024 https://github.com/faasm/cpp/pull/123/commits/4b6e62fb1b50903ead7f53495c617c054f43ce0d
27aae15 gha: skip code formatting with clang-format-17 csegarragonz Feb 21, 2024 https://github.com/faasm/cpp/pull/123/commits/27aae1519e5d4ada3704e7e546bdbaa18a077728
89c98da clang-format: fix formatting after llvm bump csegarragonz Mar 1, 2024 https://github.com/faasm/cpp/pull/123/commits/89c98da474c75674dabf36bad7641a0768a04df7
8d5c4a9 nits: clang-format passing with llvm 17 csegarragonz Mar 4, 2024 https://github.com/faasm/cpp/pull/123/commits/8d5c4a995819a813f791e9aa33a317bed1fda881
e42390a tasks(libs): build threads/non-threads in different directories csegarragonz Mar 5, 2024 https://github.com/faasm/cpp/pull/123/commits/e42390af2ecd59a944828a57b52d4f8a5eee3927
bfad3a8 docker: fix strange libfaasm overwrite csegarragonz Mar 5, 2024 https://github.com/faasm/cpp/pull/123/commits/bfad3a8e8ab4aff363e6898bd672175ddf765686
731744f funcs: set the threads target when appropriate csegarragonz Mar 5, 2024 https://github.com/faasm/cpp/pull/123/commits/731744f7745159338707152dab8f2d357e913e7f
1e23e89 nits: self-review csegarragonz Mar 12, 2024 https://github.com/faasm/cpp/pull/123/commits/1e23e89980750b55d300ef4b477779a7f01ca029
16b97f2 libffi: fix build by passing --host flag to configure csegarragonz Mar 12, 2024 https://github.com/faasm/cpp/pull/123/commits/16b97f22c8613d58bb43379691bb051e0b022c59
Clear filters https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Please reload this pagehttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Please reload this pagehttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
Prev https://github.com/faasm/cpp/pull/123/commits/9969423335be3a4eda4e95193c0991bfc294224a
Next https://github.com/faasm/cpp/pull/123/commits/852fc4a05af2d8b6005c5932682242d43f8b3dc9
Please reload this pagehttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044
https://github.com/csegarragonz
csegarragonzhttps://github.com/faasm/cpp/commits?author=csegarragonz
faasmtools/build.pyhttps://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044#diff-d42d1dce6c36f808dc9de6f569ea8141a49a4a4f2fc939c4d0737b3e8540f08a
View file https://github.com/faasm/cpp/blob/a61d8b082c92cf5173bdc84c344327a2400a4044/faasmtools/build.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/faasm/cpp/pull/123/commits/{{ revealButtonHref }}
https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044#diff-d42d1dce6c36f808dc9de6f569ea8141a49a4a4f2fc939c4d0737b3e8540f08a
https://github.com/faasm/cpp/pull/123/commits/a61d8b082c92cf5173bdc84c344327a2400a4044#diff-d42d1dce6c36f808dc9de6f569ea8141a49a4a4f2fc939c4d0737b3e8540f08a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.