René's URL Explorer Experiment

Title: feat: Drain in-flight requests on stop by thced · Pull Request #133 · extenda/openapi-httpserver-java · GitHub

Open Graph Title: feat: Drain in-flight requests on stop by thced · Pull Request #133 · extenda/openapi-httpserver-java

X Title: feat: Drain in-flight requests on stop by thced · Pull Request #133 · extenda/openapi-httpserver-java

Description: Summary OpenApiServer.stop(delay) could wait out the full delay with no request in flight. In the JDK's HttpServer (ServerImpl, JDK 25), if a client closes an idle keep-alive connection just before stop, the connection is cleaned up but the finished latch is never counted down. stop then sleeps the whole delay. A plain-JDK repro stalls in about 1 of 4 rounds. Consumers see it as slow shutdowns and 5 s stalls in tests. OpenApiServer now counts in-flight requests itself: InFlightCounter is a filter, first on every context the server creates. It counts each request through its handler and afterResponse runnables, with the decrement in finally. stop(delay): starts HttpServer.stop(delay) on a virtual thread, so the listener closes at once and new connections are refused as before; waits on the counter for at most delay; calls HttpServer.stop(0), which releases the JDK's latch. Open keep-alive connections are still served until the JDK sees no exchange in flight, as before. Repeated stop: later and concurrent calls wait for the first one to finish. A failure in the first call reaches them as an IllegalStateException. inFlightRequests() is new public API that exposes the count, so callers can build their own drain. Notes feat: new public API, and a second stop call now waits for the first. GracefulStopIT (11 tests, about 3 s): the raw-socket loop and the interrupt test fail on the old stop; the keep-alive client loop is a secondary guard; the rest specify the behaviour. The OpenApiServerIT$Filters hang is unrelated to this change. One mvn verify run hung in postFilterShortStringMatchesNoBranchReturns400. Looping the same scenario hangs on master at the same rate (3 in 12,000, against 1 in 12,000 on this branch). The cause: the server binds the wildcard address on a random port, and another local process can already hold that port on 127.0.0.1, so localhost reaches it instead. A fix would be a separate change: tests bind and call 127.0.0.1. Not changed: the virtual-thread executor is still never closed on stop.

Open Graph Description: Summary OpenApiServer.stop(delay) could wait out the full delay with no request in flight. In the JDK's HttpServer (ServerImpl, JDK 25), if a client closes an idle keep-alive connection just be...

X Description: Summary OpenApiServer.stop(delay) could wait out the full delay with no request in flight. In the JDK's HttpServer (ServerImpl, JDK 25), if a client closes an idle keep-alive connection jus...

Opengraph URL: https://github.com/extenda/openapi-httpserver-java/pull/133

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width