René's URL Explorer Experiment


Title: fix(sensors): do not truncate negative values for gyro by JakubVanek · Pull Request #694 · ev3dev-lang-java/ev3dev-lang-java · GitHub

Open Graph Title: fix(sensors): do not truncate negative values for gyro by JakubVanek · Pull Request #694 · ev3dev-lang-java/ev3dev-lang-java

X Title: fix(sensors): do not truncate negative values for gyro by JakubVanek · Pull Request #694 · ev3dev-lang-java/ev3dev-lang-java

Description: Previously, negative values from sensors were truncated to zero. This happened because Float.MIN_VALUE in Java is the smallest positive value that a float can have. It is therefore necessary to use -Float.MAX_VALUE as a lower bound to disable limiting. Reproducer can be created from the provided unit test. I've checked that without the fix, the provided unit test fails and succeeds when the change is applied. Fixes: #693

Open Graph Description: Previously, negative values from sensors were truncated to zero. This happened because Float.MIN_VALUE in Java is the smallest positive value that a float can have. It is therefore necessary to use...

X Description: Previously, negative values from sensors were truncated to zero. This happened because Float.MIN_VALUE in Java is the smallest positive value that a float can have. It is therefore necessary to use...

Opengraph URL: https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c9215fc-eaea-25ee-6e32-311431d9922b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FB6:4CFEF:D05B7:11CFD8:6AFD9A75
html-safe-nonce7d534b1e36213cdfe4a933ef66b62cce17da249df9e2de64a8ecce8383026602
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkI2OjRDRkVGOkQwNUI3OjExQ0ZEODo2QUZEOUE3NSIsInZpc2l0b3JfaWQiOiIyNjA4NDYwNTc0MTE5MjcxMDI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb27ecbc6e2fb82a76bb78997f607fb4cd11f6db05da2852beac1af8fd9b74fd
hovercard-subject-tagpull_request:344888667
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
twitter:imagehttps://avatars.githubusercontent.com/u/6003171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6003171?s=400&v=4
og:image:altPreviously, negative values from sensors were truncated to zero. This happened because Float.MIN_VALUE in Java is the smallest positive value that a float can have. It is therefore necessary to use...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/ev3dev-lang-java/ev3dev-lang-java git https://github.com/ev3dev-lang-java/ev3dev-lang-java.git
octolytics-dimension-user_id17526590
octolytics-dimension-user_loginev3dev-lang-java
octolytics-dimension-repository_id45205585
octolytics-dimension-repository_nwoev3dev-lang-java/ev3dev-lang-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45205585
octolytics-dimension-repository_network_root_nwoev3dev-lang-java/ev3dev-lang-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fev3dev-lang-java%2Fev3dev-lang-java%2Fpull%2F694%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fev3dev-lang-java%2Fev3dev-lang-java%2Fpull%2F694%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=ev3dev-lang-java%2Fev3dev-lang-java
Reloadhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
Reloadhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
Reloadhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
ev3dev-lang-javahttps://github.com/ev3dev-lang-java
ev3dev-lang-javahttps://github.com/ev3dev-lang-java/ev3dev-lang-java
Codehttps://github.com/ev3dev-lang-java/ev3dev-lang-java
Issues21 (21)https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues
Pull requests4 (4)https://github.com/ev3dev-lang-java/ev3dev-lang-java/pulls
Discussionshttps://github.com/ev3dev-lang-java/ev3dev-lang-java/discussions
Actionshttps://github.com/ev3dev-lang-java/ev3dev-lang-java/actions
Security and qualityhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/security
Insightshttps://github.com/ev3dev-lang-java/ev3dev-lang-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fev3dev-lang-java%2Fev3dev-lang-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fev3dev-lang-java%2Fev3dev-lang-java%2Fissues%2Fnew%2Fchoose
jabrenahttps://github.com/jabrena
ev3dev-lang-java:masterhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/tree/master
Conversation 7 https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694
Commits 1 https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/commits
Checks 0 https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/checks
Files changed https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
Please reload this pagehttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
fix(sensors): do not truncate negative values for gyro https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#top
Show all changes 1 commit https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
bd5540d fix(sensors): do not truncate negative values for gyro JakubVanek Dec 1, 2019 https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/commits/bd5540db6b0cae851f5f017eac4544b3faec7abd
Clear filters https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
Please reload this pagehttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
Please reload this pagehttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files
EV3GyroSensor.java https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-d2744f160cd73e2147d2da22abe15047de31e4be3bb762da893defed5d6fe14d
EV3GyroSensorTest.java https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-bc98496b4cbc1ecaf98d4aac43ee7a02fecf21d34866be0f814dd2401229c111
BaseElement.java https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-4babf957a6a0df21b34eee5846499b71fef1a21d5f1f7cc0fdcf8c5bc3609814
src/main/java/ev3dev/sensors/ev3/EV3GyroSensor.javahttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-d2744f160cd73e2147d2da22abe15047de31e4be3bb762da893defed5d6fe14d
View file https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/bd5540db6b0cae851f5f017eac4544b3faec7abd/src/main/java/ev3dev/sensors/ev3/EV3GyroSensor.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/{{ revealButtonHref }}
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-d2744f160cd73e2147d2da22abe15047de31e4be3bb762da893defed5d6fe14d
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-d2744f160cd73e2147d2da22abe15047de31e4be3bb762da893defed5d6fe14d
src/test/java/ev3dev/sensors/ev3/EV3GyroSensorTest.javahttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-bc98496b4cbc1ecaf98d4aac43ee7a02fecf21d34866be0f814dd2401229c111
View file https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/bd5540db6b0cae851f5f017eac4544b3faec7abd/src/test/java/ev3dev/sensors/ev3/EV3GyroSensorTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/{{ revealButtonHref }}
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-bc98496b4cbc1ecaf98d4aac43ee7a02fecf21d34866be0f814dd2401229c111
src/test/java/fake_ev3dev/BaseElement.javahttps://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-4babf957a6a0df21b34eee5846499b71fef1a21d5f1f7cc0fdcf8c5bc3609814
View file https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/bd5540db6b0cae851f5f017eac4544b3faec7abd/src/test/java/fake_ev3dev/BaseElement.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/{{ revealButtonHref }}
https://github.com/ev3dev-lang-java/ev3dev-lang-java/pull/694/files#diff-4babf957a6a0df21b34eee5846499b71fef1a21d5f1f7cc0fdcf8c5bc3609814
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.