Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java · GitHub
Open Graph Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java
X Title: Improve the usage of Sysfs in the interaction with EV3Dev · Issue #765 · ev3dev-lang-java/ev3dev-lang-java
Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this iteration: Moving from static methods, t...
Open Graph Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ...
X Description: In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ...
Opengraph URL: https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/765
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve the usage of Sysfs in the interaction with EV3Dev","articleBody":"In the previous Issue:\r\nhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/748\r\n\r\nWe improved the performance with current architecture, the usage of `Sysfs`. `Sysfs` in the current form, is a stateless class with static methods. \r\n\r\nIdeas to improve in this iteration:\r\n\r\n- [ ] Moving from static methods, to instance methods\r\n- [ ] Add `setSysfs` to `Mock` Sysfs to improve testing. Using `Guava`, it could be possible to expose only for testing with the annotation `@VisibleForTesting` but I don´t want to increase the weight of the jar in 2mb.\r\n\r\n@dwalend, what other ideas, do you have?\r\n@JakubVanek, what other ideas, do you have? \r\n\r\nIn your opinion, what state is necessary to maintain in `Sysfs` and have some kind of concurrency protection?\r\n\r\n**Criterias for PR:**\r\n- Branch: `sysfs_perf2`\r\n- Code pass Checkstyle: `gradle checkstyleMain` \r\n- Benchmarks: `JMH`\r\n- Complexity: Reduced\r\n- Number of changes: Minimum\r\n- Tests: Every new class, requiere Unit Tests. Review how to add Concurrency tests to avoid concurrency issues.\r\n\r\nWe will analyse for the classes: \r\n\r\n- [ ] ev3dev.sensors.Battery;\r\n- [ ] ev3dev.actuators.ev3.EV3Led;\r\n- [ ] ev3dev.actuators.lego.motors.EV3LargeRegulatedMotor;\r\n\r\nWe will begin with Battery, an easy case and later, we will tackle a complex case like a Motor.\r\n\r\n\r\n\r\nJuan Antonio","author":{"url":"https://github.com/jabrena","@type":"Person","name":"jabrena"},"datePublished":"2020-12-27T22:45:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":83},"url":"https://github.com/765/ev3dev-lang-java/issues/765"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cc50a6b4-b6d5-e712-c927-746cebfc1bab |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EE24:179CB9:8D8A7FF:BA51614:696DF032 |
| html-safe-nonce | dfb3e04d60da30fa21e181911b1b4301a872cf8f39dc18bc25a4d2f1ffe0c644 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTI0OjE3OUNCOTo4RDhBN0ZGOkJBNTE2MTQ6Njk2REYwMzIiLCJ2aXNpdG9yX2lkIjoiNTk0NDU0NjQ1MDk3OTI4NzA5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d6b31968f4edf7196a10a6efd5e54cab25169dc35273e5b837bbd328b8a098fe |
| hovercard-subject-tag | issue:775121808 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ev3dev-lang-java/ev3dev-lang-java/765/issue_layout |
| twitter:image | https://opengraph.githubassets.com/12222777da8861f4c8cd5ac6e5811389b09f0863cda6ae7aede4e0b6431d872a/ev3dev-lang-java/ev3dev-lang-java/issues/765 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12222777da8861f4c8cd5ac6e5811389b09f0863cda6ae7aede4e0b6431d872a/ev3dev-lang-java/ev3dev-lang-java/issues/765 |
| og:image:alt | In the previous Issue: #748 We improved the performance with current architecture, the usage of Sysfs. Sysfs in the current form, is a stateless class with static methods. Ideas to improve in this ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jabrena |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064 |
| turbo-cache-control | no-preview |
| go-import | github.com/ev3dev-lang-java/ev3dev-lang-java git https://github.com/ev3dev-lang-java/ev3dev-lang-java.git |
| octolytics-dimension-user_id | 17526590 |
| octolytics-dimension-user_login | ev3dev-lang-java |
| octolytics-dimension-repository_id | 45205585 |
| octolytics-dimension-repository_nwo | ev3dev-lang-java/ev3dev-lang-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45205585 |
| octolytics-dimension-repository_network_root_nwo | ev3dev-lang-java/ev3dev-lang-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7e5ae23c70136152637ceee8d6faceb35596ec46 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width