Title: Modifications and cleanup for compilation on OS/X by waTeim · Pull Request #42 · etr/libhttpserver · GitHub
Open Graph Title: Modifications and cleanup for compilation on OS/X by waTeim · Pull Request #42 · etr/libhttpserver
X Title: Modifications and cleanup for compilation on OS/X by waTeim · Pull Request #42 · etr/libhttpserver
Description: I've made modifications mostly for compilation on OS/X to succeed. Found 1 generic bug and one bug that is OS/X specific. The resulting library have been tested by inclusion in a program compiled for both OS/X and Linux. The changes are limited in scope and can be verified readily by inspection. I also made some changes that are not strictly necessary, but suited to my development environment. More specifically; clang requires that the copy constructor of http_endpoint be public. Changed to match declarations and forward declarations; class for class, struct for struct clang may have further requirements needing fully defined types or there is a scenario not seen before that can give rise to use of a class not fully defined for which include file inclusion fixes the problem OS/X AF_INET STREAM_SOCKETS do not support SOCK_CLOSEXEC; the system call returns EPROTONOSUPPORT not EINVAL. Changed a getter to const as it doesn't change the class state and expands the scenarios in which a temporary object need not be created. Fixed a typo in set_requestor_port. Changed to allow building in the same directory, modified .gitignore to ignore the resulting targets
Open Graph Description: I've made modifications mostly for compilation on OS/X to succeed. Found 1 generic bug and one bug that is OS/X specific. The resulting library have been tested by inclusion in a program comp...
X Description: I've made modifications mostly for compilation on OS/X to succeed. Found 1 generic bug and one bug that is OS/X specific. The resulting library have been tested by inclusion in a program ...
Opengraph URL: https://github.com/etr/libhttpserver/pull/42
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c6819350-7fe4-d4d1-0dd5-5c3c38b9918b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D250:101A9F:1BF1C69:2594390:6A536C80 |
| html-safe-nonce | f33db3e1d7a96864216fdc551a8d0825ae0fbd2aa6fed99af8a6b506b08f2be1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjUwOjEwMUE5RjoxQkYxQzY5OjI1OTQzOTA6NkE1MzZDODAiLCJ2aXNpdG9yX2lkIjoiODkzNzYwOTkxNTc2NzQxNzk4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a0f265ff26435feb937e797752b346de15dec11b0b83992cd72167fdf4b0e1bb |
| hovercard-subject-tag | pull_request:12633493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/etr/libhttpserver/pull/42/files |
| twitter:image | https://avatars.githubusercontent.com/u/5779395?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5779395?s=400&v=4 |
| og:image:alt | I've made modifications mostly for compilation on OS/X to succeed. Found 1 generic bug and one bug that is OS/X specific. The resulting library have been tested by inclusion in a program comp... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/etr/libhttpserver git https://github.com/etr/libhttpserver.git |
| octolytics-dimension-user_id | 1201536 |
| octolytics-dimension-user_login | etr |
| octolytics-dimension-repository_id | 3416891 |
| octolytics-dimension-repository_nwo | etr/libhttpserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3416891 |
| octolytics-dimension-repository_network_root_nwo | etr/libhttpserver |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width