René's URL Explorer Experiment


Title: A bunch of generalized code cleanup. by bcsgh · Pull Request #322 · etr/libhttpserver · GitHub

Open Graph Title: A bunch of generalized code cleanup. by bcsgh · Pull Request #322 · etr/libhttpserver

X Title: A bunch of generalized code cleanup. by bcsgh · Pull Request #322 · etr/libhttpserver

Description: Mostly proactive bug-avoidance.

Open Graph Description: Mostly proactive bug-avoidance.

X Description: Mostly proactive bug-avoidance.

Opengraph URL: https://github.com/etr/libhttpserver/pull/322

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e8eed37-c165-d4cd-439d-c25ff6f6c87f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9B8:AAACB:1703294:1EE0F94:696EAB39
html-safe-nonce4a47849cec4d4901ea810fb1b7877a1044b4cfe71d6e88a3495bba4331473a7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUI4OkFBQUNCOjE3MDMyOTQ6MUVFMEY5NDo2OTZFQUIzOSIsInZpc2l0b3JfaWQiOiI1NDA0NzAwMTA1ODk1NzUwNDU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb2efced7caa985ec1aa95b419369224ec72c62a1167965f57283ffb892bbcadf
hovercard-subject-tagpull_request:1349667721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/etr/libhttpserver/322/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/519b11926cf0ccf0aa9e3a89602c5f1d5bbcedeec08ca5e9e5f32e1998a9d1cc/etr/libhttpserver/pull/322
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/519b11926cf0ccf0aa9e3a89602c5f1d5bbcedeec08ca5e9e5f32e1998a9d1cc/etr/libhttpserver/pull/322
og:image:altMostly proactive bug-avoidance.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebcsgh
hostnamegithub.com
expected-hostnamegithub.com
Nonefdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7
turbo-cache-controlno-preview
go-importgithub.com/etr/libhttpserver git https://github.com/etr/libhttpserver.git
octolytics-dimension-user_id1201536
octolytics-dimension-user_loginetr
octolytics-dimension-repository_id3416891
octolytics-dimension-repository_nwoetr/libhttpserver
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3416891
octolytics-dimension-repository_network_root_nwoetr/libhttpserver
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release27b23bc056eb973d350fc95afc848757edb9e7a9
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/etr/libhttpserver/pull/322#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F322
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F322
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=etr%2Flibhttpserver
Reloadhttps://github.com/etr/libhttpserver/pull/322
Reloadhttps://github.com/etr/libhttpserver/pull/322
Reloadhttps://github.com/etr/libhttpserver/pull/322
etr https://github.com/etr
libhttpserverhttps://github.com/etr/libhttpserver
Notifications https://github.com/login?return_to=%2Fetr%2Flibhttpserver
Fork 192 https://github.com/login?return_to=%2Fetr%2Flibhttpserver
Star 942 https://github.com/login?return_to=%2Fetr%2Flibhttpserver
Code https://github.com/etr/libhttpserver
Issues 40 https://github.com/etr/libhttpserver/issues
Pull requests 11 https://github.com/etr/libhttpserver/pulls
Actions https://github.com/etr/libhttpserver/actions
Projects 0 https://github.com/etr/libhttpserver/projects
Wiki https://github.com/etr/libhttpserver/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/etr/libhttpserver/security
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
Insights https://github.com/etr/libhttpserver/pulse
Code https://github.com/etr/libhttpserver
Issues https://github.com/etr/libhttpserver/issues
Pull requests https://github.com/etr/libhttpserver/pulls
Actions https://github.com/etr/libhttpserver/actions
Projects https://github.com/etr/libhttpserver/projects
Wiki https://github.com/etr/libhttpserver/wiki
Security https://github.com/etr/libhttpserver/security
Insights https://github.com/etr/libhttpserver/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fetr%2Flibhttpserver%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fetr%2Flibhttpserver%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/etr/libhttpserver/pull/322#issue-comment-box
etrhttps://github.com/etr
etr:masterhttps://github.com/etr/libhttpserver/tree/master
bcsgh:bcsgh/cleanupshttps://github.com/bcsgh/libhttpserver/tree/bcsgh/cleanups
A bunch of generalized code cleanup. https://github.com/etr/libhttpserver/pull/322#top
etrhttps://github.com/etr
etr:masterhttps://github.com/etr/libhttpserver/tree/master
bcsgh:bcsgh/cleanupshttps://github.com/bcsgh/libhttpserver/tree/bcsgh/cleanups
Conversation 4 https://github.com/etr/libhttpserver/pull/322
Commits 6 https://github.com/etr/libhttpserver/pull/322/commits
Checks 0 https://github.com/etr/libhttpserver/pull/322/checks
Files changed https://github.com/etr/libhttpserver/pull/322/files
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
https://github.co/hiddenchars
https://github.com/etr/libhttpserver/pull/{{ revealButtonHref }}
https://github.com/bcsgh
bcsghhttps://github.com/bcsgh
May 14, 2023https://github.com/etr/libhttpserver/pull/322#issue-1708775709
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
bcsghhttps://github.com/bcsgh
May 13, 2023 16:13https://github.com/etr/libhttpserver/pull/322#commits-pushed-336236b
https://github.com/bcsgh
Replace static_cast(-1) with std::numeric_limits::max().https://github.com/etr/libhttpserver/pull/322/commits/336236ba624da08ca1c85f74010264e143c4edc6
336236bhttps://github.com/etr/libhttpserver/pull/322/commits/336236ba624da08ca1c85f74010264e143c4edc6
https://github.com/bcsgh
Move setting of http_request::cache out of the contructors.https://github.com/etr/libhttpserver/pull/322/commits/c66fb87bc9686771d7503f7ac4d4d7034aa6ee9e
c66fb87https://github.com/etr/libhttpserver/pull/322/commits/c66fb87bc9686771d7503f7ac4d4d7034aa6ee9e
https://github.com/bcsgh
Remove all uses of this->https://github.com/etr/libhttpserver/pull/322/commits/fca8049a58c0bbd0d60ca21f255a083b3eeb3898
fca8049https://github.com/etr/libhttpserver/pull/322/commits/fca8049a58c0bbd0d60ca21f255a083b3eeb3898
https://github.com/bcsgh
Cleanup some extra ().https://github.com/etr/libhttpserver/pull/322/commits/ba73d6aef4914aede604e29576415744e7404316
ba73d6ahttps://github.com/etr/libhttpserver/pull/322/commits/ba73d6aef4914aede604e29576415744e7404316
https://github.com/bcsgh
bcsghhttps://github.com/bcsgh
May 14, 2023https://github.com/etr/libhttpserver/pull/322#event-9239372296
https://github.com/etr
etrhttps://github.com/etr
May 14, 2023 https://github.com/etr/libhttpserver/pull/322#pullrequestreview-1425485661
View reviewed changes https://github.com/etr/libhttpserver/pull/322/files/ba73d6aef4914aede604e29576415744e7404316
src/http_request.cpphttps://github.com/etr/libhttpserver/pull/322/files/ba73d6aef4914aede604e29576415744e7404316#diff-da864f88d5123bc11bb11c531ca04c8a108fb53ebdde504bd3e3cda61401e64f
etrhttps://github.com/etr
May 14, 2023https://github.com/etr/libhttpserver/pull/322#discussion_r1193072573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
bcsghhttps://github.com/bcsgh
May 14, 2023https://github.com/etr/libhttpserver/pull/322#discussion_r1193091556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
etrhttps://github.com/etr
May 14, 2023https://github.com/etr/libhttpserver/pull/322#discussion_r1193179249
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
bcsghhttps://github.com/bcsgh
May 14, 2023https://github.com/etr/libhttpserver/pull/322#discussion_r1193212417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
bcsghhttps://github.com/bcsgh
May 14, 2023 13:59https://github.com/etr/libhttpserver/pull/322#commits-pushed-d10fdf2
https://github.com/bcsgh
Use the calling signiture for uri_log as defined by the docs:https://github.com/etr/libhttpserver/pull/322/commits/d10fdf2ea67c518da80f3a424d9f3db6df55c41c
https:/…https://www.gnu.org/software/libmicrohttpd/manual/html_node/microhttpd_002dconst.html#index-logging
d10fdf2https://github.com/etr/libhttpserver/pull/322/commits/d10fdf2ea67c518da80f3a424d9f3db6df55c41c
…/www.gnu.org/software/libmicrohttpd/manual/html_node/microhttpd_002dconst.html#index-logginghttps://www.gnu.org/software/libmicrohttpd/manual/html_node/microhttpd_002dconst.html#index-logging
https://github.com/bcsgh
Revert setters.https://github.com/etr/libhttpserver/pull/322/commits/32298ca96740ecbd1e48c2a7d782429ee541700c
32298cahttps://github.com/etr/libhttpserver/pull/322/commits/32298ca96740ecbd1e48c2a7d782429ee541700c
https://github.com/bcsgh
bcsghhttps://github.com/bcsgh
May 14, 2023 21:47https://github.com/etr/libhttpserver/pull/322#event-9240801836
https://github.com/etr
etrhttps://github.com/etr
57bbb3chttps://github.com/etr/libhttpserver/commit/57bbb3cae89b6b71847604f9b2ed4498ac908aa6
May 21, 2023https://github.com/etr/libhttpserver/pull/322#event-9295388960
https://github.com/bcsgh
bcsghhttps://github.com/bcsgh
May 28, 2023 02:01https://github.com/etr/libhttpserver/pull/322#event-9359670293
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fetr%2Flibhttpserver%2Fpull%2F322
https://github.com/etr
etr https://github.com/etr
https://github.com/etr/libhttpserver/pull/322/files/ba73d6aef4914aede604e29576415744e7404316
Please reload this pagehttps://github.com/etr/libhttpserver/pull/322
https://github.com/bcsgh
https://github.com/etr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.