René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Build fails with CPP0X enabled.","articleBody":"I just attempted to build the library with cpp0x support enabled and I encountered build errors. I have tracked down the issues and have outlined them below.\n\nFirst, in `src/httpserver/webserver.hpp`, in the `#include` section, `\u003cset\u003e` is conditionally included if `CPP0X` support is not enabled (https://github.com/etr/libhttpserver/blob/master/src/httpserver/webserver.hpp#L36-40). This causes errors because `std::set` is used elsewhere throughout the code. This can be fixed by changing:\n\n```\n#ifdef USE_CPP_ZEROX\n#include \u003cunordered_set\u003e\n#else \n#include \u003cset\u003e\n#endif \n```\n\nto\n\n```\n#ifdef USE_CPP_ZEROX\n#include \u003cunordered_set\u003e\n#endif \n#include \u003cset\u003e\n```\n\nNext, when declaring the `bans` and `allowances` variables on https://github.com/etr/libhttpserver/blob/master/src/httpserver/webserver.hpp#L238-244, `std::unordered_set` is used if CPP0X support is enabled, but the type that it stores (`http::ip_representation`) does not have `std::hash` defined for it. In my opinion, unordered set may not be required here as _O(lg n)_ lookup is probably sufficient for the purposes that it serves, and the time gain that you would get with _O(1)_ lookup with unordered set likely doesn't outweigh the space overhead. \n\nNext, in `src/webserver.cpp`, there are quite a few instances where `std::make_pair` is called but the template arguments are provided; they should always be omitted with `make_pair`, and because C++0x is stricter with type conversions, they fail to compile. The offending lines are https://github.com/etr/libhttpserver/blob/master/src/webserver.cpp#L252, https://github.com/etr/libhttpserver/blob/master/src/webserver.cpp#L1417, and https://github.com/etr/libhttpserver/blob/master/src/webserver.cpp#L1428.\n\nLastly, for some reason, when running configure with CPP0X enabled, the --std=c++0x flag is missing from somewhere in the generated Makefile. To fix this I had to run the configure command as follows:\n\n```\nCXXFLAGS=--std=c++11 ../libhttpserver/configure --prefix=/usr --enable-cpp0x\n```\n\nI have no clue how the configure script works so I don't know what would have to be modified to make this work out of the box.\n","author":{"url":"https://github.com/m-renaud","@type":"Person","name":"m-renaud"},"datePublished":"2014-03-06T16:30:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/46/libhttpserver/issues/46"}