René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] Query parameters missing in get_args() result if path arguments are used.","articleBody":"### Prerequisites\r\n\r\n* [X] Put an X between the brackets on this line if you have checked that your issue isn't already filed: https://github.com/search?l=\u0026q=repo%3Aetr%2Flibhttpserver\u0026type=Issues\r\n\r\n### Description\r\n\r\nThe result from calling `http_request::get_args()` will not contain URL query parameters if the resource URL has path parameters. This is due to `webserver::finalize_answer(...)` calling `http_server::set_arg(...)` for each URL path argument, thus rendering `http_request::cache::unescaped_args` non-empty. `http_request::get_args()` will call `http_request::populate_args()`, which will do nothing if `unescaped_args` is non-empty.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Change line `examples/hello_with_get_arg.cpp:26` from\r\n```\r\nreturn std::shared_ptr\u003chttpserver::http_response\u003e(new httpserver::string_response(\"Hello: \" + std::string(req.get_arg(\"name\"))));\r\n```\r\nto\r\n```\r\nreturn std::shared_ptr\u003chttpserver::http_response\u003e(new httpserver::string_response(std::string(req.get_arg(\"greeting\")) + \", \" + std::string(req.get_arg(\"name\"))));\r\n```\r\n2. Change line `examples/hello_with_get_arg.cpp:34` from\r\n```\r\nws.register_resource(\"/hello\", \u0026hwr);\r\n```\r\nto lines\r\n```\r\nhwr.disallow_all();\r\nhwr.set_allowing(\"GET\", true);\r\nws.register_resource(\"/{greeting}\", \u0026hwr);\r\n```\r\n3. Build and start example server `hello_with_get_arg` in a terminal.\r\n4. In a second terminal, run `curl http://localhost:8080/Howdy?name=Bob`\r\n\r\n**Expected behavior:** Server responds with text \"Howdy, Bob\"\r\n\r\n**Actual behavior:** Server responds with \"Howdy, \"\r\n\r\n**Reproduces how often:** 100%\r\n\r\n### Versions\r\n\r\n* OS version `Linux gd 6.8.0-50-generic #51~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov 21 12:03:03 UTC 2 x86_64 x86_64 x86_64 GNU/Linux`\r\n* libhttpserver version 0.19.0, compiled\r\n* libmicrohttpd version 1.0.1, compiled\r\n\r\n### Additional Information\r\nFull example program, modified as specified in steps to reproduce.\r\n```\r\n#include \u003chttpserver.hpp\u003e\r\n\r\nclass hello_world_resource : public httpserver::http_resource {\r\n public:\r\n     std::shared_ptr\u003chttpserver::http_response\u003e render(const httpserver::http_request\u0026 req) {\r\n         return std::shared_ptr\u003chttpserver::http_response\u003e(new httpserver::string_response(std::string(req.get_arg(\"greeting\")) + \", \" + std::string(req.get_arg(\"name\"))));\r\n     }\r\n};\r\n\r\nint main() {\r\n    httpserver::webserver ws = httpserver::create_webserver(8080);\r\n\r\n    hello_world_resource hwr;\r\n    hwr.disallow_all();\r\n    hwr.set_allowing(\"GET\", true);\r\n    ws.register_resource(\"/{greeting}\", \u0026hwr);\r\n    ws.start(true);\r\n\r\n    return 0;\r\n}\r\n```\r\n","author":{"url":"https://github.com/dimitriadis-georgios","@type":"Person","name":"dimitriadis-georgios"},"datePublished":"2025-01-07T16:16:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/342/libhttpserver/issues/342"}