René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] Final keys without values are not processed for POST body","articleBody":"### Prerequisites\r\n\r\n* [x] Put an X between the brackets on this line if you have checked that your issue isn't already filed: https://github.com/search?l=\u0026q=repo%3Aetr%2Flibhttpserver\u0026type=Issues\r\n\r\n### Description\r\n\r\nFor a POST or PUT request with body format `application/x-www-form-urlencoded`, if there are final parameters with `key`, but without `value` these are left unprocessed and not being reported as arguments in the request.\r\n\r\n### Steps to Reproduce\r\n\r\n1 . Compile and launch this little code snippet:\r\n```\r\n#include \u003cnumeric\u003e\r\n#include \u003cstring\u003e\r\n#include \u003cutility\u003e\r\n\r\n#include \"httpserver.hpp\"\r\n\r\nusing std::string;\r\nusing std::pair;\r\n\r\nusing namespace httpserver;\r\n\r\nclass hello_world_resource : public http_resource {\r\npublic:\r\n    const std::shared_ptr\u003chttp_response\u003e render(const http_request\u0026 req) {\r\n        const auto\u0026 args = req.get_args();\r\n        string recv_args = std::accumulate(args.begin(), args.end(), string {},\r\n                [] (string\u0026 res, const pair\u003cstring,string\u003e\u0026 arg) -\u003e string {\r\n                    const string key_val_str { \"\\\"\" + arg.first + \"\\\": \" + \"'\" + arg.second + \"'\" };\r\n\r\n                    if (res.empty()) {\r\n                        res = key_val_str;\r\n                    } else {\r\n                        res = res + \", \" + key_val_str;\r\n                    }\r\n\r\n                    return res;\r\n                }\r\n            );\r\n\r\n        return std::shared_ptr\u003chttp_response\u003e(new string_response(\"Received args: {\" + recv_args + \"}\"));\r\n    }\r\n};\r\n\r\nint main(int argc, char** argv) {\r\n    webserver ws = create_webserver(8080);\r\n\r\n    hello_world_resource hwr;\r\n    ws.register_resource(\"/hello\", \u0026hwr);\r\n    ws.start(true);\r\n    \r\n    return 0;\r\n}\r\n```\r\n\r\n2. Perform the following requests to the registered endpoint.\r\n\r\n* curl --insecure -d \"arg1=\" -H \"Content-Type: application/x-www-form-urlencoded\" -X POST \"http://127.0.0.1:8080/hello\"\r\n* curl --insecure -d \"arg1=\u0026arg2=\" -H \"Content-Type: application/x-www-form-urlencoded\" -X POST \"http://127.0.0.1:8080/hello\"\r\n\r\n**Expected behavior:**\r\n\r\n* Response for first request **should be**: `Received args: {arg1=''}`\r\n* Response for second request **should be**: `Received args: {arg1='', arg2=''}`\r\n\r\n**Actual behavior:**\r\n\r\n* Response for first request **is**: `Received args: {}`\r\n* Response for second request **is**: `Received args: {arg1=''}`\r\n\r\n**Reproduces how often:** 100%\r\n\r\n### Versions\r\n\r\n* OS version: Linux 5.17.5-arch1-2\r\n* libhttpserver version: `master` compiled and 0.18.1 compiled\r\n* libmicrohttpd version: libmicrohttpd-0.9.68 compiled\r\n\r\n### Additional Information\r\n\r\nI'm submitting a PR with the potential fix.\r\n","author":{"url":"https://github.com/JavierJF","@type":"Person","name":"JavierJF"},"datePublished":"2022-05-13T15:23:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/268/libhttpserver/issues/268"}