René's URL Explorer Experiment


Title: Fix UTF-8 handling in input methods by jmmv · Pull Request #175 · endbasic/endbasic · GitHub

Open Graph Title: Fix UTF-8 handling in input methods by jmmv · Pull Request #175 · endbasic/endbasic

X Title: Fix UTF-8 handling in input methods by jmmv · Pull Request #175 · endbasic/endbasic

Description: This is a the same as #162 from @zenria after resolving conflicts, reordering and squashing some commits, and ensuring the web interface works. I've tried to keep the original sequence of commits as much as possible. The original PR description reads: Here is a summary of what has been done: Use a dedicated struct to manipulate string (LineBuffer) to avoid splitting inside UTF-8 code points. Console::write does not take bytes anymore but a string slice to ensure proper UTF-8 data is sent to the console. sdl & web implementation of write_wrapped do not manipulate bytes anymore but are using LineBuffer instead. This ensures correct line length & line splitting while wrapping. sdl console rendering use the render method instead of the render_latin1 method to properly render UTF-8 strings. Fixes #161.

Open Graph Description: This is a the same as #162 from @zenria after resolving conflicts, reordering and squashing some commits, and ensuring the web interface works. I've tried to keep the original sequence of commi...

X Description: This is a the same as #162 from @zenria after resolving conflicts, reordering and squashing some commits, and ensuring the web interface works. I've tried to keep the original sequence of c...

Opengraph URL: https://github.com/endbasic/endbasic/pull/175

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f517f2ee-5c1c-54a8-9351-d4104ede5f90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADAE:143213:71B0E0:A3508E:6A63778E
html-safe-noncead955b1cf2e55e6565fd2be59c13da678f7e87a8cb955fa4c1ccf9e8ce25e05a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREFFOjE0MzIxMzo3MUIwRTA6QTM1MDhFOjZBNjM3NzhFIiwidmlzaXRvcl9pZCI6IjUyODcyNzMyNDMzMTc4NjAyMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf26edab0e9f4ab4b781cbd5a42a487bbd1397b7dd01b35cb78aba4710daddbf7
hovercard-subject-tagpull_request:952008028
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/endbasic/endbasic/pull/175/files
twitter:imagehttps://avatars.githubusercontent.com/u/879272?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/879272?s=400&v=4
og:image:altThis is a the same as #162 from @zenria after resolving conflicts, reordering and squashing some commits, and ensuring the web interface works. I've tried to keep the original sequence of commi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None15e78334bb345f3864e70c5a376ed0383374123629b9e3022398d9431f6cd8bf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/endbasic/endbasic git https://github.com/endbasic/endbasic.git
octolytics-dimension-user_id75130732
octolytics-dimension-user_loginendbasic
octolytics-dimension-repository_id253313291
octolytics-dimension-repository_nwoendbasic/endbasic
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id253313291
octolytics-dimension-repository_network_root_nwoendbasic/endbasic
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51da2d8d0a841a1393b806a6559fa9ad757e1666
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/endbasic/endbasic/pull/175/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fendbasic%2Fendbasic%2Fpull%2F175%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fendbasic%2Fendbasic%2Fpull%2F175%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=endbasic%2Fendbasic
Reloadhttps://github.com/endbasic/endbasic/pull/175/files
Reloadhttps://github.com/endbasic/endbasic/pull/175/files
Reloadhttps://github.com/endbasic/endbasic/pull/175/files
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
endbasic https://github.com/endbasic
endbasichttps://github.com/endbasic/endbasic
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
Notifications https://github.com/login?return_to=%2Fendbasic%2Fendbasic
Fork 21 https://github.com/login?return_to=%2Fendbasic%2Fendbasic
Star 383 https://github.com/login?return_to=%2Fendbasic%2Fendbasic
Code https://github.com/endbasic/endbasic
Issues 26 https://github.com/endbasic/endbasic/issues
Pull requests 4 https://github.com/endbasic/endbasic/pulls
Actions https://github.com/endbasic/endbasic/actions
Projects https://github.com/endbasic/endbasic/projects
Security and quality 0 https://github.com/endbasic/endbasic/security
Insights https://github.com/endbasic/endbasic/pulse
Code https://github.com/endbasic/endbasic
Issues https://github.com/endbasic/endbasic/issues
Pull requests https://github.com/endbasic/endbasic/pulls
Actions https://github.com/endbasic/endbasic/actions
Projects https://github.com/endbasic/endbasic/projects
Security and quality https://github.com/endbasic/endbasic/security
Insights https://github.com/endbasic/endbasic/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fendbasic%2Fendbasic%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fendbasic%2Fendbasic%2Fissues%2Fnew%2Fchoose
jmmvhttps://github.com/jmmv
masterhttps://github.com/endbasic/endbasic/tree/master
fix-utf8https://github.com/endbasic/endbasic/tree/fix-utf8
Conversation 1 https://github.com/endbasic/endbasic/pull/175
Commits 5 https://github.com/endbasic/endbasic/pull/175/commits
Checks 0 https://github.com/endbasic/endbasic/pull/175/checks
Files changed https://github.com/endbasic/endbasic/pull/175/files
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
Fix UTF-8 handling in input methods https://github.com/endbasic/endbasic/pull/175/files#top
Show all changes 5 commits https://github.com/endbasic/endbasic/pull/175/files
6141301 Fix read_line_interactive to accept UTF-8 input zenria Apr 13, 2022 https://github.com/endbasic/endbasic/pull/175/commits/614130192201804452a454def103ce88455ae929
0b453c4 Fix editor to handle UTF-8 input zenria Apr 16, 2022 https://github.com/endbasic/endbasic/pull/175/commits/0b453c4ad02962f06f30efdd5ada4bf720f18c5a
38d90fb Abstract string editing in a new LineBuffer struct zenria Apr 19, 2022 https://github.com/endbasic/endbasic/pull/175/commits/38d90fbfd9286a0df74cc6480f857b636fb1e00d
27e42f1 Make Console::write take a string instead of [u8] zenria Apr 19, 2022 https://github.com/endbasic/endbasic/pull/175/commits/27e42f14c052ab78ce7c67c6cb0c586c09ee7ecd
4035691 Test that UTF-8 load/save works in the cloud jmmv Jun 1, 2022 https://github.com/endbasic/endbasic/pull/175/commits/4035691233267e3a4d478bb8e2a5c33ec078f7a9
Clear filters https://github.com/endbasic/endbasic/pull/175/files
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
NEWS.md https://github.com/endbasic/endbasic/pull/175/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea
cloud.rs https://github.com/endbasic/endbasic/pull/175/files#diff-982021aab8e633f976facb69e98692d15a6f2ded21218581728f254cc213ba0c
cmds.rs https://github.com/endbasic/endbasic/pull/175/files#diff-23499013d53359d48fcd9d7de90b60d64c22467258e83a54ac8afc936819a122
editor.rs https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
console.rs https://github.com/endbasic/endbasic/pull/175/files#diff-0b211b2830379f8d24bddf0d1eb730cbda3340e478792276a5198b7fdc8b3645
linebuffer.rs https://github.com/endbasic/endbasic/pull/175/files#diff-47fe836dc9eeea998b592099b85727d3b55e0784025ccd40ec89762065b1680a
mod.rs https://github.com/endbasic/endbasic/pull/175/files#diff-32a930f8e3d232a84b1a77cc834a62db4dc8b923ee19041d3d7b576dfe8be25c
readline.rs https://github.com/endbasic/endbasic/pull/175/files#diff-a7b50799a0420f6ba51ec9d9ac9d476041815f9fa1af297af983425561b467cc
trivial.rs https://github.com/endbasic/endbasic/pull/175/files#diff-59f3ca2a3659575a45b5fd1b3f7fa43898b000fd4d3ac8db3563e4dfab77a180
testutils.rs https://github.com/endbasic/endbasic/pull/175/files#diff-318b3e086da445bde9f556ac24a27edae865956e7cc8c490038a13c360af56ab
lib.rs https://github.com/endbasic/endbasic/pull/175/files#diff-a22c31d10f0c0ea9c287f980dc55e5f4ee9637c4ec9e37c513dac07d23ce287d
canvas.rs https://github.com/endbasic/endbasic/pull/175/files#diff-8b997d4a1db8eb2580180bd21792cbdbc51a7b8104def2dd5447d9565343aa66
NEWS.mdhttps://github.com/endbasic/endbasic/pull/175/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea
View file https://github.com/endbasic/endbasic/blob/4035691233267e3a4d478bb8e2a5c33ec078f7a9/NEWS.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/endbasic/endbasic/pull/175/{{ revealButtonHref }}
https://github.com/endbasic/endbasic/pull/175/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea
https://github.com/endbasic/endbasic/pull/175/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea
client/src/cloud.rshttps://github.com/endbasic/endbasic/pull/175/files#diff-982021aab8e633f976facb69e98692d15a6f2ded21218581728f254cc213ba0c
View file https://github.com/endbasic/endbasic/blob/4035691233267e3a4d478bb8e2a5c33ec078f7a9/client/src/cloud.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/endbasic/endbasic/pull/175/{{ revealButtonHref }}
https://github.com/endbasic/endbasic/pull/175/files#diff-982021aab8e633f976facb69e98692d15a6f2ded21218581728f254cc213ba0c
https://github.com/endbasic/endbasic/pull/175/files#diff-982021aab8e633f976facb69e98692d15a6f2ded21218581728f254cc213ba0c
client/src/cmds.rshttps://github.com/endbasic/endbasic/pull/175/files#diff-23499013d53359d48fcd9d7de90b60d64c22467258e83a54ac8afc936819a122
View file https://github.com/endbasic/endbasic/blob/4035691233267e3a4d478bb8e2a5c33ec078f7a9/client/src/cmds.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/endbasic/endbasic/pull/175/{{ revealButtonHref }}
https://github.com/endbasic/endbasic/pull/175/files#diff-23499013d53359d48fcd9d7de90b60d64c22467258e83a54ac8afc936819a122
https://github.com/endbasic/endbasic/pull/175/files#diff-23499013d53359d48fcd9d7de90b60d64c22467258e83a54ac8afc936819a122
repl/src/editor.rshttps://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
View file https://github.com/endbasic/endbasic/blob/4035691233267e3a4d478bb8e2a5c33ec078f7a9/repl/src/editor.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/endbasic/endbasic/pull/175/{{ revealButtonHref }}
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
https://github.com/endbasic/endbasic/pull/175/files#diff-83af46516a9e2d38f58110d4886f7e4ede8a5e63127f2f3cb0b1a282211e7f03
Please reload this pagehttps://github.com/endbasic/endbasic/pull/175/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.