Title: Fix handling of keys that are browser shortcuts by jmmv · Pull Request #147 · endbasic/endbasic · GitHub
Open Graph Title: Fix handling of keys that are browser shortcuts by jmmv · Pull Request #147 · endbasic/endbasic
X Title: Fix handling of keys that are browser shortcuts by jmmv · Pull Request #147 · endbasic/endbasic
Description: There are a bunch of key presses that should be recognized by EndBASIC but that are also recognized by the browser. Some include the Tab key, the arrow keys (when "caret browsing" is enabled), and the slash key in Firefox. Before, pressing any of these keys would cause the browser to also perform their default action, which meant that the REPL would misbehave by losing focus or triggering links. With this change, we prevent the events from propagating to the browser once we have handled them so that this problem doesn't surface. This change is inspired by the fix submitted by @Protowalker in #140. Fixes #136.
Open Graph Description: There are a bunch of key presses that should be recognized by EndBASIC but that are also recognized by the browser. Some include the Tab key, the arrow keys (when "caret browsing" is ena...
X Description: There are a bunch of key presses that should be recognized by EndBASIC but that are also recognized by the browser. Some include the Tab key, the arrow keys (when "caret browsing"...
Opengraph URL: https://github.com/endbasic/endbasic/pull/147
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:51f2607b-1f3f-0361-70bf-943473279f1e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B44E:1BB886:22EB0B:32B9A4:6A636678 |
| html-safe-nonce | e46a6d663f39a1c6a08c3b7f8493c3ff2a576c462a824338eb3c94a4f7f7abfb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDRFOjFCQjg4NjoyMkVCMEI6MzJCOUE0OjZBNjM2Njc4IiwidmlzaXRvcl9pZCI6IjY5NzAwNzUwNDY1OTk2ODE2NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f44410ad1169105d97290a056a1d888f77d3b2cb0ebaca9e13f5a667fb79a239 |
| hovercard-subject-tag | pull_request:797486288 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/endbasic/endbasic/pull/147/files |
| twitter:image | https://avatars.githubusercontent.com/u/879272?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/879272?s=400&v=4 |
| og:image:alt | There are a bunch of key presses that should be recognized by EndBASIC but that are also recognized by the browser. Some include the Tab key, the arrow keys (when "caret browsing" is ena... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 669d3fcd704a169521d2b6431762f95a6878a9e8ccaf0fd5f2d0802fc5b971f9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/endbasic/endbasic git https://github.com/endbasic/endbasic.git |
| octolytics-dimension-user_id | 75130732 |
| octolytics-dimension-user_login | endbasic |
| octolytics-dimension-repository_id | 253313291 |
| octolytics-dimension-repository_nwo | endbasic/endbasic |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 253313291 |
| octolytics-dimension-repository_network_root_nwo | endbasic/endbasic |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 20da292f132ff51328be50073854259f417052c1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width