René's URL Explorer Experiment


Title: Fix connection leak when transaction commit/rollback raise an exception by masipcat · Pull Request #498 · encode/databases · GitHub

Open Graph Title: Fix connection leak when transaction commit/rollback raise an exception by masipcat · Pull Request #498 · encode/databases

X Title: Fix connection leak when transaction commit/rollback raise an exception by masipcat · Pull Request #498 · encode/databases

Description: Async database support for Python. 🗄. Contribute to encode/databases development by creating an account on GitHub.

Open Graph Description: This fixes the following case: from databases import Database import asyncio async def method(): database = Database("postgresql://...") await database.connect() try: ...

X Description: This fixes the following case: from databases import Database import asyncio async def method(): database = Database("postgresql://...") await database.connect() t...

Opengraph URL: https://github.com/encode/databases/pull/498

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:646c8108-cbac-c91b-b8d0-1249e63487c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4EC:25BA60:189C09F:210A307:6A535FD8
html-safe-nonce6ffd78f4e83a47beddeaa5f48fbfe1b61c9039b936622714df3ba7f858c9fb29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEVDOjI1QkE2MDoxODlDMDlGOjIxMEEzMDc6NkE1MzVGRDgiLCJ2aXNpdG9yX2lkIjoiNDg1MDYxMDI4Nzc2ODk4NTU2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf2856d994ab9cdd05bbeffdd508549f5181e14a6179d575a5d824c6b9f2bc7e2
hovercard-subject-tagpull_request:999539934
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/encode/databases/498/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/904bd0387185a301106fbaaee18b7da77da660788457359a516fdcdafefd3eab/encode/databases/pull/498
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/904bd0387185a301106fbaaee18b7da77da660788457359a516fdcdafefd3eab/encode/databases/pull/498
og:image:altThis fixes the following case: from databases import Database import asyncio async def method(): database = Database("postgresql://...") await database.connect() try: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemasipcat
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/encode/databases git https://github.com/encode/databases.git
octolytics-dimension-user_id19159390
octolytics-dimension-user_loginencode
octolytics-dimension-repository_id168684254
octolytics-dimension-repository_nwoencode/databases
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id168684254
octolytics-dimension-repository_network_root_nwoencode/databases
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/encode/databases/pull/498#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F498
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F498
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=encode%2Fdatabases
Reloadhttps://github.com/encode/databases/pull/498
Reloadhttps://github.com/encode/databases/pull/498
Reloadhttps://github.com/encode/databases/pull/498
Please reload this pagehttps://github.com/encode/databases/pull/498
encode https://github.com/encode
databaseshttps://github.com/encode/databases
Notifications https://github.com/login?return_to=%2Fencode%2Fdatabases
Fork 262 https://github.com/login?return_to=%2Fencode%2Fdatabases
Star 4k https://github.com/login?return_to=%2Fencode%2Fdatabases
Code https://github.com/encode/databases
Issues 115 https://github.com/encode/databases/issues
Pull requests 16 https://github.com/encode/databases/pulls
Discussions https://github.com/encode/databases/discussions
Actions https://github.com/encode/databases/actions
Security and quality 0 https://github.com/encode/databases/security
Insights https://github.com/encode/databases/pulse
Code https://github.com/encode/databases
Issues https://github.com/encode/databases/issues
Pull requests https://github.com/encode/databases/pulls
Discussions https://github.com/encode/databases/discussions
Actions https://github.com/encode/databases/actions
Security and quality https://github.com/encode/databases/security
Insights https://github.com/encode/databases/pulse
masipcathttps://github.com/masipcat
encode:masterhttps://github.com/encode/databases/tree/master
vinissimus:0.4.3-vinissimus-hotfixhttps://github.com/vinissimus/databases/tree/0.4.3-vinissimus-hotfix
Conversationhttps://github.com/encode/databases/pull/498
Commits6 (6)https://github.com/encode/databases/pull/498/commits
Checkshttps://github.com/encode/databases/pull/498/checks
Files changedhttps://github.com/encode/databases/pull/498/files
Fix connection leak when transaction commit/rollback raise an exceptionhttps://github.com/encode/databases/pull/498#top
masipcathttps://github.com/masipcat
encode:masterhttps://github.com/encode/databases/tree/master
vinissimus:0.4.3-vinissimus-hotfixhttps://github.com/vinissimus/databases/tree/0.4.3-vinissimus-hotfix
https://github.com/masipcat
masipcathttps://github.com/masipcat
Jul 18, 2022https://github.com/encode/databases/pull/498#issue-1308121196
Please reload this pagehttps://github.com/encode/databases/pull/498
Please reload this pagehttps://github.com/encode/databases/pull/498
masipcathttps://github.com/masipcat
July 18, 2022 13:16https://github.com/encode/databases/pull/498#commits-pushed-0d3c5ae
https://github.com/masipcat
Fix connection leak when transaction commit/rollback raise an exceptionhttps://github.com/encode/databases/pull/498/commits/0d3c5ae445c9576a6e208e7efd80a8c5c73be269
0d3c5aehttps://github.com/encode/databases/pull/498/commits/0d3c5ae445c9576a6e208e7efd80a8c5c73be269
https://github.com/masipcat
Merge branch 'master' into 0.4.3-vinissimus-hotfixhttps://github.com/encode/databases/pull/498/commits/8d05804a5320b059c4fb3b5366e1a83406a7af84
8d05804https://github.com/encode/databases/pull/498/commits/8d05804a5320b059c4fb3b5366e1a83406a7af84
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
Jul 28, 2022https://github.com/encode/databases/pull/498#issuecomment-1198438758
Please reload this pagehttps://github.com/encode/databases/pull/498
https://github.com/masipcat
masipcathttps://github.com/masipcat
Jul 29, 2022https://github.com/encode/databases/pull/498#issuecomment-1199066301
Please reload this pagehttps://github.com/encode/databases/pull/498
masipcathttps://github.com/masipcat
July 29, 2022 12:12https://github.com/encode/databases/pull/498#commits-pushed-8ff26fd
https://github.com/masipcat
Add test to check transaction doesn't leak on errorhttps://github.com/encode/databases/pull/498/commits/8ff26fd6fe223445374e96a917e0b7b8dd3e711c
8ff26fdhttps://github.com/encode/databases/pull/498/commits/8ff26fd6fe223445374e96a917e0b7b8dd3e711c
https://github.com/masipcat
Merge branch 'master' into 0.4.3-vinissimus-hotfixhttps://github.com/encode/databases/pull/498/commits/e783a65bbe6b4f89e18395338b712c09abc26cea
e783a65https://github.com/encode/databases/pull/498/commits/e783a65bbe6b4f89e18395338b712c09abc26cea
https://github.com/masipcat
Removed @mysql_versionshttps://github.com/encode/databases/pull/498/commits/1a07fa4fe2840703a23345fc29b117b3da84e019
1a07fa4https://github.com/encode/databases/pull/498/commits/1a07fa4fe2840703a23345fc29b117b3da84e019
https://github.com/masipcat
masipcathttps://github.com/masipcat
Jul 29, 2022 https://github.com/encode/databases/pull/498#pullrequestreview-1055325173
View reviewed changes https://github.com/encode/databases/pull/498/files/1a07fa4fe2840703a23345fc29b117b3da84e019
tests/test_databases.pyhttps://github.com/encode/databases/pull/498/files/1a07fa4fe2840703a23345fc29b117b3da84e019#diff-71fe007c958acd11b69e1011aaaa2116a3a7f62a2e5ef8ec3743a8d191dcec88
masipcathttps://github.com/masipcat
Jul 29, 2022https://github.com/encode/databases/pull/498#discussion_r933092105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aminalaeehttps://github.com/aminalaee
Please reload this pagehttps://github.com/encode/databases/pull/498
aminalaeehttps://github.com/aminalaee
Jul 29, 2022https://github.com/encode/databases/pull/498#discussion_r933141067
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
databases/tests/test_databases.pyhttps://github.com/encode/databases/blob/6a52a4a37e69fcb25f309ff5d38e4d43eb80b32c/tests/test_databases.py#L482
6a52a4ahttps://github.com/encode/databases/commit/6a52a4a37e69fcb25f309ff5d38e4d43eb80b32c
Please reload this pagehttps://github.com/encode/databases/pull/498
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
Jul 29, 2022 https://github.com/encode/databases/pull/498#pullrequestreview-1055429768
View reviewed changes https://github.com/encode/databases/pull/498/files/8ff26fd6fe223445374e96a917e0b7b8dd3e711c
tests/test_databases.pyhttps://github.com/encode/databases/pull/498/files/8d05804a5320b059c4fb3b5366e1a83406a7af84..8ff26fd6fe223445374e96a917e0b7b8dd3e711c#diff-71fe007c958acd11b69e1011aaaa2116a3a7f62a2e5ef8ec3743a8d191dcec88
Please reload this pagehttps://github.com/encode/databases/pull/498
https://github.com/masipcat
Merge branch 'master' into 0.4.3-vinissimus-hotfixhttps://github.com/encode/databases/pull/498/commits/93a6d695f1fb8254b1e5a7cc51b497de645ceabd
93a6d69https://github.com/encode/databases/pull/498/commits/93a6d695f1fb8254b1e5a7cc51b497de645ceabd
https://github.com/ODD2
ODD2https://github.com/ODD2
Apr 17, 2023 https://github.com/encode/databases/pull/498#ref-issue-1630215984
Unable to reconnect database backend after nested transaction exception. #538 https://github.com/encode/databases/issues/538
https://github.co/hiddenchars
https://github.com/encode/databases/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F498
https://github.com/aminalaee
aminalaee https://github.com/aminalaee
https://github.com/encode/databases/pull/498/files/8ff26fd6fe223445374e96a917e0b7b8dd3e711c
Please reload this pagehttps://github.com/encode/databases/pull/498
https://github.com/masipcat
https://github.com/aminalaee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.