| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e21b645d-1bad-9f5e-bb6b-d2c7efa8c5e5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C424:323BC4:12C64B4:18F177F:6A5344B7 |
| html-safe-nonce | c9e2bb8512c03cd0800738cd1459714d977012eaee662bda11ad5f995543dc71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDI0OjMyM0JDNDoxMkM2NEI0OjE4RjE3N0Y6NkE1MzQ0QjciLCJ2aXNpdG9yX2lkIjoiMjczNTA5NTU0MTY0MTk4NzI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 42efe5e4329e10d0b388133ac6236ed76c44268865abdbe6dce4b93208aeed58 |
| hovercard-subject-tag | pull_request:730704521 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/encode/databases/385/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/05b018ce8a4ce335cfd8a6e2eede65c007b7156d79b61a608b467fe6e31a37e3/encode/databases/pull/385 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/05b018ce8a4ce335cfd8a6e2eede65c007b7156d79b61a608b467fe6e31a37e3/encode/databases/pull/385 |
| og:image:alt | This adds a unittest for #283. It does require the library asyncmock as AsyncMock isn't available in python 3.6 or 3.7 yet. If testing on 3.6 and 3.6 is not a requirement, we can use unittest... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | taybin |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/encode/databases git https://github.com/encode/databases.git |
| octolytics-dimension-user_id | 19159390 |
| octolytics-dimension-user_login | encode |
| octolytics-dimension-repository_id | 168684254 |
| octolytics-dimension-repository_nwo | encode/databases |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 168684254 |
| octolytics-dimension-repository_network_root_nwo | encode/databases |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/encode/databases/pull/385#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F385 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F385 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=encode%2Fdatabases |
| Reload | https://github.com/encode/databases/pull/385 |
| Reload | https://github.com/encode/databases/pull/385 |
| Reload | https://github.com/encode/databases/pull/385 |
| Please reload this page | https://github.com/encode/databases/pull/385 |
|
encode
| https://github.com/encode |
| databases | https://github.com/encode/databases |
|
Notifications
| https://github.com/login?return_to=%2Fencode%2Fdatabases |
|
Fork
262
| https://github.com/login?return_to=%2Fencode%2Fdatabases |
|
Star
4k
| https://github.com/login?return_to=%2Fencode%2Fdatabases |
|
Code
| https://github.com/encode/databases |
|
Issues
115
| https://github.com/encode/databases/issues |
|
Pull requests
16
| https://github.com/encode/databases/pulls |
|
Discussions
| https://github.com/encode/databases/discussions |
|
Actions
| https://github.com/encode/databases/actions |
|
Security and quality
0
| https://github.com/encode/databases/security |
|
Insights
| https://github.com/encode/databases/pulse |
|
Code
| https://github.com/encode/databases |
|
Issues
| https://github.com/encode/databases/issues |
|
Pull requests
| https://github.com/encode/databases/pulls |
|
Discussions
| https://github.com/encode/databases/discussions |
|
Actions
| https://github.com/encode/databases/actions |
|
Security and quality
| https://github.com/encode/databases/security |
|
Insights
| https://github.com/encode/databases/pulse |
| aminalaee | https://github.com/aminalaee |
| encode:master | https://github.com/encode/databases/tree/master |
| Conversation | https://github.com/encode/databases/pull/385 |
| Commits6 (6) | https://github.com/encode/databases/pull/385/commits |
| Checks | https://github.com/encode/databases/pull/385/checks |
| Files changed | https://github.com/encode/databases/pull/385/files |
| Failed connection counter reset | https://github.com/encode/databases/pull/385#top |
| aminalaee | https://github.com/aminalaee |
| encode:master | https://github.com/encode/databases/tree/master |
|
| https://github.com/taybin |
| taybin | https://github.com/taybin |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issue-992361328 |
| #283 | https://github.com/encode/databases/pull/283 |
| @aminalaee | https://github.com/aminalaee |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| qweryty | https://github.com/qweryty |
| September 9, 2021 10:45 | https://github.com/encode/databases/pull/385#commits-pushed-dc87d14 |
|
| https://github.com/qweryty |
| Fixed counter on failed connection | https://github.com/encode/databases/pull/385/commits/dc87d142b398e83aa7ce0385b1fa4c3dbd12f957 |
| dc87d14 | https://github.com/encode/databases/pull/385/commits/dc87d142b398e83aa7ce0385b1fa4c3dbd12f957 |
| add automated test of semaphore rollback on exception. Uses asyncmock | https://github.com/encode/databases/pull/385/commits/c18e3def5dcd4354de1e63198e2a42fa9b3a0cc6 |
| c18e3de | https://github.com/encode/databases/pull/385/commits/c18e3def5dcd4354de1e63198e2a42fa9b3a0cc6 |
| https://github.com/taybin |
| taybin | https://github.com/taybin |
|
Sep 9, 2021
| https://github.com/encode/databases/pull/385#ref-pullrequest-796925539 |
|
Fixed counter on failed connection
#283
| https://github.com/encode/databases/pull/283 |
| September 9, 2021 11:40 | https://github.com/encode/databases/pull/385#commits-pushed-b4f16e1 |
| use patch.object for better cleanup | https://github.com/encode/databases/pull/385/commits/b4f16e14c40821a4a0a8980f0f1528c02d3eeadf |
| b4f16e1 | https://github.com/encode/databases/pull/385/commits/b4f16e14c40821a4a0a8980f0f1528c02d3eeadf |
| use select avoid throwing off counts for other tests | https://github.com/encode/databases/pull/385/commits/3fbeaea4e5d1fbf9cc409ace886d8e0163741d63 |
| 3fbeaea | https://github.com/encode/databases/pull/385/commits/3fbeaea4e5d1fbf9cc409ace886d8e0163741d63 |
| https://github.com/taybin |
| taybin | https://github.com/taybin |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#event-5279467860 |
| https://github.com/taybin |
| taybin | https://github.com/taybin |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issuecomment-916218848 |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| https://github.com/aminalaee |
| aminalaee | https://github.com/aminalaee |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issuecomment-916221298 |
| @taybin | https://github.com/taybin |
| credit | https://stackoverflow.com/questions/32480108/mocking-async-call-in-python-3-5 |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| further simplification since we don't need the transaction anymore | https://github.com/encode/databases/pull/385/commits/8ab1cc802bac90ec6604a6b527495b033b862ea4 |
| 8ab1cc8 | https://github.com/encode/databases/pull/385/commits/8ab1cc802bac90ec6604a6b527495b033b862ea4 |
| https://github.com/aminalaee |
| aminalaee | https://github.com/aminalaee |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issuecomment-916223790 |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| @taybin | https://github.com/taybin |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| remove asyncmock dep. Use non-generic exception for test | https://github.com/encode/databases/pull/385/commits/b7053e5095db453bbc0edb02acd6b78c7169d94f |
| b7053e5 | https://github.com/encode/databases/pull/385/commits/b7053e5095db453bbc0edb02acd6b78c7169d94f |
| https://github.com/taybin |
| taybin | https://github.com/taybin |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issuecomment-916280381 |
| @aminalaee | https://github.com/aminalaee |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| https://github.com/aminalaee |
| aminalaee | https://github.com/aminalaee |
| Sep 9, 2021 | https://github.com/encode/databases/pull/385#issuecomment-916294634 |
| @taybin | https://github.com/taybin |
| Please reload this page | https://github.com/encode/databases/pull/385 |
| https://github.com/aminalaee |
| aminalaee | https://github.com/aminalaee |
|
Sep 10, 2021
| https://github.com/encode/databases/pull/385#pullrequestreview-751080815 |
|
View reviewed changes
| https://github.com/encode/databases/pull/385/files/b7053e5095db453bbc0edb02acd6b78c7169d94f |
| https://github.com/aminalaee |
| aminalaee | https://github.com/aminalaee |
| 6fcb168 | https://github.com/encode/databases/commit/6fcb16823c32dbf492991f26562a3ca6884dfbef |
| Sep 10, 2021 | https://github.com/encode/databases/pull/385#event-5282599528 |
| https://github.com/taybin |
| taybin | https://github.com/taybin |
| September 10, 2021 13:42 | https://github.com/encode/databases/pull/385#event-5284570923 |
| aminalaee | https://github.com/aminalaee |
|
Sep 11, 2021
| https://github.com/encode/databases/pull/385#ref-commit-339e106 |
|
| https://github.com/aminalaee |
| swtiching to TEST_DATABASE_URL | https://github.com/encode/databases/commit/339e10692f0a244da90de1717a4c21e10369099d |
| 339e106 | https://github.com/encode/databases/commit/339e10692f0a244da90de1717a4c21e10369099d |
| #211 | https://github.com/encode/databases/pull/211 |
| #385 | https://github.com/encode/databases/pull/385 |
| #386 | https://github.com/encode/databases/pull/386 |
| https://github.co/hiddenchars |
| https://github.com/encode/databases/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fencode%2Fdatabases%2Fpull%2F385 |
|
| https://github.com/aminalaee |
|
aminalaee
| https://github.com/aminalaee |
|
| https://github.com/encode/databases/pull/385/files/b7053e5095db453bbc0edb02acd6b78c7169d94f |
| Please reload this page | https://github.com/encode/databases/pull/385 |
|
| https://github.com/taybin |
|
| https://github.com/aminalaee |
|
| https://github.com/qweryty |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |