| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3503c41a-e02d-3335-6adf-75d6485eec65 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 930A:2BA6B2:2586FB6:364B525:6A566CBE |
| html-safe-nonce | 84a6cd73cd3d12a28b1c1e3630865791dfcbb4dbb0fcec4b959b77931a51ae91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzBBOjJCQTZCMjoyNTg2RkI2OjM2NEI1MjU6NkE1NjZDQkUiLCJ2aXNpdG9yX2lkIjoiNjg2NTg2MjMxMjg0MzE4MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ddd9d60ab87b5b6e188deb08cfc2682761063f712097a68c308b9b28f016e54c |
| hovercard-subject-tag | pull_request:296102041 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/electron/node/110/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f441137a61b4840ccbdc6b543ddc7eb87bdeb3b8fceb93ceb0f3f91b1d3c5ef5/electron/node/pull/110 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f441137a61b4840ccbdc6b543ddc7eb87bdeb3b8fceb93ceb0f3f91b1d3c5ef5/electron/node/pull/110 |
| og:image:alt | This PR removes our array buffer allocator patch for 10.11.0 branch and replace it with official version from nodejs/node#26207 . The main reason being the patch isn't audited with every node v... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | deepak1556 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1bfcd903bf3318822b10b18a6332fac40d3a21f7d94456dca766ab8fa7328068 |
| turbo-cache-control | no-cache |
| go-import | github.com/electron/node git https://github.com/electron/node.git |
| octolytics-dimension-user_id | 13409222 |
| octolytics-dimension-user_login | electron |
| octolytics-dimension-repository_id | 8767214 |
| octolytics-dimension-repository_nwo | electron/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8767214 |
| octolytics-dimension-repository_network_root_nwo | electron/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 37f446b78ad53e6f593aa1a4243b87c76a3428ab |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/electron/node/pull/110#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=electron%2Fnode |
| Reload | https://github.com/electron/node/pull/110 |
| Reload | https://github.com/electron/node/pull/110 |
| Reload | https://github.com/electron/node/pull/110 |
| Please reload this page | https://github.com/electron/node/pull/110 |
|
electron
| https://github.com/electron |
| node | https://github.com/electron/node |
|
Notifications
| https://github.com/login?return_to=%2Felectron%2Fnode |
|
Fork
127
| https://github.com/login?return_to=%2Felectron%2Fnode |
|
Star
240
| https://github.com/login?return_to=%2Felectron%2Fnode |
|
Code
| https://github.com/electron/node |
|
Issues
10
| https://github.com/electron/node/issues |
|
Pull requests
3
| https://github.com/electron/node/pulls |
|
Actions
| https://github.com/electron/node/actions |
|
Projects
| https://github.com/electron/node/projects |
|
Security and quality
0
| https://github.com/electron/node/security |
|
Insights
| https://github.com/electron/node/pulse |
|
Code
| https://github.com/electron/node |
|
Issues
| https://github.com/electron/node/issues |
|
Pull requests
| https://github.com/electron/node/pulls |
|
Actions
| https://github.com/electron/node/actions |
|
Projects
| https://github.com/electron/node/projects |
|
Security and quality
| https://github.com/electron/node/security |
|
Insights
| https://github.com/electron/node/pulse |
| deepak1556 | https://github.com/deepak1556 |
| electron-node-v10.11.0-V8-6.9 | https://github.com/electron/node/tree/electron-node-v10.11.0-V8-6.9 |
| array_buffer_backport_10_11_x | https://github.com/electron/node/tree/array_buffer_backport_10_11_x |
| Conversation | https://github.com/electron/node/pull/110 |
| Commits12 (12) | https://github.com/electron/node/pull/110/commits |
| Checks | https://github.com/electron/node/pull/110/checks |
| Files changed | https://github.com/electron/node/pull/110/files |
| fix: remove array buffer allocator patch (electron-4.x) | https://github.com/electron/node/pull/110#top |
| deepak1556 | https://github.com/deepak1556 |
| electron-node-v10.11.0-V8-6.9 | https://github.com/electron/node/tree/electron-node-v10.11.0-V8-6.9 |
| array_buffer_backport_10_11_x | https://github.com/electron/node/tree/array_buffer_backport_10_11_x |
|
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| Jul 10, 2019 | https://github.com/electron/node/pull/110#issue-466220559 |
| Please reload this page | https://github.com/electron/node/pull/110 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
| https://github.com/electron/electron/search?q=set+a+breakpoint+in+malloc_error_break+to+debug&type=Issues | https://github.com/electron/electron/search?q=set+a+breakpoint+in+malloc_error_break+to+debug&type=Issues |
| microsoft/vscode#76197 | https://github.com/microsoft/vscode/issues/76197 |
| electron/electron#19158 | https://github.com/electron/electron/pull/19158 |
| Please reload this page | https://github.com/electron/node/pull/110 |
| deepak1556 | https://github.com/deepak1556 |
| July 9, 2019 22:23 | https://github.com/electron/node/pull/110#commits-pushed-982406e |
|
| https://github.com/deepak1556 |
| Revert "fix: allocate memory of Buffer with V8's allocator" | https://github.com/electron/node/pull/110/commits/982406ee4e5848d73e9a6a81496fecb379cc43cc |
| 982406e | https://github.com/electron/node/pull/110/commits/982406ee4e5848d73e9a6a81496fecb379cc43cc |
| e66aa77 | https://github.com/electron/node/commit/e66aa775ee4484349dc7ae368653acd84977f041 |
|
| https://github.com/davidben |
|
| https://github.com/deepak1556 |
| crypto: fix malloc mixing in X509ToObject | https://github.com/electron/node/pull/110/commits/c2ac64913a6fd4abcf8ce3e138df21791e60cec1 |
| c2ac649 | https://github.com/electron/node/pull/110/commits/c2ac64913a6fd4abcf8ce3e138df21791e60cec1 |
| nodejs/node#25717 | https://github.com/nodejs/node/pull/25717 |
|
| https://github.com/davidben |
|
| https://github.com/deepak1556 |
| crypto: don't crash X509ToObject on error | https://github.com/electron/node/pull/110/commits/4f63360eda60cb6f27fec2a0c780ff42a23049d9 |
| 4f63360 | https://github.com/electron/node/pull/110/commits/4f63360eda60cb6f27fec2a0c780ff42a23049d9 |
| nodejs/node#25717 | https://github.com/nodejs/node/pull/25717 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: allocate Buffer memory using ArrayBuffer allocator | https://github.com/electron/node/pull/110/commits/dea1404add303eaa84bcb616263f8dc7bf39d9e6 |
| dea1404 | https://github.com/electron/node/pull/110/commits/dea1404add303eaa84bcb616263f8dc7bf39d9e6 |
| f61bae3440e | https://github.com/electron/node/commit/f61bae3440e |
| f61bae3 | https://github.com/electron/node/commit/f61bae3440e1bfcc83bba6ff0785adfb89b4045e |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: make IsolateData store ArrayBufferAllocator | https://github.com/electron/node/pull/110/commits/55381261b8ee08f789bf5c3e5e03a2633473aea2 |
| 5538126 | https://github.com/electron/node/pull/110/commits/55381261b8ee08f789bf5c3e5e03a2633473aea2 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| worker: copy transferList ArrayBuffers on unknown allocator | https://github.com/electron/node/pull/110/commits/6418b510245bac35fd7679a6f7b6e877078874d3 |
| 6418b51 | https://github.com/electron/node/pull/110/commits/6418b510245bac35fd7679a6f7b6e877078874d3 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: add debugging array allocator | https://github.com/electron/node/pull/110/commits/8867a265bc627d3296d907a06235548fa7ec72a7 |
| 8867a26 | https://github.com/electron/node/pull/110/commits/8867a265bc627d3296d907a06235548fa7ec72a7 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: add allocation utils to env | https://github.com/electron/node/pull/110/commits/b2ed6c35ab673c31dd1ca7a415e8534eb6891567 |
| b2ed6c3 | https://github.com/electron/node/pull/110/commits/b2ed6c35ab673c31dd1ca7a415e8534eb6891567 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| buffer: throw exception when creating from non-Node.js Context | https://github.com/electron/node/pull/110/commits/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d |
| 7b35642 | https://github.com/electron/node/pull/110/commits/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d |
| nodejs/node#23938 | https://github.com/nodejs/node/pull/23938 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| src: remove outdated Neuter() call in node_buffer.cc | https://github.com/electron/node/pull/110/commits/e13e8fe0bff67de3c600096ae0c1818b22a082a8 |
| e13e8fe | https://github.com/electron/node/pull/110/commits/e13e8fe0bff67de3c600096ae0c1818b22a082a8 |
| 827ee49 | https://github.com/electron/node/commit/827ee498e332e316421f565c5f763f347f81274c |
| ebbbc5a | https://github.com/electron/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589 |
| nodejs/node#3624 | https://github.com/nodejs/node/pull/3624 |
| nodejs/node#5204 | https://github.com/nodejs/node/pull/5204 |
| nodejs/node#25479 | https://github.com/nodejs/node/pull/25479 |
|
| https://github.com/davidben |
|
| https://github.com/deepak1556 |
| tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call | https://github.com/electron/node/pull/110/commits/9027c0ff04908103bdf2650fb01464db45db2448 |
| 9027c0f | https://github.com/electron/node/pull/110/commits/9027c0ff04908103bdf2650fb01464db45db2448 |
| https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html | https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html |
| nodejs/node#25706 | https://github.com/nodejs/node/pull/25706 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| zcbenz | https://github.com/zcbenz |
| July 10, 2019 10:07 | https://github.com/electron/node/pull/110#event-2472045851 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| Jul 10, 2019 | https://github.com/electron/node/pull/110#issuecomment-509999898 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/electron/node/pull/110 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| July 10, 2019 10:08 | https://github.com/electron/node/pull/110#event-2472048109 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| Jul 10, 2019 | https://github.com/electron/node/pull/110#event-2472051453 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 10, 2019
| https://github.com/electron/node/pull/110#pullrequestreview-260035842 |
|
View reviewed changes
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
| addaleax | https://github.com/addaleax |
| https://github.com/electron/node/pull/110#pullrequestreview-260035842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/node@b84b4d8 | https://github.com/nodejs/node/commit/b84b4d8c7dc957dd630a66ee372c6f29e173e98d |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
| Please reload this page | https://github.com/electron/node/pull/110 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Jul 10, 2019
| https://github.com/electron/node/pull/110#pullrequestreview-260402149 |
|
View reviewed changes
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
| zcbenz | https://github.com/zcbenz |
| https://github.com/electron/node/pull/110#pullrequestreview-260402149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/electron/node/pull/110 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
Jul 11, 2019
| https://github.com/electron/node/pull/110#pullrequestreview-260480971 |
|
View reviewed changes
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
| ryzokuken | https://github.com/ryzokuken |
| https://github.com/electron/node/pull/110#pullrequestreview-260480971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/electron/node/pull/110 |
|
| https://github.com/addaleax |
|
| https://github.com/deepak1556 |
| http2: fix tracking received data for maxSessionMemory | https://github.com/electron/node/pull/110/commits/1ca642c77b91ba2c74f80bd8955210649dc6729e |
| 1ca642c | https://github.com/electron/node/pull/110/commits/1ca642c77b91ba2c74f80bd8955210649dc6729e |
| nodejs/node#27416 | https://github.com/nodejs/node/issues/27416 |
| nodejs/node#26207 | https://github.com/nodejs/node/pull/26207 |
| nodejs/node#27914 | https://github.com/nodejs/node/pull/27914 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
| Jul 12, 2019 | https://github.com/electron/node/pull/110#event-2477595511 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
|
Jul 29, 2019
| https://github.com/electron/node/pull/110#ref-pullrequest-473893009 |
|
fix: malloc mismatch in node_crypto (electron-4.x)
#112
| https://github.com/electron/node/pull/112 |
| https://github.co/hiddenchars |
| https://github.com/electron/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110 |
|
| https://github.com/zcbenz |
|
zcbenz
| https://github.com/zcbenz |
|
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
|
| https://github.com/ryzokuken |
|
ryzokuken
| https://github.com/ryzokuken |
|
| https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448 |
| Please reload this page | https://github.com/electron/node/pull/110 |
|
| https://github.com/deepak1556 |
|
| https://github.com/zcbenz |
|
| https://github.com/addaleax |
|
| https://github.com/ryzokuken |
|
| https://github.com/davidben |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |