René's URL Explorer Experiment


Title: fix: remove array buffer allocator patch (electron-4.x) by deepak1556 · Pull Request #110 · electron/node · GitHub

Open Graph Title: fix: remove array buffer allocator patch (electron-4.x) by deepak1556 · Pull Request #110 · electron/node

X Title: fix: remove array buffer allocator patch (electron-4.x) by deepak1556 · Pull Request #110 · electron/node

Description: Node fork to make it suitable for embedding in Electron - fix: remove array buffer allocator patch (electron-4.x) by deepak1556 · Pull Request #110 · electron/node

Open Graph Description: This PR removes our array buffer allocator patch for 10.11.0 branch and replace it with official version from nodejs/node#26207 . The main reason being the patch isn't audited with every node v...

X Description: This PR removes our array buffer allocator patch for 10.11.0 branch and replace it with official version from nodejs/node#26207 . The main reason being the patch isn't audited with every no...

Opengraph URL: https://github.com/electron/node/pull/110

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3503c41a-e02d-3335-6adf-75d6485eec65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id930A:2BA6B2:2586FB6:364B525:6A566CBE
html-safe-nonce84a6cd73cd3d12a28b1c1e3630865791dfcbb4dbb0fcec4b959b77931a51ae91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzBBOjJCQTZCMjoyNTg2RkI2OjM2NEI1MjU6NkE1NjZDQkUiLCJ2aXNpdG9yX2lkIjoiNjg2NTg2MjMxMjg0MzE4MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacddd9d60ab87b5b6e188deb08cfc2682761063f712097a68c308b9b28f016e54c
hovercard-subject-tagpull_request:296102041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/electron/node/110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f441137a61b4840ccbdc6b543ddc7eb87bdeb3b8fceb93ceb0f3f91b1d3c5ef5/electron/node/pull/110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f441137a61b4840ccbdc6b543ddc7eb87bdeb3b8fceb93ceb0f3f91b1d3c5ef5/electron/node/pull/110
og:image:altThis PR removes our array buffer allocator patch for 10.11.0 branch and replace it with official version from nodejs/node#26207 . The main reason being the patch isn't audited with every node v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedeepak1556
hostnamegithub.com
expected-hostnamegithub.com
None1bfcd903bf3318822b10b18a6332fac40d3a21f7d94456dca766ab8fa7328068
turbo-cache-controlno-cache
go-importgithub.com/electron/node git https://github.com/electron/node.git
octolytics-dimension-user_id13409222
octolytics-dimension-user_loginelectron
octolytics-dimension-repository_id8767214
octolytics-dimension-repository_nwoelectron/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8767214
octolytics-dimension-repository_network_root_nwoelectron/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release37f446b78ad53e6f593aa1a4243b87c76a3428ab
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/electron/node/pull/110#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=electron%2Fnode
Reloadhttps://github.com/electron/node/pull/110
Reloadhttps://github.com/electron/node/pull/110
Reloadhttps://github.com/electron/node/pull/110
Please reload this pagehttps://github.com/electron/node/pull/110
electron https://github.com/electron
nodehttps://github.com/electron/node
Notifications https://github.com/login?return_to=%2Felectron%2Fnode
Fork 127 https://github.com/login?return_to=%2Felectron%2Fnode
Star 240 https://github.com/login?return_to=%2Felectron%2Fnode
Code https://github.com/electron/node
Issues 10 https://github.com/electron/node/issues
Pull requests 3 https://github.com/electron/node/pulls
Actions https://github.com/electron/node/actions
Projects https://github.com/electron/node/projects
Security and quality 0 https://github.com/electron/node/security
Insights https://github.com/electron/node/pulse
Code https://github.com/electron/node
Issues https://github.com/electron/node/issues
Pull requests https://github.com/electron/node/pulls
Actions https://github.com/electron/node/actions
Projects https://github.com/electron/node/projects
Security and quality https://github.com/electron/node/security
Insights https://github.com/electron/node/pulse
deepak1556https://github.com/deepak1556
electron-node-v10.11.0-V8-6.9https://github.com/electron/node/tree/electron-node-v10.11.0-V8-6.9
array_buffer_backport_10_11_xhttps://github.com/electron/node/tree/array_buffer_backport_10_11_x
Conversationhttps://github.com/electron/node/pull/110
Commits12 (12)https://github.com/electron/node/pull/110/commits
Checkshttps://github.com/electron/node/pull/110/checks
Files changedhttps://github.com/electron/node/pull/110/files
fix: remove array buffer allocator patch (electron-4.x)https://github.com/electron/node/pull/110#top
deepak1556https://github.com/deepak1556
electron-node-v10.11.0-V8-6.9https://github.com/electron/node/tree/electron-node-v10.11.0-V8-6.9
array_buffer_backport_10_11_xhttps://github.com/electron/node/tree/array_buffer_backport_10_11_x
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Jul 10, 2019https://github.com/electron/node/pull/110#issue-466220559
Please reload this pagehttps://github.com/electron/node/pull/110
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/electron/electron/search?q=set+a+breakpoint+in+malloc_error_break+to+debug&type=Issueshttps://github.com/electron/electron/search?q=set+a+breakpoint+in+malloc_error_break+to+debug&type=Issues
microsoft/vscode#76197https://github.com/microsoft/vscode/issues/76197
electron/electron#19158https://github.com/electron/electron/pull/19158
Please reload this pagehttps://github.com/electron/node/pull/110
deepak1556https://github.com/deepak1556
July 9, 2019 22:23https://github.com/electron/node/pull/110#commits-pushed-982406e
https://github.com/deepak1556
Revert "fix: allocate memory of Buffer with V8's allocator"https://github.com/electron/node/pull/110/commits/982406ee4e5848d73e9a6a81496fecb379cc43cc
982406ehttps://github.com/electron/node/pull/110/commits/982406ee4e5848d73e9a6a81496fecb379cc43cc
e66aa77https://github.com/electron/node/commit/e66aa775ee4484349dc7ae368653acd84977f041
https://github.com/davidben
https://github.com/deepak1556
crypto: fix malloc mixing in X509ToObjecthttps://github.com/electron/node/pull/110/commits/c2ac64913a6fd4abcf8ce3e138df21791e60cec1
c2ac649https://github.com/electron/node/pull/110/commits/c2ac64913a6fd4abcf8ce3e138df21791e60cec1
nodejs/node#25717https://github.com/nodejs/node/pull/25717
https://github.com/davidben
https://github.com/deepak1556
crypto: don't crash X509ToObject on errorhttps://github.com/electron/node/pull/110/commits/4f63360eda60cb6f27fec2a0c780ff42a23049d9
4f63360https://github.com/electron/node/pull/110/commits/4f63360eda60cb6f27fec2a0c780ff42a23049d9
nodejs/node#25717https://github.com/nodejs/node/pull/25717
https://github.com/addaleax
https://github.com/deepak1556
src: allocate Buffer memory using ArrayBuffer allocatorhttps://github.com/electron/node/pull/110/commits/dea1404add303eaa84bcb616263f8dc7bf39d9e6
dea1404https://github.com/electron/node/pull/110/commits/dea1404add303eaa84bcb616263f8dc7bf39d9e6
f61bae3440ehttps://github.com/electron/node/commit/f61bae3440e
f61bae3https://github.com/electron/node/commit/f61bae3440e1bfcc83bba6ff0785adfb89b4045e
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/addaleax
https://github.com/deepak1556
src: make IsolateData store ArrayBufferAllocatorhttps://github.com/electron/node/pull/110/commits/55381261b8ee08f789bf5c3e5e03a2633473aea2
5538126https://github.com/electron/node/pull/110/commits/55381261b8ee08f789bf5c3e5e03a2633473aea2
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/addaleax
https://github.com/deepak1556
worker: copy transferList ArrayBuffers on unknown allocatorhttps://github.com/electron/node/pull/110/commits/6418b510245bac35fd7679a6f7b6e877078874d3
6418b51https://github.com/electron/node/pull/110/commits/6418b510245bac35fd7679a6f7b6e877078874d3
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/addaleax
https://github.com/deepak1556
src: add debugging array allocatorhttps://github.com/electron/node/pull/110/commits/8867a265bc627d3296d907a06235548fa7ec72a7
8867a26https://github.com/electron/node/pull/110/commits/8867a265bc627d3296d907a06235548fa7ec72a7
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/addaleax
https://github.com/deepak1556
src: add allocation utils to envhttps://github.com/electron/node/pull/110/commits/b2ed6c35ab673c31dd1ca7a415e8534eb6891567
b2ed6c3https://github.com/electron/node/pull/110/commits/b2ed6c35ab673c31dd1ca7a415e8534eb6891567
nodejs/node#26207https://github.com/nodejs/node/pull/26207
https://github.com/addaleax
https://github.com/deepak1556
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/electron/node/pull/110/commits/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d
7b35642https://github.com/electron/node/pull/110/commits/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d
nodejs/node#23938https://github.com/nodejs/node/pull/23938
https://github.com/addaleax
https://github.com/deepak1556
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/electron/node/pull/110/commits/e13e8fe0bff67de3c600096ae0c1818b22a082a8
e13e8fehttps://github.com/electron/node/pull/110/commits/e13e8fe0bff67de3c600096ae0c1818b22a082a8
827ee49https://github.com/electron/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/electron/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
nodejs/node#3624https://github.com/nodejs/node/pull/3624
nodejs/node#5204https://github.com/nodejs/node/pull/5204
nodejs/node#25479https://github.com/nodejs/node/pull/25479
https://github.com/davidben
https://github.com/deepak1556
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/electron/node/pull/110/commits/9027c0ff04908103bdf2650fb01464db45db2448
9027c0fhttps://github.com/electron/node/pull/110/commits/9027c0ff04908103bdf2650fb01464db45db2448
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
nodejs/node#25706https://github.com/nodejs/node/pull/25706
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
zcbenzhttps://github.com/zcbenz
July 10, 2019 10:07https://github.com/electron/node/pull/110#event-2472045851
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Jul 10, 2019https://github.com/electron/node/pull/110#issuecomment-509999898
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/electron/node/pull/110
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
July 10, 2019 10:08https://github.com/electron/node/pull/110#event-2472048109
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Jul 10, 2019https://github.com/electron/node/pull/110#event-2472051453
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 10, 2019 https://github.com/electron/node/pull/110#pullrequestreview-260035842
View reviewed changes https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
addaleaxhttps://github.com/addaleax
https://github.com/electron/node/pull/110#pullrequestreview-260035842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
nodejs/node@b84b4d8https://github.com/nodejs/node/commit/b84b4d8c7dc957dd630a66ee372c6f29e173e98d
nodejs/node#26207https://github.com/nodejs/node/pull/26207
Please reload this pagehttps://github.com/electron/node/pull/110
https://github.com/zcbenz
zcbenzhttps://github.com/zcbenz
Jul 10, 2019 https://github.com/electron/node/pull/110#pullrequestreview-260402149
View reviewed changes https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
zcbenzhttps://github.com/zcbenz
https://github.com/electron/node/pull/110#pullrequestreview-260402149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/electron/node/pull/110
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jul 11, 2019 https://github.com/electron/node/pull/110#pullrequestreview-260480971
View reviewed changes https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
ryzokukenhttps://github.com/ryzokuken
https://github.com/electron/node/pull/110#pullrequestreview-260480971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/electron/node/pull/110
https://github.com/addaleax
https://github.com/deepak1556
http2: fix tracking received data for maxSessionMemoryhttps://github.com/electron/node/pull/110/commits/1ca642c77b91ba2c74f80bd8955210649dc6729e
1ca642chttps://github.com/electron/node/pull/110/commits/1ca642c77b91ba2c74f80bd8955210649dc6729e
nodejs/node#27416https://github.com/nodejs/node/issues/27416
nodejs/node#26207https://github.com/nodejs/node/pull/26207
nodejs/node#27914https://github.com/nodejs/node/pull/27914
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Jul 12, 2019https://github.com/electron/node/pull/110#event-2477595511
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Jul 29, 2019 https://github.com/electron/node/pull/110#ref-pullrequest-473893009
fix: malloc mismatch in node_crypto (electron-4.x) #112 https://github.com/electron/node/pull/112
https://github.co/hiddenchars
https://github.com/electron/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Felectron%2Fnode%2Fpull%2F110
https://github.com/zcbenz
zcbenz https://github.com/zcbenz
https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/electron/node/pull/110/files/9027c0ff04908103bdf2650fb01464db45db2448
Please reload this pagehttps://github.com/electron/node/pull/110
https://github.com/deepak1556
https://github.com/zcbenz
https://github.com/addaleax
https://github.com/ryzokuken
https://github.com/davidben
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.