René's URL Explorer Experiment


Title: Bug in token refresh logic makes library practically unusable · Issue #2 · ecobee/python_api_sdk · GitHub

Open Graph Title: Bug in token refresh logic makes library practically unusable · Issue #2 · ecobee/python_api_sdk

X Title: Bug in token refresh logic makes library practically unusable · Issue #2 · ecobee/python_api_sdk

Description: There is a bug in the token refresh logic that results in permanent silent failure. This makes the entire ebapi library pointless to use because authorization tokens require frequent refreshes. Calling the refresh() method on a FileToken...

Open Graph Description: There is a bug in the token refresh logic that results in permanent silent failure. This makes the entire ebapi library pointless to use because authorization tokens require frequent refreshes. Cal...

X Description: There is a bug in the token refresh logic that results in permanent silent failure. This makes the entire ebapi library pointless to use because authorization tokens require frequent refreshes. Cal...

Opengraph URL: https://github.com/ecobee/python_api_sdk/issues/2

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug in token refresh logic makes library practically unusable","articleBody":"There is a bug in the token refresh logic that results in permanent silent failure. This makes the entire `ebapi` library pointless to use because authorization tokens require frequent refreshes.\r\n\r\nCalling the `refresh()` method on a `FileTokens` instances (used by `ApiConnection`) results in a `NameError`, but is masked by a try/except block that ignores any instance of `Exception` that it catches.\r\n\r\nComment added in code snippet below ([copied from tokens.py here](https://github.com/ecobee/python_api_sdk/blob/42801b032cf67b85edd7636bbbaf456042ebd146/ebapi/tokens.py#L119-L122)) identifies where the bug is located:\r\n\r\n```python\r\n# snip\r\ntry:\r\n    self.user.loc[idx] = refresh_token(ref)  # \u003c-- refresh_token() is not defined (NameError)\r\nexcept Exception:\r\n    pass  # \u003c-- bug is completely silenced\r\n# snip\r\n```\r\n","author":{"url":"https://github.com/joxl","@type":"Person","name":"joxl"},"datePublished":"2021-07-25T04:28:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/2/python_api_sdk/issues/2"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8f4da98a-b884-475c-6996-18cdf7dbabb3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id92B4:177525:1FB4AF3:2AD0ACF:6A599A67
html-safe-noncee110a9aba9e8f5b9d5a8a8962a8413f9cdf7f0c734ef39b8e954b158fc8737a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkI0OjE3NzUyNToxRkI0QUYzOjJBRDBBQ0Y6NkE1OTlBNjciLCJ2aXNpdG9yX2lkIjoiNTUxMDgzNDAyNjMxMDExMzg5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac65eeae0b77adfccb69898ad50b53d0afe845e20140f2b31107991b62c0e521cd
hovercard-subject-tagissue:952194375
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ecobee/python_api_sdk/2/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1f7d9af5d94214832df62b17c859a2c989f278d12ef46bacca59fe2fd0e58917/ecobee/python_api_sdk/issues/2
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1f7d9af5d94214832df62b17c859a2c989f278d12ef46bacca59fe2fd0e58917/ecobee/python_api_sdk/issues/2
og:image:altThere is a bug in the token refresh logic that results in permanent silent failure. This makes the entire ebapi library pointless to use because authorization tokens require frequent refreshes. Cal...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoxl
hostnamegithub.com
expected-hostnamegithub.com
Nonea540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5
turbo-cache-controlno-preview
go-importgithub.com/ecobee/python_api_sdk git https://github.com/ecobee/python_api_sdk.git
octolytics-dimension-user_id28985350
octolytics-dimension-user_loginecobee
octolytics-dimension-repository_id131649654
octolytics-dimension-repository_nwoecobee/python_api_sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id131649654
octolytics-dimension-repository_network_root_nwoecobee/python_api_sdk
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release737e0bf019c29d8431b268ae84d528b052789210
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ecobee/python_api_sdk/issues/2#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fecobee%2Fpython_api_sdk%2Fissues%2F2
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fecobee%2Fpython_api_sdk%2Fissues%2F2
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=ecobee%2Fpython_api_sdk
Reloadhttps://github.com/ecobee/python_api_sdk/issues/2
Reloadhttps://github.com/ecobee/python_api_sdk/issues/2
Reloadhttps://github.com/ecobee/python_api_sdk/issues/2
Please reload this pagehttps://github.com/ecobee/python_api_sdk/issues/2
ecobee https://github.com/ecobee
python_api_sdkhttps://github.com/ecobee/python_api_sdk
Notifications https://github.com/login?return_to=%2Fecobee%2Fpython_api_sdk
Fork 6 https://github.com/login?return_to=%2Fecobee%2Fpython_api_sdk
Star 12 https://github.com/login?return_to=%2Fecobee%2Fpython_api_sdk
Code https://github.com/ecobee/python_api_sdk
Issues 1 https://github.com/ecobee/python_api_sdk/issues
Pull requests 2 https://github.com/ecobee/python_api_sdk/pulls
Actions https://github.com/ecobee/python_api_sdk/actions
Projects https://github.com/ecobee/python_api_sdk/projects
Security and quality 0 https://github.com/ecobee/python_api_sdk/security
Insights https://github.com/ecobee/python_api_sdk/pulse
Code https://github.com/ecobee/python_api_sdk
Issues https://github.com/ecobee/python_api_sdk/issues
Pull requests https://github.com/ecobee/python_api_sdk/pulls
Actions https://github.com/ecobee/python_api_sdk/actions
Projects https://github.com/ecobee/python_api_sdk/projects
Security and quality https://github.com/ecobee/python_api_sdk/security
Insights https://github.com/ecobee/python_api_sdk/pulse
Bug in token refresh logic makes library practically unusablehttps://github.com/ecobee/python_api_sdk/issues/2#top
https://github.com/joxl
joxlhttps://github.com/joxl
on Jul 25, 2021https://github.com/ecobee/python_api_sdk/issues/2#issue-952194375
copied from tokens.py herehttps://github.com/ecobee/python_api_sdk/blob/42801b032cf67b85edd7636bbbaf456042ebd146/ebapi/tokens.py#L119-L122
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.