René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CA2208 should not report a violation when `paramName` not specified in a property","articleBody":"### Analyzer\r\n\r\n**Diagnostic ID**: [CA2208: Instantiate argument exceptions correctly](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)\r\n\r\n### Describe the improvement\r\n\r\nSpecifying `value` as a `paramName` for `ArgumentException` in a property does not add any value over what the stack trace provides, therefore a violation should not be reported.\r\n\r\n### Example\r\n\r\n#### Existing violation\r\n\r\n```csharp\r\ninternal string Property\r\n{\r\n    set\r\n    {\r\n        _backing = value ?? throw new ArgumentNullException(); // CA2208 violation\r\n    }\r\n}\r\n```\r\n\r\nCreates the message:\r\n```\r\nValue cannot be null.\r\n```\r\n\r\n#### Fix of violation\r\n\r\n```csharp\r\ninternal string Property\r\n{\r\n    set\r\n    {\r\n        _backing = value ?? throw new ArgumentNullException(nameof(value));\r\n    }\r\n}\r\n```\r\n\r\nCreates the message:\r\n```\r\nValue cannot be null.\r\nParameter name: value\r\n```\r\n\r\n### Additional context\r\n\r\nThe book, [Framework Design Guidelines (2008)](https://docs.microsoft.com/dotnet/standard/design-guidelines/using-standard-exception-types#argumentexception-argumentnullexception-and-argumentoutofrangeexception) from Addison-Wesley Microsoft Technology Series does recommend using the implicit value parameter of property setters for `paramName` but it is not explained why this is worthwhile.\r\n\r\n\r\n### See also\r\n\r\nhttps://github.com/dotnet/roslyn-analyzers/issues/1561","author":{"url":"https://github.com/xtqqczze","@type":"Person","name":"xtqqczze"},"datePublished":"2021-07-05T20:09:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/5209/roslyn-analyzers/issues/5209"}