Title: build(deps): remove unused lru-cache dependency by HeversonSilva-gif · Pull Request #256 · docsifyjs/docsify-cli · GitHub
Open Graph Title: build(deps): remove unused lru-cache dependency by HeversonSilva-gif · Pull Request #256 · docsifyjs/docsify-cli
X Title: build(deps): remove unused lru-cache dependency by HeversonSilva-gif · Pull Request #256 · docsifyjs/docsify-cli
Description: lru-cache@^5.1.1 is declared in dependencies but is not imported anywhere in the project. Its only occurrence in the whole repository is the package.json line itself. Everyone who installs docsify-cli gets it, and nothing ever loads it. Verified at b9d118f on Node 20.20.0 / npm 10.8.2, Windows: git grep -E "(from|require\(|import\()\s*['\"]lru-cache" returns nothing, and a plain git grep for lru-cache or LRU outside the lockfile matches only package.json:61. npm run build (rollup) after the change: exit 0, lib/cli.js → bin/docsify created as before. Nothing was being bundled from it either. npm test before the change: 9 tests failed. After the change: 9 tests failed. The set of failing titles is identical, diffed rather than counted: cli › shows up help message without any args cli › shows help with -h flag cli › shows help with --help flag cli › shows version information with -v flag cli › shows version information with --version flag cli › rejects promise due to error on passing in an unknown command commands › generate › generate _sidebar.md commands › init › generates docs directory commands › init › force generates docs directory with --local flag Those 9 are pre-existing on this machine and unrelated to this change — they are the e2e tests that shell out, and they fail the same way on a clean checkout. pretest runs eslint ., which is clean on both sides. npm install reports removed 2 packages: lru-cache and yallist, which came in only as its dependency. I have not touched anything else. If you would rather I re-run the suite somewhere the e2e tests pass before this is merged, I'm happy to, but the failing set being identical is what tells you the change is inert.
Open Graph Description: lru-cache@^5.1.1 is declared in dependencies but is not imported anywhere in the project. Its only occurrence in the whole repository is the package.json line itself. Everyone who installs docsify-...
X Description: lru-cache@^5.1.1 is declared in dependencies but is not imported anywhere in the project. Its only occurrence in the whole repository is the package.json line itself. Everyone who installs docsify-...
Opengraph URL: https://github.com/docsifyjs/docsify-cli/pull/256
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c0d99226-a2c8-0a70-3ed1-f3288e8d5d84 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF4A:2F6606:252F254:33F391D:6AFD4665 |
| html-safe-nonce | 6762071e53e9778695f67c0d4365986aca3b4a77974f96303f13e0c2b9a3d182 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjRBOjJGNjYwNjoyNTJGMjU0OjMzRjM5MUQ6NkFGRDQ2NjUiLCJ2aXNpdG9yX2lkIjoiMjUxOTY3ODUxOTE2NDYxODM0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8705447a9adf24ace15c245ec1cb6465502222eed737b9cda813063015ba49aa |
| hovercard-subject-tag | pull_request:4194651347 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/docsifyjs/docsify-cli/pull/256/files |
| twitter:image | https://avatars.githubusercontent.com/u/202877675?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/202877675?s=400&v=4 |
| og:image:alt | lru-cache@^5.1.1 is declared in dependencies but is not imported anywhere in the project. Its only occurrence in the whole repository is the package.json line itself. Everyone who installs docsify-... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | bdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/docsifyjs/docsify-cli git https://github.com/docsifyjs/docsify-cli.git |
| octolytics-dimension-user_id | 40133106 |
| octolytics-dimension-user_login | docsifyjs |
| octolytics-dimension-repository_id | 74482617 |
| octolytics-dimension-repository_nwo | docsifyjs/docsify-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 74482617 |
| octolytics-dimension-repository_network_root_nwo | docsifyjs/docsify-cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 556dd37bb0aceffb25724e151b5d858b3265b40b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width