René's URL Explorer Experiment


Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java · GitHub

Open Graph Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java

X Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java

Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fixes #2184

Open Graph Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fix...

X Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in build...

Opengraph URL: https://github.com/docker-java/docker-java/pull/2305

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:797b6491-c7d3-ab60-42ad-d095673b2bac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7E6:3B2C63:1E1EE8D:29C2DD4:69728820
html-safe-nonce61c80e9ed6285838916d219de67eb6fe65a2b542dc8e7983c5de1bf5f09dc20f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0U2OjNCMkM2MzoxRTFFRThEOjI5QzJERDQ6Njk3Mjg4MjAiLCJ2aXNpdG9yX2lkIjoiNDQzNTU0MTU1NTg5MjM1NzE1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8a9e5a408360f613230740771e55f6fe684607da97161d7ae96f277a03d33f30
hovercard-subject-tagpull_request:1708835953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/docker-java/docker-java/pull/2305/files
twitter:imagehttps://avatars.githubusercontent.com/u/241630?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/241630?s=400&v=4
og:image:altThis patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fix...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7631aa5e32c11c73e45f19f2aaeaa7e0305d2ec80414866e8b020f3c2144ccae
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/docker-java/docker-java git https://github.com/docker-java/docker-java.git
octolytics-dimension-user_id7772003
octolytics-dimension-user_logindocker-java
octolytics-dimension-repository_id20415251
octolytics-dimension-repository_nwodocker-java/docker-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20415251
octolytics-dimension-repository_network_root_nwodocker-java/docker-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release40f44656d2185a364dd710032a2e10ee2f1d7e20
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/docker-java/docker-java/pull/2305/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F2305%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F2305%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=docker-java%2Fdocker-java
Reloadhttps://github.com/docker-java/docker-java/pull/2305/files
Reloadhttps://github.com/docker-java/docker-java/pull/2305/files
Reloadhttps://github.com/docker-java/docker-java/pull/2305/files
docker-java https://github.com/docker-java
docker-javahttps://github.com/docker-java/docker-java
Notifications https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Fork 1.1k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Star 3.2k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Code https://github.com/docker-java/docker-java
Issues 37 https://github.com/docker-java/docker-java/issues
Pull requests 49 https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects 0 https://github.com/docker-java/docker-java/projects
Security 0 https://github.com/docker-java/docker-java/security
Insights https://github.com/docker-java/docker-java/pulse
Code https://github.com/docker-java/docker-java
Issues https://github.com/docker-java/docker-java/issues
Pull requests https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects https://github.com/docker-java/docker-java/projects
Security https://github.com/docker-java/docker-java/security
Insights https://github.com/docker-java/docker-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
eddumelendezhttps://github.com/eddumelendez
docker-java:mainhttps://github.com/docker-java/docker-java/tree/main
niloc132:2184-correctly-failhttps://github.com/niloc132/docker-java/tree/2184-correctly-fail
Conversation 2 https://github.com/docker-java/docker-java/pull/2305
Commits 1 https://github.com/docker-java/docker-java/pull/2305/commits
Checks 0 https://github.com/docker-java/docker-java/pull/2305/checks
Files changed https://github.com/docker-java/docker-java/pull/2305/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305/files
If BuildImage fails but logs something about success, don't succeed https://github.com/docker-java/docker-java/pull/2305/files#top
Show all changes 1 commit https://github.com/docker-java/docker-java/pull/2305/files
8fad77c If BuildImage fails but logs something about success, don't succeed niloc132 Feb 2, 2024 https://github.com/docker-java/docker-java/pull/2305/commits/8fad77cbece1118361573f8bde66b547d72aadac
Clear filters https://github.com/docker-java/docker-java/pull/2305/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305/files
https://github.com/docker-java/docker-java/blob/main/.github/CODEOWNERS#L1
...er-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.javahttps://github.com/docker-java/docker-java/pull/2305/files#diff-34ba15432ae85a1f1547119259ea1e43c247d83c27de2eeecdb95d33c2c17a8c
View file https://github.com/niloc132/docker-java/blob/8fad77cbece1118361573f8bde66b547d72aadac/docker-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/docker-java/docker-java/pull/2305/{{ revealButtonHref }}
https://github.com/docker-java/docker-java/pull/2305/files#diff-34ba15432ae85a1f1547119259ea1e43c247d83c27de2eeecdb95d33c2c17a8c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.