René's URL Explorer Experiment


Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java · GitHub

Open Graph Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java

X Title: If BuildImage fails but logs something about success, don't succeed by niloc132 · Pull Request #2305 · docker-java/docker-java

Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fixes #2184

Open Graph Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fix...

X Description: This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in build...

Opengraph URL: https://github.com/docker-java/docker-java/pull/2305

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a11340d5-0f6d-c3fd-82e9-ba8abefaefff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC55A:122E03:775080:A8A489:69724D77
html-safe-nonce42cfe4eccbfa43bd43b80eb00d34d4e94759ff8682d7703ff9bd0a83c724e51e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTVBOjEyMkUwMzo3NzUwODA6QThBNDg5OjY5NzI0RDc3IiwidmlzaXRvcl9pZCI6IjYzMzA4MTczMjQwNDI1NzExMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac54e2f55a7d1c25010a11a096fc520735b8a155aed30ed273055ffdebf3fdd113
hovercard-subject-tagpull_request:1708835953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/docker-java/docker-java/2305/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4bbbcd16ba7f2b9959849d7f799c505d8bf510e9c27edbb60a920aaeaf032529/docker-java/docker-java/pull/2305
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4bbbcd16ba7f2b9959849d7f799c505d8bf510e9c27edbb60a920aaeaf032529/docker-java/docker-java/pull/2305
og:image:altThis patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fix...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameniloc132
hostnamegithub.com
expected-hostnamegithub.com
Nonef6d9b08324bb62b2cf170b9e435da2bdc7efa5aa93e7ca70ee3162552c05329b
turbo-cache-controlno-preview
go-importgithub.com/docker-java/docker-java git https://github.com/docker-java/docker-java.git
octolytics-dimension-user_id7772003
octolytics-dimension-user_logindocker-java
octolytics-dimension-repository_id20415251
octolytics-dimension-repository_nwodocker-java/docker-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20415251
octolytics-dimension-repository_network_root_nwodocker-java/docker-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release169d2b5c72bff9cc676084f0ac7f8ea888f15f54
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/docker-java/docker-java/pull/2305#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F2305
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F2305
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=docker-java%2Fdocker-java
Reloadhttps://github.com/docker-java/docker-java/pull/2305
Reloadhttps://github.com/docker-java/docker-java/pull/2305
Reloadhttps://github.com/docker-java/docker-java/pull/2305
docker-java https://github.com/docker-java
docker-javahttps://github.com/docker-java/docker-java
Notifications https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Fork 1.1k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Star 3.2k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Code https://github.com/docker-java/docker-java
Issues 37 https://github.com/docker-java/docker-java/issues
Pull requests 49 https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects 0 https://github.com/docker-java/docker-java/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/docker-java/docker-java/security
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
Insights https://github.com/docker-java/docker-java/pulse
Code https://github.com/docker-java/docker-java
Issues https://github.com/docker-java/docker-java/issues
Pull requests https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects https://github.com/docker-java/docker-java/projects
Security https://github.com/docker-java/docker-java/security
Insights https://github.com/docker-java/docker-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/docker-java/docker-java/pull/2305#issue-comment-box
eddumelendezhttps://github.com/eddumelendez
docker-java:mainhttps://github.com/docker-java/docker-java/tree/main
niloc132:2184-correctly-failhttps://github.com/niloc132/docker-java/tree/2184-correctly-fail
If BuildImage fails but logs something about success, don't succeed https://github.com/docker-java/docker-java/pull/2305#top
eddumelendezhttps://github.com/eddumelendez
docker-java:mainhttps://github.com/docker-java/docker-java/tree/main
niloc132:2184-correctly-failhttps://github.com/niloc132/docker-java/tree/2184-correctly-fail
Conversation 2 https://github.com/docker-java/docker-java/pull/2305
Commits 1 https://github.com/docker-java/docker-java/pull/2305/commits
Checks 0 https://github.com/docker-java/docker-java/pull/2305/checks
Files changed https://github.com/docker-java/docker-java/pull/2305/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
https://github.co/hiddenchars
https://github.com/docker-java/docker-java/pull/{{ revealButtonHref }}
https://github.com/niloc132
niloc132https://github.com/niloc132
Feb 2, 2024https://github.com/docker-java/docker-java/pull/2305#issue-2115355221
#2184https://github.com/docker-java/docker-java/issues/2184
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
https://github.com/niloc132
If BuildImage fails but logs something about success, don't succeedhttps://github.com/docker-java/docker-java/pull/2305/commits/8fad77cbece1118361573f8bde66b547d72aadac
8fad77chttps://github.com/docker-java/docker-java/pull/2305/commits/8fad77cbece1118361573f8bde66b547d72aadac
docker-java#2184https://github.com/docker-java/docker-java/issues/2184
https://github.com/niloc132
niloc132https://github.com/niloc132
code ownerhttps://github.com/docker-java/docker-java/blob/1bac81fa0afdae18d30bd62b1ba666375ee20147/.github/CODEOWNERS#L1
February 2, 2024 16:59https://github.com/docker-java/docker-java/pull/2305#event-11686689443
https://github.com/niloc132
niloc132https://github.com/niloc132
Feb 2, 2024https://github.com/docker-java/docker-java/pull/2305#issuecomment-1924280679
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
https://github.com/eddumelendez
eddumelendezhttps://github.com/eddumelendez
Feb 26, 2024 https://github.com/docker-java/docker-java/pull/2305#pullrequestreview-1901674720
View reviewed changes https://github.com/docker-java/docker-java/pull/2305/files/8fad77cbece1118361573f8bde66b547d72aadac
https://github.com/eddumelendez
eddumelendezhttps://github.com/eddumelendez
nexthttps://github.com/docker-java/docker-java/milestone/58
Feb 26, 2024https://github.com/docker-java/docker-java/pull/2305#event-11925451680
https://github.com/eddumelendez
eddumelendezhttps://github.com/eddumelendez
type/bug https://github.com/docker-java/docker-java/issues?q=state%3Aopen%20label%3Atype%2Fbug
Feb 26, 2024https://github.com/docker-java/docker-java/pull/2305#event-11925453368
https://github.com/eddumelendez
eddumelendezhttps://github.com/eddumelendez
4d8c436https://github.com/docker-java/docker-java/commit/4d8c436d6cbe312be22b157c3ebdb6eb973140ae
Feb 26, 2024https://github.com/docker-java/docker-java/pull/2305#event-11925458541
https://github.com/eddumelendez
eddumelendezhttps://github.com/eddumelendez
Feb 26, 2024https://github.com/docker-java/docker-java/pull/2305#issuecomment-1964827747
@niloc132https://github.com/niloc132
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F2305
https://github.com/eddumelendez
eddumelendez https://github.com/eddumelendez
https://github.com/docker-java/docker-java/pull/2305/files/8fad77cbece1118361573f8bde66b547d72aadac
type/bug https://github.com/docker-java/docker-java/issues?q=state%3Aopen%20label%3Atype%2Fbug
3.3.6 https://github.com/docker-java/docker-java/milestone/58
awaitImageId() using BuildImageResultCallback issue https://github.com/docker-java/docker-java/issues/2184
Please reload this pagehttps://github.com/docker-java/docker-java/pull/2305
https://github.com/niloc132
https://github.com/eddumelendez
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.