Title: Fix parameter order in `assertEquals` by albers · Pull Request #2066 · docker-java/docker-java · GitHub
Open Graph Title: Fix parameter order in `assertEquals` by albers · Pull Request #2066 · docker-java/docker-java
X Title: Fix parameter order in `assertEquals` by albers · Pull Request #2066 · docker-java/docker-java
Description: Fixes #1923 Parameter order Docker-Java used to implement its tests with TestNG until #909. In TestNG, assertEquals has a different parameter order (actual, expected) compared to JUnit (expected, actual). Some old tests still use the old parameter ordering, some tests follow the JUnit semantics. There are even test classes which mix both forms. While this does not affect the validity of the tests, it confuses the reader and therefore should be cleaned up. Housekeeping Being at it, I did some basic housekeeping on the tests: I removed some unused imports and unneccessary throws declarations.
Open Graph Description: Fixes #1923 Parameter order Docker-Java used to implement its tests with TestNG until #909. In TestNG, assertEquals has a different parameter order (actual, expected) compared to JUnit (expected, a...
X Description: Fixes #1923 Parameter order Docker-Java used to implement its tests with TestNG until #909. In TestNG, assertEquals has a different parameter order (actual, expected) compared to JUnit (expected, a...
Opengraph URL: https://github.com/docker-java/docker-java/pull/2066
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c7b4a787-8ddd-be36-243c-510878488414 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 962A:20853D:71EA222:9F82F50:6A4FD71D |
| html-safe-nonce | 5cc76ab225ec0c92b80a7e88d2c491f650cc83e898fa4cd1d2d317838e9a0583 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjJBOjIwODUzRDo3MUVBMjIyOjlGODJGNTA6NkE0RkQ3MUQiLCJ2aXNpdG9yX2lkIjoiMjQ0MTY2NTI1NzE3NDcxODIzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fab07e30b87739657c57f3df0b5236f19250cd3e698937be7b83ababfe823bc3 |
| hovercard-subject-tag | pull_request:1235627314 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/docker-java/docker-java/pull/2066/files |
| twitter:image | https://avatars.githubusercontent.com/u/2901725?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2901725?s=400&v=4 |
| og:image:alt | Fixes #1923 Parameter order Docker-Java used to implement its tests with TestNG until #909. In TestNG, assertEquals has a different parameter order (actual, expected) compared to JUnit (expected, a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/docker-java/docker-java git https://github.com/docker-java/docker-java.git |
| octolytics-dimension-user_id | 7772003 |
| octolytics-dimension-user_login | docker-java |
| octolytics-dimension-repository_id | 20415251 |
| octolytics-dimension-repository_nwo | docker-java/docker-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20415251 |
| octolytics-dimension-repository_network_root_nwo | docker-java/docker-java |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width