René's URL Explorer Experiment


Title: Memoize file match patterns by swiedenfeld · Pull Request #1412 · docker-java/docker-java · GitHub

Open Graph Title: Memoize file match patterns by swiedenfeld · Pull Request #1412 · docker-java/docker-java

X Title: Memoize file match patterns by swiedenfeld · Pull Request #1412 · docker-java/docker-java

Description: I ran a profiler to analyse performance of ScannedResult # addFilesInDirectory in the scenario described in #1409. All ignore strings must be matched on each of the +60k files, and a not neglible amount of time is spent compiling the Strings from ignores into patterns over and over again. It seems sensible to cache already compiled patterns into a map for quick resolution. Unfortunately, it does not improve the situation in #1409 too much. The majority of processing time is spent walking the directory tree, which is possibly bound by I/O.

Open Graph Description: I ran a profiler to analyse performance of ScannedResult # addFilesInDirectory in the scenario described in #1409. All ignore strings must be matched on each of the +60k files, and a not neglible a...

X Description: I ran a profiler to analyse performance of ScannedResult # addFilesInDirectory in the scenario described in #1409. All ignore strings must be matched on each of the +60k files, and a not neglible a...

Opengraph URL: https://github.com/docker-java/docker-java/pull/1412

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a9ed9fb6-1fea-be62-b1b8-76e9d5bf271f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1DC:E7A9D:1CB8E8:263BEA:6971AFBB
html-safe-nonce4dcdbb57d3196836d1f88c37f26e49841c3d4a36e9be46ce68b317102c919efd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMURDOkU3QTlEOjFDQjhFODoyNjNCRUE6Njk3MUFGQkIiLCJ2aXNpdG9yX2lkIjoiNDU0ODkzMzEwMzQzODExNDc0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf191e16a23aef21566ecf0c55f1fdf7cd911f86a0fd03a052c476ef1e02ddffb
hovercard-subject-tagpull_request:433662177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/docker-java/docker-java/pull/1412/files
twitter:imagehttps://avatars.githubusercontent.com/u/44531686?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/44531686?s=400&v=4
og:image:altI ran a profiler to analyse performance of ScannedResult # addFilesInDirectory in the scenario described in #1409. All ignore strings must be matched on each of the +60k files, and a not neglible a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b0f2f00499ad3dd2c21ad030a3c403edca54df20ea256f6517c6d8c4fa3a1a4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/docker-java/docker-java git https://github.com/docker-java/docker-java.git
octolytics-dimension-user_id7772003
octolytics-dimension-user_logindocker-java
octolytics-dimension-repository_id20415251
octolytics-dimension-repository_nwodocker-java/docker-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20415251
octolytics-dimension-repository_network_root_nwodocker-java/docker-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release979375c570cc30aefe2a734083debe402a612209
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/docker-java/docker-java/pull/1412/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F1412%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocker-java%2Fdocker-java%2Fpull%2F1412%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=docker-java%2Fdocker-java
Reloadhttps://github.com/docker-java/docker-java/pull/1412/files
Reloadhttps://github.com/docker-java/docker-java/pull/1412/files
Reloadhttps://github.com/docker-java/docker-java/pull/1412/files
docker-java https://github.com/docker-java
docker-javahttps://github.com/docker-java/docker-java
Notifications https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Fork 1.1k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Star 3.2k https://github.com/login?return_to=%2Fdocker-java%2Fdocker-java
Code https://github.com/docker-java/docker-java
Issues 37 https://github.com/docker-java/docker-java/issues
Pull requests 49 https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects 0 https://github.com/docker-java/docker-java/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/docker-java/docker-java/security
Please reload this pagehttps://github.com/docker-java/docker-java/pull/1412/files
Insights https://github.com/docker-java/docker-java/pulse
Code https://github.com/docker-java/docker-java
Issues https://github.com/docker-java/docker-java/issues
Pull requests https://github.com/docker-java/docker-java/pulls
Discussions https://github.com/docker-java/docker-java/discussions
Actions https://github.com/docker-java/docker-java/actions
Projects https://github.com/docker-java/docker-java/projects
Security https://github.com/docker-java/docker-java/security
Insights https://github.com/docker-java/docker-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdocker-java%2Fdocker-java%2Fissues%2Fnew%2Fchoose
bsideuphttps://github.com/bsideup
docker-java:masterhttps://github.com/docker-java/docker-java/tree/master
Conversation 8 https://github.com/docker-java/docker-java/pull/1412
Commits 2 https://github.com/docker-java/docker-java/pull/1412/commits
Checks 0 https://github.com/docker-java/docker-java/pull/1412/checks
Files changed https://github.com/docker-java/docker-java/pull/1412/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/1412/files
Memoize file match patterns https://github.com/docker-java/docker-java/pull/1412/files#top
Show all changes 2 commits https://github.com/docker-java/docker-java/pull/1412/files
cea9aff Compile each file match pattern only once swiedenfeld Jun 12, 2020 https://github.com/docker-java/docker-java/pull/1412/commits/cea9affdd2a3fa775e8e3be0cc2123214b757af1
f54ffdd Update GoLangFileMatch.java bsideup Jun 25, 2020 https://github.com/docker-java/docker-java/pull/1412/commits/f54ffddc91185044c405b89e1efd771253376813
Clear filters https://github.com/docker-java/docker-java/pull/1412/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/1412/files
Please reload this pagehttps://github.com/docker-java/docker-java/pull/1412/files
docker-java-core/src/main/java/com/github/dockerjava/core/GoLangFileMatch.javahttps://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
View file https://github.com/docker-java/docker-java/blob/f54ffddc91185044c405b89e1efd771253376813/docker-java-core/src/main/java/com/github/dockerjava/core/GoLangFileMatch.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/docker-java/docker-java/pull/1412/{{ revealButtonHref }}
https://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
https://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
https://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
https://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
https://github.com/docker-java/docker-java/pull/1412/files#diff-89975360d9b7fa5bab242819a13fea070f040ab56759cfab59dfa895b23643fd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.