René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No GenericResources in ServiceSpec.TaskTemplate.Resources.Reservations","articleBody":"I'm migrating some code that was written using https://github.com/spotify/docker-client over to docker-java. I've found a part of the Docker API that was supported in the spotify client but I can't see a way to use it in docker-java: when creating a service I want to be able to define `GenericResource`s (`NamedResourceSpec` or `DiscreteResourceSpec`) in `ServiceSpec.TaskTemplate.Resources.Reservations`.\r\n\r\nUsing the spotify client, this is the type of thing I could do\r\n```java\r\nfinal Map\u003cString, String\u003e genericResources;  // Assume this is defined somewhere\r\nfinal List\u003cResourceSpec\u003e resourceSpecs = genericResources.entrySet().stream()\r\n                .map(entry -\u003e StringUtils.isNumeric(entry.getValue()) ?\r\n                        ResourceSpec.DiscreteResourceSpec.builder().kind(entry.getKey()).value(Integer.parseInt(entry.getValue())).build() :\r\n                        ResourceSpec.NamedResourceSpec.builder().kind(entry.getKey()).value(entry.getValue()).build())\r\n                .collect(Collectors.toList());\r\nfinal ResourceRequirements resourceRequirements =\r\n        ResourceRequirements.builder()\r\n                .reservations(Reservations.builder()\r\n                        .resources(resourceSpecs)\r\n                        .build())\r\n                .build();\r\nfinal TaskSpec taskSpec = TaskSpec.builder()\r\n                .resources(resourceRequirements)\r\n                .build();\r\nfinal ServiceSpec serviceSpec = ServiceSpec.builder()\r\n                .taskTemplate(taskSpec)\r\n                .build();\r\n// then pass this to the client to create a service\r\n```\r\nIn the docker-java client I can do similar things, but I can't see a way to pass generic resources to the task spec.\r\n```java\r\nnew TaskSpec().withResources(\r\n        new ResourceRequirements().withReservations(\r\n                new ResourceSpecs().with...?  // There is nothing here that takes generic resources\r\n        )\r\n);\r\n```\r\nI do see `abstract class GenericResource\u003cT\u003e` and its concrete implementations `NamedResourceSpec` and `DiscreteResourceSpec` in `com.github.dockerjava.api.model`. But it looks to me like those are only used to deserialize `Task` responses received from the API, not used to create new services in a `TaskSpec`.\r\n\r\nAlso `NamedResourceSpec` and `DiscreteResourceSpec` are both marked `@Deprecated` but I can't understand why. That annotation was added to those classes in #1635 but I can't see it mentioned in any of the commits or the discussion.\r\n\r\nIs there some reason this isn't supported? It is part of the docker API and has been for quite some time. Alternatively, is there a workaround I could do to inject these generic resource specs directly into the API calls before they are sent? (I'm still getting used to the new(-to-me) way of working with docker-java, so I don't know what low-level tricks I can pull.) ","author":{"url":"https://github.com/johnflavin-fw","@type":"Person","name":"johnflavin-fw"},"datePublished":"2024-04-19T20:19:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/2320/docker-java/issues/2320"}