René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Test Smell: the wrong parameter order in ''assertEquals'' assertion","articleBody":"Hi!\r\n\r\nDescription:\r\nwe detect that some assertions in your test code have the wrong parameter orders.\r\nFor example, the test case named ''copyFromContainerBinaryFile()'' in ''CopyArchiveFromContainerCmdIT.java'' writes the ''assertEquals'' assertion as\r\n![image](https://user-images.githubusercontent.com/110402847/184608370-93eb6bdc-b356-4199-856c-81e1fc82fe26.png)\r\nHowever, referring to the API documentation of ''org.junit.Assert’’ is ''assertEquals(Object expected, Object actual)''.\r\n\r\nNegative:\r\nUsing ''assertEquals()'' with the wrong parameter order is a bad test practice.\r\nBecause once the test case fails, the ''assertEquals()'' assertion with the wrong parameter order will give the wrong log information.\r\nThe log information will say:’’ java.lang.AssertionError: expected [actual value] but found [ excepted value]’’, where it should have said \"java.lang.AssertionError: expected [excepted value] but found [actual value]''.\r\nThis is confusing, to say the least, and you shouldn't have to deal with a possible misdirection of that message.\r\n\r\nsolution:\r\nGenerally, the excepted value should be a known value, such as a real number, a string, etc.\r\nThe actual value should be the result of the method-under-test.\r\nThe best way to eliminate the test smell is to exchange the parameter in ''assertEquals'' assertions.\r\n\r\nWe list other test cases with the same problem as follows:\r\n1. copyFromContainerBinaryFile() in CopyArchiveFromContainerCmdIT.java\r\n2. version() in VersionCmdIT.java\r\n3. configuredInstanceAuthConfig() in DockerClientImplTest.java\r\n4. defaults() in DefaultDockerClientConfigTest.java\r\n5. assertTarArchiveEntryIsExecutableFile() in CompressArchiveUtilTest.java\r\n6. serializeCapability() in CapabilityTest.java ...","author":{"url":"https://github.com/TestSmell","@type":"Person","name":"TestSmell"},"datePublished":"2022-08-15T09:19:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1923/docker-java/issues/1923"}