René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ApacheDockerHttpClient may cause memory leak","articleBody":"ApacheDockerHttpClient may cause memory leak when client tls verify is set to true and client certificate is provided.\r\n\r\nDockerClientConfig custom = DefaultDockerClientConfig.createDefaultConfigBuilder()\r\n    .withDockerHost(\"tcp://docker.somewhere.tld:2376\")\r\n    .withDockerTlsVerify(true)\r\n    .withDockerCertPath(\"/home/user/.docker\")\r\n    .withRegistryUsername(registryUser)\r\n    .withRegistryPassword(registryPass)\r\n    .withRegistryEmail(registryMail)\r\n    .withRegistryUrl(registryUrl)\r\n    .build();\r\n\r\nDockerHttpClient httpClient = new ApacheDockerHttpClient.Builder()\r\n    .dockerHost(custom.getDockerHost())\r\n    .sslConfig(custom.getSSLConfig())\r\n    .build();\r\n\r\nThe code is copied from https://github.com/docker-java/docker-java/blob/master/docs/getting_started.md\r\n\r\nThe problem is when build ApacheDockerHttpClient, the maxConnections parameter is not set, the default value is Integer.MAX_VALUE. HttpClient will not reuse the connection when using a client certificate,  the result is HttpClient create a new connection for every request and never release one. [Here](https://stackoverflow.com/questions/13034998/httpclient-is-not-re-using-my-connections-keeps-creating-new-ones) is the explanation.\r\n\r\nSuggestion:\r\nDisable connection state when build the HttpClient.\r\n\r\nhttpClient = HttpClients.custom().disableConnectionState()...\r\n\r\n\r\n\r\n","author":{"url":"https://github.com/internalerror","@type":"Person","name":"internalerror"},"datePublished":"2021-03-15T16:00:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1559/docker-java/issues/1559"}