| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8c10ae2a-3a2c-d62e-19e6-2941602ba558 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABA6:1A99C4:103E59C:16B3712:69651038 |
| html-safe-nonce | 47c0a28068670a15fc6d1b87cac86da3242538921dfcbab03a6419b3c1ce41a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkE2OjFBOTlDNDoxMDNFNTlDOjE2QjM3MTI6Njk2NTEwMzgiLCJ2aXNpdG9yX2lkIjoiNjQ5OTQ1MTEzMTc5MDY5MjQwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4e65c9c84b4be94bf0b092d458936e7a2ff708882fa16a48afd5124581d1ae83 |
| hovercard-subject-tag | pull_request:1470183900 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/docarray/docarray/1747/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9b03af50e47a349cfffd2b10f56b6c9bb383b4ce611244a43a96f00203a6b59c/docarray/docarray/pull/1747 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b03af50e47a349cfffd2b10f56b6c9bb383b4ce611244a43a96f00203a6b59c/docarray/docarray/pull/1747 |
| og:image:alt | the following case results in a KeyError:
from docarray import BaseDoc
from docarray.utils.create_dynamic_doc_class import create_base_doc_from_schema
class Nested2(BaseDoc):
value: str
cla... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alaeddine-13 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 361e28552f448e2f3c84aa6d1d70cc09abfcd936966fa76682f0659b4f5f51d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/docarray/docarray git https://github.com/docarray/docarray.git |
| octolytics-dimension-user_id | 117445116 |
| octolytics-dimension-user_login | docarray |
| octolytics-dimension-repository_id | 438303578 |
| octolytics-dimension-repository_nwo | docarray/docarray |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438303578 |
| octolytics-dimension-repository_network_root_nwo | docarray/docarray |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb94fc71fe8da8a45636ada2c7618bc2b49b9cbe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/docarray/docarray/pull/1747#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocarray%2Fdocarray%2Fpull%2F1747 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocarray%2Fdocarray%2Fpull%2F1747 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=docarray%2Fdocarray |
| Reload | https://github.com/docarray/docarray/pull/1747 |
| Reload | https://github.com/docarray/docarray/pull/1747 |
| Reload | https://github.com/docarray/docarray/pull/1747 |
|
docarray
| https://github.com/docarray |
| docarray | https://github.com/docarray/docarray |
|
Notifications
| https://github.com/login?return_to=%2Fdocarray%2Fdocarray |
|
Fork
234
| https://github.com/login?return_to=%2Fdocarray%2Fdocarray |
|
Star
3.1k
| https://github.com/login?return_to=%2Fdocarray%2Fdocarray |
|
Code
| https://github.com/docarray/docarray |
|
Issues
68
| https://github.com/docarray/docarray/issues |
|
Pull requests
36
| https://github.com/docarray/docarray/pulls |
|
Discussions
| https://github.com/docarray/docarray/discussions |
|
Actions
| https://github.com/docarray/docarray/actions |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/docarray/docarray/security |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
|
Insights
| https://github.com/docarray/docarray/pulse |
|
Code
| https://github.com/docarray/docarray |
|
Issues
| https://github.com/docarray/docarray/issues |
|
Pull requests
| https://github.com/docarray/docarray/pulls |
|
Discussions
| https://github.com/docarray/docarray/discussions |
|
Actions
| https://github.com/docarray/docarray/actions |
|
Security
| https://github.com/docarray/docarray/security |
|
Insights
| https://github.com/docarray/docarray/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fdocarray%2Fdocarray%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fdocarray%2Fdocarray%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/docarray/docarray/pull/1747#issue-comment-box |
| samsja | https://github.com/samsja |
| main | https://github.com/docarray/docarray/tree/main |
| fix-create-from-schema | https://github.com/docarray/docarray/tree/fix-create-from-schema |
|
fix: fix dynamic class creation with doubly nested schemas
| https://github.com/docarray/docarray/pull/1747#top |
| samsja | https://github.com/samsja |
| main | https://github.com/docarray/docarray/tree/main |
| fix-create-from-schema | https://github.com/docarray/docarray/tree/fix-create-from-schema |
|
Conversation
2
| https://github.com/docarray/docarray/pull/1747 |
|
Commits
3
| https://github.com/docarray/docarray/pull/1747/commits |
|
Checks
0
| https://github.com/docarray/docarray/pull/1747/checks |
|
Files changed
| https://github.com/docarray/docarray/pull/1747/files |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
| https://github.co/hiddenchars |
| https://github.com/docarray/docarray/pull/{{ revealButtonHref }} |
|
| https://github.com/alaeddine-13 |
| alaeddine-13 | https://github.com/alaeddine-13 |
| Aug 10, 2023 | https://github.com/docarray/docarray/pull/1747#issue-1845005990 |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
| alaeddine-13 | https://github.com/alaeddine-13 |
| August 10, 2023 13:37 | https://github.com/docarray/docarray/pull/1747#commits-pushed-4f71e75 |
|
| https://github.com/alaeddine-13 |
| fix: fix dynamic class creation with doubly nested schemas | https://github.com/docarray/docarray/pull/1747/commits/4f71e75adbb57e17843d530ec3d93db745352065 |
| 4f71e75 | https://github.com/docarray/docarray/pull/1747/commits/4f71e75adbb57e17843d530ec3d93db745352065 |
|
| https://github.com/alaeddine-13 |
| test: test dynamic class creation with doubly nested schemas | https://github.com/docarray/docarray/pull/1747/commits/ba083a3be4d5b6ae52e543288a97b106151681be |
| ba083a3 | https://github.com/docarray/docarray/pull/1747/commits/ba083a3be4d5b6ae52e543288a97b106151681be |
| https://github.com/alaeddine-13 |
| alaeddine-13 | https://github.com/alaeddine-13 |
| samsja | https://github.com/samsja |
| August 10, 2023 11:40 | https://github.com/docarray/docarray/pull/1747#event-10058355845 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
size/s
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Asize%2Fs |
|
area/core
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Aarea%2Fcore |
|
area/testing
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Aarea%2Ftesting |
| Aug 10, 2023 | https://github.com/docarray/docarray/pull/1747#event-10058357407 |
|
| https://github.com/alaeddine-13 |
| chore: linting | https://github.com/docarray/docarray/pull/1747/commits/bc3e1d66fe4d3f8a193858f7b208604620744d9e |
| bc3e1d6 | https://github.com/docarray/docarray/pull/1747/commits/bc3e1d66fe4d3f8a193858f7b208604620744d9e |
| https://github.com/alaeddine-13 |
| alaeddine-13 | https://github.com/alaeddine-13 |
| force-pushed | https://github.com/docarray/docarray/compare/a0a81a36403e785fa2fbe991d69af61eca138dca..bc3e1d66fe4d3f8a193858f7b208604620744d9e |
| a0a81a3 | https://github.com/docarray/docarray/commit/a0a81a36403e785fa2fbe991d69af61eca138dca |
| bc3e1d6 | https://github.com/docarray/docarray/commit/bc3e1d66fe4d3f8a193858f7b208604620744d9e |
|
Compare
| https://github.com/docarray/docarray/compare/a0a81a36403e785fa2fbe991d69af61eca138dca..bc3e1d66fe4d3f8a193858f7b208604620744d9e |
| August 10, 2023 11:49 | https://github.com/docarray/docarray/pull/1747#event-10058447035 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 10, 2023 | https://github.com/docarray/docarray/pull/1747#issuecomment-1673076017 |
| https://ft-fix-create-from-schema--jina-docs.netlify.app | https://ft-fix-create-from-schema--jina-docs.netlify.app |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Aug 10, 2023 | https://github.com/docarray/docarray/pull/1747#issuecomment-1673078227 |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
| Codecov | https://app.codecov.io/gh/docarray/docarray/pull/1747?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| (691d939) | https://app.codecov.io/gh/docarray/docarray/commit/691d939e8021a2589c5d5106ec1270179618599d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| (bc3e1d6) | https://app.codecov.io/gh/docarray/docarray/pull/1747?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray#carryforward-flags-in-the-pull-request-comment |
| Files Changed | https://app.codecov.io/gh/docarray/docarray/pull/1747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| docarray/utils/create_dynamic_doc_class.py | https://app.codecov.io/gh/docarray/docarray/pull/1747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray#diff-ZG9jYXJyYXkvdXRpbHMvY3JlYXRlX2R5bmFtaWNfZG9jX2NsYXNzLnB5 |
| 11 files with indirect coverage changes | https://app.codecov.io/gh/docarray/docarray/pull/1747/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/docarray/docarray/pull/1747?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docarray |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
| https://github.com/samsja |
| samsja | https://github.com/samsja |
|
Aug 10, 2023
| https://github.com/docarray/docarray/pull/1747#pullrequestreview-1571905311 |
|
View reviewed changes
| https://github.com/docarray/docarray/pull/1747/files/bc3e1d66fe4d3f8a193858f7b208604620744d9e |
| https://github.com/samsja |
| samsja | https://github.com/samsja |
| adb0d01 | https://github.com/docarray/docarray/commit/adb0d0141032c72cf2412a8b998c78cd9a920a9e |
| Aug 10, 2023 | https://github.com/docarray/docarray/pull/1747#event-10059505913 |
| https://github.com/samsja |
| samsja | https://github.com/samsja |
| August 10, 2023 13:28 | https://github.com/docarray/docarray/pull/1747#event-10059506160 |
| https://github.com/alaeddine-13 |
| alaeddine-13 | https://github.com/alaeddine-13 |
|
Aug 22, 2023
| https://github.com/docarray/docarray/pull/1747#ref-issue-1861535771 |
|
chore: draft release note v0.37.1
#1756
| https://github.com/docarray/docarray/issues/1756 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocarray%2Fdocarray%2Fpull%2F1747 |
|
| https://github.com/samsja |
|
samsja
| https://github.com/samsja |
|
| https://github.com/docarray/docarray/pull/1747/files/bc3e1d66fe4d3f8a193858f7b208604620744d9e |
|
area/core
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Aarea%2Fcore |
|
area/testing
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Aarea%2Ftesting |
|
size/s
| https://github.com/docarray/docarray/issues?q=state%3Aopen%20label%3Asize%2Fs |
| Please reload this page | https://github.com/docarray/docarray/pull/1747 |
|
| https://github.com/alaeddine-13 |
|
| https://github.com/samsja |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |