René's URL Explorer Experiment


Title: Fix 'initialRequest' guard might be incorrect in DohResolver and potential 'rollback' on 'lastRequest' among concurrent requests. by LinZong · Pull Request #345 · dnsjava/dnsjava · GitHub

Open Graph Title: Fix 'initialRequest' guard might be incorrect in DohResolver and potential 'rollback' on 'lastRequest' among concurrent requests. by LinZong · Pull Request #345 · dnsjava/dnsjava

X Title: Fix 'initialRequest' guard might be incorrect in DohResolver and potential 'rollback' on 'lastRequest' among concurrent requests. by LinZong · Pull Request #345 · dnsjava/dnsjava

Description: Hi all, thanks for such solid & amazing dns implementation in Java world! Trying to employ the DoH capability to my project, and found that there might be two hard-to-find issues lying in current D...

Open Graph Description: Hi all, thanks for such solid & amazing dns implementation in Java world! Trying to employ the DoH capability to my project, and found that there might be two hard-to-find issues lying in curre...

X Description: Hi all, thanks for such solid & amazing dns implementation in Java world! Trying to employ the DoH capability to my project, and found that there might be two hard-to-find issues lying in c...

Opengraph URL: https://github.com/dnsjava/dnsjava/pull/345

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b073ac0-30fb-319f-2fa4-18757506b908
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F8C:138A2B:15A0E34:1D050C1:6970385B
html-safe-nonce9c5d13b3ea27fb393757643ccb85f0d7898abab76c71590d5e8404a30defc8a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjhDOjEzOEEyQjoxNUEwRTM0OjFEMDUwQzE6Njk3MDM4NUIiLCJ2aXNpdG9yX2lkIjoiNjc2MTIyNTMyMTE0ODU5NDI2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb39a644ea8e764cd7a0b2f9038665e23075ab28bc886c95af36969e791893c6c
hovercard-subject-tagpull_request:2110448458
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/dnsjava/dnsjava/345/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/39fd8a6c79fbed7ad91e37e24bfacc999af8849e1f74f15972b14b9a33aff987/dnsjava/dnsjava/pull/345
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39fd8a6c79fbed7ad91e37e24bfacc999af8849e1f74f15972b14b9a33aff987/dnsjava/dnsjava/pull/345
og:image:altHi all, thanks for such solid & amazing dns implementation in Java world! Trying to employ the DoH capability to my project, and found that there might be two hard-to-find issues lying in curre...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLinZong
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
go-importgithub.com/dnsjava/dnsjava git https://github.com/dnsjava/dnsjava.git
octolytics-dimension-user_id6755615
octolytics-dimension-user_logindnsjava
octolytics-dimension-repository_id17084567
octolytics-dimension-repository_nwodnsjava/dnsjava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17084567
octolytics-dimension-repository_network_root_nwodnsjava/dnsjava
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef643964067a552f02067066d6a910b2f90a5721f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/dnsjava/dnsjava/pull/345#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F345
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F345
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=dnsjava%2Fdnsjava
Reloadhttps://github.com/dnsjava/dnsjava/pull/345
Reloadhttps://github.com/dnsjava/dnsjava/pull/345
Reloadhttps://github.com/dnsjava/dnsjava/pull/345
dnsjava https://github.com/dnsjava
dnsjavahttps://github.com/dnsjava/dnsjava
Notifications https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Fork 259 https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Star 1.1k https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Code https://github.com/dnsjava/dnsjava
Issues 13 https://github.com/dnsjava/dnsjava/issues
Pull requests 2 https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/dnsjava/dnsjava/security
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
Insights https://github.com/dnsjava/dnsjava/pulse
Code https://github.com/dnsjava/dnsjava
Issues https://github.com/dnsjava/dnsjava/issues
Pull requests https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security https://github.com/dnsjava/dnsjava/security
Insights https://github.com/dnsjava/dnsjava/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/dnsjava/dnsjava/pull/345#issue-comment-box
ibauersachshttps://github.com/ibauersachs
dnsjava:masterhttps://github.com/dnsjava/dnsjava/tree/master
LinZong:bugfix/fix_initial_request_guard_conditionhttps://github.com/LinZong/dnsjava/tree/bugfix/fix_initial_request_guard_condition
Fix 'initialRequest' guard might be incorrect in DohResolver and potential 'rollback' on 'lastRequest' among concurrent requests. https://github.com/dnsjava/dnsjava/pull/345#top
ibauersachshttps://github.com/ibauersachs
dnsjava:masterhttps://github.com/dnsjava/dnsjava/tree/master
LinZong:bugfix/fix_initial_request_guard_conditionhttps://github.com/LinZong/dnsjava/tree/bugfix/fix_initial_request_guard_condition
Conversation 2 https://github.com/dnsjava/dnsjava/pull/345
Commits 2 https://github.com/dnsjava/dnsjava/pull/345/commits
Checks 14 https://github.com/dnsjava/dnsjava/pull/345/checks
Files changed 2 https://github.com/dnsjava/dnsjava/pull/345/files
https://github.co/hiddenchars
https://github.com/dnsjava/dnsjava/pull/{{ revealButtonHref }}
https://github.com/LinZong
LinZonghttps://github.com/LinZong
Oct 7, 2024https://github.com/dnsjava/dnsjava/pull/345#issue-2569963138
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
DoH implementationhttps://github.com/dnsjava/dnsjava/blob/master/src/main/java/org/xbill/DNS/DohResolver.java
dnsjava/src/main/java/org/xbill/DNS/DohResolver.javahttps://github.com/dnsjava/dnsjava/blob/a6371af00867d13e5b3dbee040f640e93420fb21/src/main/java/org/xbill/DNS/DohResolver.java#L478-L483
a6371afhttps://github.com/dnsjava/dnsjava/commit/a6371af00867d13e5b3dbee040f640e93420fb21
https://private-user-images.githubusercontent.com/10548832/374133019-0485c8a7-1eef-4c3a-b23e-56188a78c962.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg5NjI0MzksIm5iZiI6MTc2ODk2MjEzOSwicGF0aCI6Ii8xMDU0ODgzMi8zNzQxMzMwMTktMDQ4NWM4YTctMWVlZi00YzNhLWIyM2UtNTYxODhhNzhjOTYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTIxVDAyMjIxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkMTAxZDc3NjVhNDVmZDJmZTNlZGY1NjkxYTFjNTczZGQ1ZGU2MmQ5NzdlOGZkZGYyZmRkNGQ3MTE1MjAxM2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Fjq_zKQE54y6sn08SIavsrx3wmiUcXWulpCxJ39iMtw
dnsjava/src/main/java/org/xbill/DNS/DohResolver.javahttps://github.com/dnsjava/dnsjava/blob/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496/src/main/java/org/xbill/DNS/DohResolver.java#L478-L488
e1e5c0chttps://github.com/dnsjava/dnsjava/commit/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496
dnsjava/src/main/java/org/xbill/DNS/DohResolver.javahttps://github.com/dnsjava/dnsjava/blob/a6371af00867d13e5b3dbee040f640e93420fb21/src/main/java/org/xbill/DNS/DohResolver.java#L541-L557
a6371afhttps://github.com/dnsjava/dnsjava/commit/a6371af00867d13e5b3dbee040f640e93420fb21
dnsjava/src/main/java/org/xbill/DNS/DohResolver.javahttps://github.com/dnsjava/dnsjava/blob/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496/src/main/java/org/xbill/DNS/DohResolver.java#L540-L552
e1e5c0chttps://github.com/dnsjava/dnsjava/commit/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
https://github.com/LinZong
LinZonghttps://github.com/LinZong
Oct 7, 2024https://github.com/dnsjava/dnsjava/pull/345#event-14537773011
https://github.com/LinZong
LinZonghttps://github.com/LinZong
Oct 7, 2024https://github.com/dnsjava/dnsjava/pull/345#event-14537783033
https://github.com/LinZong
LinZonghttps://github.com/LinZong
Oct 7, 2024https://github.com/dnsjava/dnsjava/pull/345#event-14538289670
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Nov 10, 2024https://github.com/dnsjava/dnsjava/pull/345#issuecomment-2466537836
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
LinZonghttps://github.com/LinZong
January 5, 2025 15:26https://github.com/dnsjava/dnsjava/pull/345#commits-pushed-265adac
https://github.com/LinZong
https://github.com/ibauersachs
1. Fix 'initialRequest' guard might be incorrect if the initial value…https://github.com/dnsjava/dnsjava/pull/345/commits/265adacdf7202e65632e28c3137adfed5175f45c
265adachttps://github.com/dnsjava/dnsjava/pull/345/commits/265adacdf7202e65632e28c3137adfed5175f45c
https://github.com/ibauersachs
Fix initial request using recommended nanoTime calculationhttps://github.com/dnsjava/dnsjava/pull/345/commits/a026ff309e42722926f4c00100ffe84533b159ab
a026ff3https://github.com/dnsjava/dnsjava/pull/345/commits/a026ff309e42722926f4c00100ffe84533b159ab
dnsjava#345https://github.com/dnsjava/dnsjava/pull/345
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
force-pushedhttps://github.com/dnsjava/dnsjava/compare/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496..a026ff309e42722926f4c00100ffe84533b159ab
e1e5c0chttps://github.com/dnsjava/dnsjava/commit/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496
a026ff3https://github.com/dnsjava/dnsjava/commit/a026ff309e42722926f4c00100ffe84533b159ab
Compare https://github.com/dnsjava/dnsjava/compare/e1e5c0c7ffb1e91dc604459a2855b39e9cc3c496..a026ff309e42722926f4c00100ffe84533b159ab
January 5, 2025 14:27https://github.com/dnsjava/dnsjava/pull/345#event-15817547612
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Jan 5, 2025https://github.com/dnsjava/dnsjava/pull/345#issuecomment-2571648477
System.nanoTime()https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#nanoTime--
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
9a748a0https://github.com/dnsjava/dnsjava/commit/9a748a04f6e39b348fb747bd8f03390abbfe450f
Jan 5, 2025https://github.com/dnsjava/dnsjava/pull/345#event-15817566993
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
v3.6.3https://github.com/dnsjava/dnsjava/milestone/20
Jan 26, 2025https://github.com/dnsjava/dnsjava/pull/345#event-16070155637
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F345
v3.6.3 https://github.com/dnsjava/dnsjava/milestone/20
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/345
https://github.com/LinZong
https://github.com/ibauersachs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.