René's URL Explorer Experiment


Title: Fix validation of TSIG signed responses by ibauersachs · Pull Request #249 · dnsjava/dnsjava · GitHub

Open Graph Title: Fix validation of TSIG signed responses by ibauersachs · Pull Request #249 · dnsjava/dnsjava

X Title: Fix validation of TSIG signed responses by ibauersachs · Pull Request #249 · dnsjava/dnsjava

Opengraph URL: https://github.com/dnsjava/dnsjava/pull/249

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9e03ef6-8159-d1a5-819f-eea7c917e44c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD84C:25EF8D:301264E:4100D3F:69708A43
html-safe-nonce8a38c542b888675ebf9bdaedf71e3fb9c196605ab28f5f2a4c0487fd104fad35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODRDOjI1RUY4RDozMDEyNjRFOjQxMDBEM0Y6Njk3MDhBNDMiLCJ2aXNpdG9yX2lkIjoiMzIxMjkxMjIwODA4NTI4OTUzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd2e57febde150ca65d4b02a485916b471cf68426966bd7bf18c717bb342a0cf
hovercard-subject-tagpull_request:877752804
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/dnsjava/dnsjava/249/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/45bc160aa18a81a010102f8f12a71b8e1e27f9f3341ca5ba44acc0c2461cedc6/dnsjava/dnsjava/pull/249
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45bc160aa18a81a010102f8f12a71b8e1e27f9f3341ca5ba44acc0c2461cedc6/dnsjava/dnsjava/pull/249
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameibauersachs
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
go-importgithub.com/dnsjava/dnsjava git https://github.com/dnsjava/dnsjava.git
octolytics-dimension-user_id6755615
octolytics-dimension-user_logindnsjava
octolytics-dimension-repository_id17084567
octolytics-dimension-repository_nwodnsjava/dnsjava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17084567
octolytics-dimension-repository_network_root_nwodnsjava/dnsjava
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/dnsjava/dnsjava/pull/249#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F249
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F249
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=dnsjava%2Fdnsjava
Reloadhttps://github.com/dnsjava/dnsjava/pull/249
Reloadhttps://github.com/dnsjava/dnsjava/pull/249
Reloadhttps://github.com/dnsjava/dnsjava/pull/249
dnsjava https://github.com/dnsjava
dnsjavahttps://github.com/dnsjava/dnsjava
Notifications https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Fork 259 https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Star 1.1k https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Code https://github.com/dnsjava/dnsjava
Issues 13 https://github.com/dnsjava/dnsjava/issues
Pull requests 2 https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/dnsjava/dnsjava/security
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
Insights https://github.com/dnsjava/dnsjava/pulse
Code https://github.com/dnsjava/dnsjava
Issues https://github.com/dnsjava/dnsjava/issues
Pull requests https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security https://github.com/dnsjava/dnsjava/security
Insights https://github.com/dnsjava/dnsjava/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/dnsjava/dnsjava/pull/249#issue-comment-box
ibauersachshttps://github.com/ibauersachs
release/3.5.xhttps://github.com/dnsjava/dnsjava/tree/release/3.5.x
bugfix/tsig-responsehttps://github.com/dnsjava/dnsjava/tree/bugfix/tsig-response
Fix validation of TSIG signed responses https://github.com/dnsjava/dnsjava/pull/249#top
ibauersachshttps://github.com/ibauersachs
release/3.5.xhttps://github.com/dnsjava/dnsjava/tree/release/3.5.x
bugfix/tsig-responsehttps://github.com/dnsjava/dnsjava/tree/bugfix/tsig-response
Conversation 2 https://github.com/dnsjava/dnsjava/pull/249
Commits 2 https://github.com/dnsjava/dnsjava/pull/249/commits
Checks 0 https://github.com/dnsjava/dnsjava/pull/249/checks
Files changed https://github.com/dnsjava/dnsjava/pull/249/files
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
https://github.co/hiddenchars
https://github.com/dnsjava/dnsjava/pull/{{ revealButtonHref }}
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#issue-1166783017
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
ibauersachshttps://github.com/ibauersachs
March 11, 2022 20:33https://github.com/dnsjava/dnsjava/pull/249#commits-pushed-116cc88
https://github.com/ibauersachs
Fix validation of signed responseshttps://github.com/dnsjava/dnsjava/pull/249/commits/116cc886220c2598cf3d9cdf84c7705999b34395
116cc88https://github.com/dnsjava/dnsjava/pull/249/commits/116cc886220c2598cf3d9cdf84c7705999b34395
#248https://github.com/dnsjava/dnsjava/issues/248
https://github.com/ibauersachs
Cleanup of jnamedhttps://github.com/dnsjava/dnsjava/pull/249/commits/a0b347033cf6cc8f76b5b9d29b4024d4fefa67c3
a0b3470https://github.com/dnsjava/dnsjava/pull/249/commits/a0b347033cf6cc8f76b5b9d29b4024d4fefa67c3
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
March 11, 2022 19:35https://github.com/dnsjava/dnsjava/pull/249#event-6227093629
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#event-6227094719
DDNS update successful but response from DNS server has invalid TSIG #248 https://github.com/dnsjava/dnsjava/issues/248
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
v3.5.1https://github.com/dnsjava/dnsjava/milestone/15
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#event-6227096837
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#event-6227246815
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#event-6227248030
https://github.com/apps/sonarqubecloud
sonarqubecloudhttps://github.com/apps/sonarqubecloud
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#issuecomment-1065458609
https://camo.githubusercontent.com/45f964061036fa3afd18c2540a6be5b9875c8206d3de1c212cecfcfbd95079ce/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f6661696c65642d313670782e706e67
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=BUG
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=BUG
0 Bugshttps://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=BUG
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=VULNERABILITY
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=VULNERABILITY
0 Vulnerabilitieshttps://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=VULNERABILITY
https://sonarcloud.io/project/security_hotspots?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=SECURITY_HOTSPOT
https://sonarcloud.io/project/security_hotspots?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=SECURITY_HOTSPOT
0 Security Hotspotshttps://sonarcloud.io/project/security_hotspots?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=SECURITY_HOTSPOT
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=CODE_SMELL
https://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=CODE_SMELL
2 Code Smellshttps://sonarcloud.io/project/issues?id=dnsjava_dnsjava&pullRequest=249&resolved=false&types=CODE_SMELL
https://sonarcloud.io/component_measures?id=dnsjava_dnsjava&pullRequest=249&metric=new_coverage&view=list
49.2% Coveragehttps://sonarcloud.io/component_measures?id=dnsjava_dnsjava&pullRequest=249&metric=new_coverage&view=list
https://sonarcloud.io/component_measures?id=dnsjava_dnsjava&pullRequest=249&metric=new_duplicated_lines_density&view=list
0.0% Duplicationhttps://sonarcloud.io/component_measures?id=dnsjava_dnsjava&pullRequest=249&metric=new_duplicated_lines_density&view=list
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Mar 11, 2022https://github.com/dnsjava/dnsjava/pull/249#issuecomment-1065460164
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
Codecovhttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
(181aaaf)https://app.codecov.io/gh/dnsjava/dnsjava/commit/181aaaf1cb5c3dc411abc3a9a220ee3a5287bbfd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
(a0b3470)https://app.codecov.io/gh/dnsjava/dnsjava/commit/a0b347033cf6cc8f76b5b9d29b4024d4fefa67c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Files with missing lineshttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/tools/jnamed.javahttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fxbill%2FDNS%2Ftools%2Fjnamed.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL3Rvb2xzL2puYW1lZC5qYXZh
14 Missing ⚠️ https://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/TSIG.javahttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fxbill%2FDNS%2FTSIG.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL1RTSUcuamF2YQ==
2 Missing and 1 partial ⚠️ https://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/SimpleResolver.javahttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fxbill%2FDNS%2FSimpleResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL1NpbXBsZVJlc29sdmVyLmphdmE=
2 Missing ⚠️ https://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/DohResolver.javahttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fxbill%2FDNS%2FDohResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL0RvaFJlc29sdmVyLmphdmE=
1 Missing ⚠️ https://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/Message.javahttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fxbill%2FDNS%2FMessage.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL01lc3NhZ2UuamF2YQ==
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/dnsjava/dnsjava/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/dnsjava/dnsjava/pull/249?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
17fe79chttps://github.com/dnsjava/dnsjava/commit/17fe79c36e1d85c2f0faba87c4bc057c2b18633e
Mar 19, 2022https://github.com/dnsjava/dnsjava/pull/249#event-6270006716
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
March 19, 2022 14:48https://github.com/dnsjava/dnsjava/pull/249#event-6270006776
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F249
v3.5.1 https://github.com/dnsjava/dnsjava/milestone/15
DDNS update successful but response from DNS server has invalid TSIG https://github.com/dnsjava/dnsjava/issues/248
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/249
https://github.com/ibauersachs
https://github.com/codecov-commenter
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.