René's URL Explorer Experiment


Title: Allow SVCB ServiceMode records without params by adam-stoler · Pull Request #244 · dnsjava/dnsjava · GitHub

Open Graph Title: Allow SVCB ServiceMode records without params by adam-stoler · Pull Request #244 · dnsjava/dnsjava

X Title: Allow SVCB ServiceMode records without params by adam-stoler · Pull Request #244 · dnsjava/dnsjava

Description: Fixes #243 Remove incorrect check that required at least one param to be specified for ServiceMode records Add unit tests to verify that ServiceMode records without any params are allowed and can b...

Open Graph Description: Fixes #243 Remove incorrect check that required at least one param to be specified for ServiceMode records Add unit tests to verify that ServiceMode records without any params are allowed and can b...

X Description: Fixes #243 Remove incorrect check that required at least one param to be specified for ServiceMode records Add unit tests to verify that ServiceMode records without any params are allowed and can b...

Opengraph URL: https://github.com/dnsjava/dnsjava/pull/244

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5435066d-76a6-d07c-ec29-dafabd229caa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB18:3476BC:DAA2AA:1313EA3:6970C16E
html-safe-nonce5ccf8d84e186dc041f77cea8381f642a9744cf8298e50077cfd292383e0ea97c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjE4OjM0NzZCQzpEQUEyQUE6MTMxM0VBMzo2OTcwQzE2RSIsInZpc2l0b3JfaWQiOiIyMTcxNDkzOTkwMTI3NDE5NzU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf9ed642b8bf5575cdbce16671c6b56ff8e604274adc5a2575c0e7a9965948373
hovercard-subject-tagpull_request:825783585
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/dnsjava/dnsjava/244/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a43b6a4240845f104f17138078947c8801a6cee4255cf7442e09f1ca62efadad/dnsjava/dnsjava/pull/244
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a43b6a4240845f104f17138078947c8801a6cee4255cf7442e09f1ca62efadad/dnsjava/dnsjava/pull/244
og:image:altFixes #243 Remove incorrect check that required at least one param to be specified for ServiceMode records Add unit tests to verify that ServiceMode records without any params are allowed and can b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameadam-stoler
hostnamegithub.com
expected-hostnamegithub.com
Nonebb43a7bc61aba1b91c3c5cf8e7d00342e1e77a0cfe55a141222dbd7f9782d26f
turbo-cache-controlno-preview
go-importgithub.com/dnsjava/dnsjava git https://github.com/dnsjava/dnsjava.git
octolytics-dimension-user_id6755615
octolytics-dimension-user_logindnsjava
octolytics-dimension-repository_id17084567
octolytics-dimension-repository_nwodnsjava/dnsjava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17084567
octolytics-dimension-repository_network_root_nwodnsjava/dnsjava
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release34817b01ad7cdf8b2beb35ea7b0e2a7609004eff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/dnsjava/dnsjava/pull/244#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F244
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F244
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=dnsjava%2Fdnsjava
Reloadhttps://github.com/dnsjava/dnsjava/pull/244
Reloadhttps://github.com/dnsjava/dnsjava/pull/244
Reloadhttps://github.com/dnsjava/dnsjava/pull/244
dnsjava https://github.com/dnsjava
dnsjavahttps://github.com/dnsjava/dnsjava
Notifications https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Fork 259 https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Star 1.1k https://github.com/login?return_to=%2Fdnsjava%2Fdnsjava
Code https://github.com/dnsjava/dnsjava
Issues 13 https://github.com/dnsjava/dnsjava/issues
Pull requests 2 https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/dnsjava/dnsjava/security
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
Insights https://github.com/dnsjava/dnsjava/pulse
Code https://github.com/dnsjava/dnsjava
Issues https://github.com/dnsjava/dnsjava/issues
Pull requests https://github.com/dnsjava/dnsjava/pulls
Actions https://github.com/dnsjava/dnsjava/actions
Security https://github.com/dnsjava/dnsjava/security
Insights https://github.com/dnsjava/dnsjava/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdnsjava%2Fdnsjava%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/dnsjava/dnsjava/pull/244#issue-comment-box
ibauersachshttps://github.com/ibauersachs
dnsjava:masterhttps://github.com/dnsjava/dnsjava/tree/master
adam-stoler:svcb.allow-no-params.fixhttps://github.com/adam-stoler/dnsjava/tree/svcb.allow-no-params.fix
Allow SVCB ServiceMode records without params https://github.com/dnsjava/dnsjava/pull/244#top
ibauersachshttps://github.com/ibauersachs
dnsjava:masterhttps://github.com/dnsjava/dnsjava/tree/master
adam-stoler:svcb.allow-no-params.fixhttps://github.com/adam-stoler/dnsjava/tree/svcb.allow-no-params.fix
Conversation 1 https://github.com/dnsjava/dnsjava/pull/244
Commits 1 https://github.com/dnsjava/dnsjava/pull/244/commits
Checks 0 https://github.com/dnsjava/dnsjava/pull/244/checks
Files changed https://github.com/dnsjava/dnsjava/pull/244/files
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
https://github.co/hiddenchars
https://github.com/dnsjava/dnsjava/pull/{{ revealButtonHref }}
https://github.com/adam-stoler
adam-stolerhttps://github.com/adam-stoler
Jan 18, 2022https://github.com/dnsjava/dnsjava/pull/244#issue-1107253526
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
#243https://github.com/dnsjava/dnsjava/issues/243
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
Remove incorrect check that required at least one param to be specifi…https://github.com/dnsjava/dnsjava/pull/244/commits/41ddd7e05a44a75923fae81e5b3439375251619a
41ddd7ehttps://github.com/dnsjava/dnsjava/pull/244/commits/41ddd7e05a44a75923fae81e5b3439375251619a
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jan 18, 2022https://github.com/dnsjava/dnsjava/pull/244#issuecomment-1015726922
Codecovhttps://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
#244https://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
41ddd7ehttps://github.com/dnsjava/dnsjava/commit/41ddd7e05a44a75923fae81e5b3439375251619a
masterhttps://codecov.io/gh/dnsjava/dnsjava/commit/4eff20317c4844149f3cfd259714fbd9736ffd73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
4eff203https://github.com/dnsjava/dnsjava/commit/4eff20317c4844149f3cfd259714fbd9736ffd73
https://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Impacted Fileshttps://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
src/main/java/org/xbill/DNS/SVCBBase.javahttps://codecov.io/gh/dnsjava/dnsjava/pull/244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL1NWQ0JCYXNlLmphdmE=
src/main/java/org/xbill/DNS/DohResolver.javahttps://codecov.io/gh/dnsjava/dnsjava/pull/244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL0RvaFJlc29sdmVyLmphdmE=
src/main/java/org/xbill/DNS/DNSSEC.javahttps://codecov.io/gh/dnsjava/dnsjava/pull/244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL0ROU1NFQy5qYXZh
src/main/java/org/xbill/DNS/NioTcpClient.javahttps://codecov.io/gh/dnsjava/dnsjava/pull/244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava#diff-c3JjL21haW4vamF2YS9vcmcveGJpbGwvRE5TL05pb1RjcENsaWVudC5qYXZh
Continue to review full report at Codecovhttps://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Codecovhttps://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
4eff203...41ddd7ehttps://codecov.io/gh/dnsjava/dnsjava/pull/244?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dnsjava
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
https://github.com/adam-stoler
adam-stolerhttps://github.com/adam-stoler
Jan 18, 2022https://github.com/dnsjava/dnsjava/pull/244#event-5912720976
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
4dea758https://github.com/dnsjava/dnsjava/commit/4dea7580e74c01e88681569cefa1ff05c88636ac
Jan 18, 2022https://github.com/dnsjava/dnsjava/pull/244#event-5913535125
https://github.com/ibauersachs
ibauersachshttps://github.com/ibauersachs
v3.5https://github.com/dnsjava/dnsjava/milestone/12
Jan 18, 2022https://github.com/dnsjava/dnsjava/pull/244#event-5913550802
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdnsjava%2Fdnsjava%2Fpull%2F244
v3.5 https://github.com/dnsjava/dnsjava/milestone/12
dnsjava refuses to create a HTTPS record from a String if at least one parameter is not provided https://github.com/dnsjava/dnsjava/issues/243
Please reload this pagehttps://github.com/dnsjava/dnsjava/pull/244
https://github.com/adam-stoler
https://github.com/codecov-commenter
https://github.com/ibauersachs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.