René's URL Explorer Experiment


Title: fix(hub-ui): hide the panel while a toggle action is on by antfubot · Pull Request #477 · devframes/devframe · GitHub

Open Graph Title: fix(hub-ui): hide the panel while a toggle action is on by antfubot · Pull Request #477 · devframes/devframe

X Title: fix(hub-ui): hide the panel while a toggle action is on by antfubot · Pull Request #477 · devframes/devframe

Description: Fixes a bug in #469 (toggle dock actions, released in 1.3.0). Problem When a toggle action turns on, the hub sets panel.session.open to false and keeps the selection. The floating panel in DockPanel.vue showed whenever a dock was selected. It did not read session.open, so the panel stayed on the page over the tool. Edge mode already read session.open, so only the floating dock had the bug. Fix The floating panel and the edge panel now use one helper, getPanelViewEntry(context). It returns the selected view only while session.open is true. The selection stays, and the iframe stays mounted. When the tool turns off, the same view, route, and sub-tab come back. While the panel is hidden, the dock bar does not mark the selected view as active. A click on that view opens it again. Before, the click cleared the selection. The guide for hub UI providers now says that a provider must show the panel only while panel.session.open is true. I did not change the hub to save and restore the selection. That approach unmounts the view and loses the iframe state. I looked for code that needs "open is false but the panel shows". I found none. Outside click and Escape already clear the selection. Dock auto-hide treats open: false as closed. Edge mode already hid the panel. The standalone viewer does not use session.open. The two custom hub examples have no floating panel. Verification New test in client-script.integration.test.ts. It turns the tool on and off in three ways: a second click, setActionActive(id, false), and the Escape command. After each one, it checks that the panel view is hidden and that the same view and route come back. The test fails without the fix. Real browser (Chromium, hub-ui playground ?embedded, with a temporary toggle action): Step Before After Open a view panel shows panel shows Tool on panel still shows (open: false) panel hidden Escape panel shows panel shows, same view Tool on, then click it again panel never hid hidden, then shows, same view Tool on, then setActionActive(id, false) panel never hid hidden, then shows, same view Click the view while the tool is on selection cleared view opens, tool off pnpm lint, pnpm knip, pnpm typecheck, and pnpm build pass. pnpm test: 1813 tests pass. Two devframe tests fail in my sandbox ([::1] loopback through an HTTP proxy). They are not related to this change. 🤖 Generated with Claude Code

Open Graph Description: Fixes a bug in #469 (toggle dock actions, released in 1.3.0). Problem When a toggle action turns on, the hub sets panel.session.open to false and keeps the selection. The floating panel in DockPane...

X Description: Fixes a bug in #469 (toggle dock actions, released in 1.3.0). Problem When a toggle action turns on, the hub sets panel.session.open to false and keeps the selection. The floating panel in DockPane...

Opengraph URL: https://github.com/devframes/devframe/pull/477

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1e110de5-a4f7-b835-22ab-53038ffae8c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB97E:55280:341D8:49FF1:6AFB72E4
html-safe-noncef8b866f672017b53a88433d378201ddf04698b42afa17b9be7557357d67c2477
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTdFOjU1MjgwOjM0MUQ4OjQ5RkYxOjZBRkI3MkU0IiwidmlzaXRvcl9pZCI6IjQ5Mzc3NDI2MTU3MzE0NjY5ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac943868a2ae8467c43e5f5673979dd01fe49df82f1180a16bcb224ae62bad9aef
hovercard-subject-tagpull_request:5107539058
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/477/files
twitter:imagehttps://avatars.githubusercontent.com/u/291667613?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/291667613?s=400&v=4
og:image:altFixes a bug in #469 (toggle dock actions, released in 1.3.0). Problem When a toggle action turns on, the hub sets panel.session.open to false and keeps the selection. The floating panel in DockPane...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/477/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F477%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F477%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/477/files
Reloadhttps://github.com/devframes/devframe/pull/477/files
Reloadhttps://github.com/devframes/devframe/pull/477/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
antfuhttps://github.com/antfu
mainhttps://github.com/devframes/devframe/tree/main
fix/toggle-action-hide-panelhttps://github.com/devframes/devframe/tree/fix/toggle-action-hide-panel
Conversation 2 https://github.com/devframes/devframe/pull/477
Commits 1 https://github.com/devframes/devframe/pull/477/commits
Checks 13 https://github.com/devframes/devframe/pull/477/checks
Files changed 6 https://github.com/devframes/devframe/pull/477/files
fix(hub-ui): hide the panel while a toggle action is on https://github.com/devframes/devframe/pull/477/files#top
Show all changes 1 commit https://github.com/devframes/devframe/pull/477/files
43cfb85 fix(hub-ui): hide the panel while a toggle action is on antfubot Nov 1, 2026 https://github.com/devframes/devframe/pull/477/commits/43cfb85e528d9775b2e7f227b6cdd0523309d409
Clear filters https://github.com/devframes/devframe/pull/477/files
Please reload this pagehttps://github.com/devframes/devframe/pull/477/files
Please reload this pagehttps://github.com/devframes/devframe/pull/477/files
22.build-your-own-hub-ui.md https://github.com/devframes/devframe/pull/477/files#diff-218946028148db269433e0457f462dc546b603b85031e4a80f4069b5494203c1
Dock.vue https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
DockEdge.vue https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
DockPanel.vue https://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
client-script.integration.test.ts https://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
dock-settings.ts https://github.com/devframes/devframe/pull/477/files#diff-7f167a656077d3e4bb909f88552e81ded51361472f35d5e1939cb69bed06a3d0
docs/content/1.guide/22.build-your-own-hub-ui.mdhttps://github.com/devframes/devframe/pull/477/files#diff-218946028148db269433e0457f462dc546b603b85031e4a80f4069b5494203c1
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/docs/content/1.guide/22.build-your-own-hub-ui.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-218946028148db269433e0457f462dc546b603b85031e4a80f4069b5494203c1
https://github.com/devframes/devframe/pull/477/files#diff-218946028148db269433e0457f462dc546b603b85031e4a80f4069b5494203c1
packages/hub-ui/src/client/components/dock/Dock.vuehttps://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/packages/hub-ui/src/client/components/dock/Dock.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
https://github.com/devframes/devframe/pull/477/files#diff-92238e9fe0779328d4c671cc204341c152bb4293fc186eef2aaae60c880db444
packages/hub-ui/src/client/components/dock/DockEdge.vuehttps://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/packages/hub-ui/src/client/components/dock/DockEdge.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
https://github.com/devframes/devframe/pull/477/files#diff-c6d6f16b96d134f884666803b5cf80623d7c71b5725510ba70761859e28195c2
packages/hub-ui/src/client/components/dock/DockPanel.vuehttps://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/packages/hub-ui/src/client/components/dock/DockPanel.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
https://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
https://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
https://github.com/devframes/devframe/pull/477/files#diff-bdca6a24a81da1545e2f11cd7159d2334727ffeec2be56b6b0ce25b4ac156aca
packages/hub-ui/src/client/state/client-script.integration.test.tshttps://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/packages/hub-ui/src/client/state/client-script.integration.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
https://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
https://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
https://github.com/devframes/devframe/pull/477/files#diff-b8181422e317754042b42616a78a256ae27959a05a267d6dba0668b2903adffc
packages/hub-ui/src/client/state/dock-settings.tshttps://github.com/devframes/devframe/pull/477/files#diff-7f167a656077d3e4bb909f88552e81ded51361472f35d5e1939cb69bed06a3d0
View file https://github.com/devframes/devframe/blob/43cfb85e528d9775b2e7f227b6cdd0523309d409/packages/hub-ui/src/client/state/dock-settings.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/477/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/477/files#diff-7f167a656077d3e4bb909f88552e81ded51361472f35d5e1939cb69bed06a3d0
https://github.com/devframes/devframe/pull/477/files#diff-7f167a656077d3e4bb909f88552e81ded51361472f35d5e1939cb69bed06a3d0
https://github.com/devframes/devframe/pull/477/files#diff-7f167a656077d3e4bb909f88552e81ded51361472f35d5e1939cb69bed06a3d0
Please reload this pagehttps://github.com/devframes/devframe/pull/477/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.