René's URL Explorer Experiment


Title: fix(hub-ui): mark the selected dock with aria-current by erkamyaman · Pull Request #475 · devframes/devframe · GitHub

Open Graph Title: fix(hub-ui): mark the selected dock with aria-current by erkamyaman · Pull Request #475 · devframes/devframe

X Title: fix(hub-ui): mark the selected dock with aria-current by erkamyaman · Pull Request #475 · devframes/devframe

Description: The dock bar and the group sidebar showed the selected dock only with a scale and a color. A screen reader announced every dock button the same way, so its user could not tell which dock was open (WCAG 4.1.2). The button of the dock whose view is shown now gets aria-current="page", in the dock bar, the group sidebar, and the group and overflow popover. One helper, getCurrentDockId(), decides which dock that is: the selected dock, but not an action, and not while the panel of an embedded dock is closed. A group button is not marked, so a group and its member are never both current. Checks eslint on the changed files, and tsc --noEmit in packages/hub-ui The standalone and embedded builds both have aria-current In Chromium, standalone hub: exactly one button is aria-current="page", and it moves when another dock is selected

Open Graph Description: The dock bar and the group sidebar showed the selected dock only with a scale and a color. A screen reader announced every dock button the same way, so its user could not tell which dock was open (...

X Description: The dock bar and the group sidebar showed the selected dock only with a scale and a color. A screen reader announced every dock button the same way, so its user could not tell which dock was open (...

Opengraph URL: https://github.com/devframes/devframe/pull/475

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f03e0d8-f808-6e62-cf81-3a07932f7c58
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA268:3ED756:9A0E18:D80C8B:6AFB72EB
html-safe-nonce4164c3912a4bf5ad8b5cca6492c016d605cfa1f8918b66f82ed9f60c7dfe713a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjY4OjNFRDc1Njo5QTBFMTg6RDgwQzhCOjZBRkI3MkVCIiwidmlzaXRvcl9pZCI6IjM3NDMwMDY4NDI4MzQwODg2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac61ba283cf6b4399ffb1051b9cc3ad375629b0b179e7cfb571ae94999aba18e1f
hovercard-subject-tagpull_request:5107146511
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/475/files
twitter:imagehttps://avatars.githubusercontent.com/u/88717125?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/88717125?s=400&v=4
og:image:altThe dock bar and the group sidebar showed the selected dock only with a scale and a color. A screen reader announced every dock button the same way, so its user could not tell which dock was open (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/475/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F475%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F475%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/475/files
Reloadhttps://github.com/devframes/devframe/pull/475/files
Reloadhttps://github.com/devframes/devframe/pull/475/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
antfuhttps://github.com/antfu
devframes:mainhttps://github.com/devframes/devframe/tree/main
erkamyaman:fix/dock-aria-currenthttps://github.com/erkamyaman/devframe/tree/fix/dock-aria-current
Conversation 21 https://github.com/devframes/devframe/pull/475
Commits 6 https://github.com/devframes/devframe/pull/475/commits
Checks 12 https://github.com/devframes/devframe/pull/475/checks
Files changed 8 https://github.com/devframes/devframe/pull/475/files
fix(hub-ui): mark the selected dock with aria-current https://github.com/devframes/devframe/pull/475/files#top
Show all changes 6 commits https://github.com/devframes/devframe/pull/475/files
7360105 fix(hub-ui): mark the selected dock with aria-current erkamyaman Oct 21, 2026 https://github.com/devframes/devframe/pull/475/commits/7360105594735a94e6c2f9776e8122d0693a4f43
3d5bc17 Merge branch 'main' into fix/dock-aria-current erkamyaman Oct 31, 2026 https://github.com/devframes/devframe/pull/475/commits/3d5bc17fe9600c06934ebf93efda2bae498d1d53
4258a28 fix(hub-ui): keep one current dock per set and cover hidden members erkamyaman Nov 1, 2026 https://github.com/devframes/devframe/pull/475/commits/4258a2880465e10a13bdde4535b3b2681afea7c2
f29aff7 fix(hub-ui): mark only the shown dock view as current erkamyaman Nov 1, 2026 https://github.com/devframes/devframe/pull/475/commits/f29aff7267d82ee8108634983e39ead52aaade8c
6661e14 fix(hub-ui): mark the button that holds a hidden current dock erkamyaman Nov 1, 2026 https://github.com/devframes/devframe/pull/475/commits/6661e1434c90f4e461e441d16a32813e2a13e777
3a56edf fix(hub-ui): skip the group when its current member has its own button erkamyaman Nov 1, 2026 https://github.com/devframes/devframe/pull/475/commits/3a56edf266a8c641a8d16eed626946f163ca1446
Clear filters https://github.com/devframes/devframe/pull/475/files
Please reload this pagehttps://github.com/devframes/devframe/pull/475/files
Please reload this pagehttps://github.com/devframes/devframe/pull/475/files
DockEntries.vue https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
DockEntry.vue https://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
DockGroupButton.vue https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
DockGroupPopover.vue https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
DockGroupSidebar.vue https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
DockOverflowButton.vue https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
docks.test.ts https://github.com/devframes/devframe/pull/475/files#diff-e05c82e52b0bf82a8d14c500e1fd446eb388c2245f39eef9a7c9788222782693
docks.ts https://github.com/devframes/devframe/pull/475/files#diff-9f362d129dd387e07143a8d94f0818cb66f9aea602eb1ad18676762008345323
packages/hub-ui/src/client/components/dock/DockEntries.vuehttps://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockEntries.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
https://github.com/devframes/devframe/pull/475/files#diff-bdf7be3ad95ef5ff5fe194f8965a78cbc7330359facf0ea6b534214afb933ec9
packages/hub-ui/src/client/components/dock/DockEntry.vuehttps://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockEntry.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
https://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
https://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
https://github.com/devframes/devframe/pull/475/files#diff-93bca24165c965fa327f14f0a5cfb20e3bd3a21d46d84c422fde2dfa249a69b1
packages/hub-ui/src/client/components/dock/DockGroupButton.vuehttps://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockGroupButton.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
https://github.com/devframes/devframe/pull/475/files#diff-517eadb8bf85a7f8695ed4f4fa2d81214bbc1f696dada97fc74616f226043625
packages/hub-ui/src/client/components/dock/DockGroupPopover.vuehttps://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockGroupPopover.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
https://github.com/devframes/devframe/pull/475/files#diff-a9ce0e59e6985f281631a79601ddda4a6c8d07839019b7079bcc2a68e2404a5d
packages/hub-ui/src/client/components/dock/DockGroupSidebar.vuehttps://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockGroupSidebar.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
Please reload this pagehttps://github.com/devframes/devframe/pull/475/files
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
https://github.com/devframes/devframe/pull/475/files#diff-46d695689608311496b4169e4b1e102243e43de5ae43f42d6862b60d9c105bc0
packages/hub-ui/src/client/components/dock/DockOverflowButton.vuehttps://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/components/dock/DockOverflowButton.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
https://github.com/devframes/devframe/pull/475/files#diff-5531833910d13d0d5c67759769bb267f09f6a080cc85dcdb1d450799041223cd
packages/hub-ui/src/client/state/docks.test.tshttps://github.com/devframes/devframe/pull/475/files#diff-e05c82e52b0bf82a8d14c500e1fd446eb388c2245f39eef9a7c9788222782693
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/state/docks.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
packages/hub-ui/src/client/state/docks.tshttps://github.com/devframes/devframe/pull/475/files#diff-9f362d129dd387e07143a8d94f0818cb66f9aea602eb1ad18676762008345323
View file https://github.com/erkamyaman/devframe/blob/3a56edf266a8c641a8d16eed626946f163ca1446/packages/hub-ui/src/client/state/docks.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/475/{{ revealButtonHref }}
Please reload this pagehttps://github.com/devframes/devframe/pull/475/files
https://github.com/devframes/devframe/pull/475/files#diff-9f362d129dd387e07143a8d94f0818cb66f9aea602eb1ad18676762008345323
Please reload this pagehttps://github.com/devframes/devframe/pull/475/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.