Title: fix(hub-ui): keep language options reachable in short windows by SaKaNa-Y · Pull Request #447 · devframes/devframe · GitHub
Open Graph Title: fix(hub-ui): keep language options reachable in short windows by SaKaNa-Y · Pull Request #447 · devframes/devframe
X Title: fix(hub-ui): keep language options reachable in short windows by SaKaNa-Y · Pull Request #447 · devframes/devframe
Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author). If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence. I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏) I hold myself to this standard for every PR, regardless of its size. When the window is too short for the language menu, its lower options extend outside the viewport and cannot be reached by scrolling. This prevents selecting those languages without enlarging the window. Limit the existing Reka select viewport to its available height, accounting for the content border, and contain vertical overscroll. This is a downstream compatibility fix for the current FormSelect component in @antfu/design. It can be removed after a dependency update provides the same behavior. Verification: Previously verified scrolling to and selecting the last language in Float, Edge, Popup, and standalone views in Chrome. Verified that an open menu adapts when the window shrinks and grows. Verified keyboard End/Enter selection and light-mode rendering in the standalone view. Full repository lint, knip, tests (1,732 passed, 13 skipped), typecheck, and build passed with both independent fixes applied locally. The isolated menu branch also passed its hub-ui dependency build.
Open Graph Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...
X Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...
Opengraph URL: https://github.com/devframes/devframe/pull/447
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:241f9b8e-f4a5-7048-1c83-b56b44d06f99 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A24C:5A439:978364:D51789:6AFB72E8 |
| html-safe-nonce | 8f76729b1095c3ce9ad3c4470a24df816c71e36eff1b28878d830d1ae9c2d059 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjRDOjVBNDM5Ojk3ODM2NDpENTE3ODk6NkFGQjcyRTgiLCJ2aXNpdG9yX2lkIjoiMjA0MTYxOTQzMTg2NzI0OTM4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9dfddfac2774449335603bb792618109988474eee0e4e928a1c3d170602b1af1 |
| hovercard-subject-tag | pull_request:4852897800 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/447/files |
| twitter:image | https://avatars.githubusercontent.com/u/185575200?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/185575200?s=400&v=4 |
| og:image:alt | ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/devframes/devframe git https://github.com/devframes/devframe.git |
| octolytics-dimension-user_id | 279879373 |
| octolytics-dimension-user_login | devframes |
| octolytics-dimension-repository_id | 1231722386 |
| octolytics-dimension-repository_nwo | devframes/devframe |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1231722386 |
| octolytics-dimension-repository_network_root_nwo | devframes/devframe |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width