René's URL Explorer Experiment


Title: fix(hub-ui): warn about shortcut conflicts across modes by SaKaNa-Y · Pull Request #443 · devframes/devframe · GitHub

Open Graph Title: fix(hub-ui): warn about shortcut conflicts across modes by SaKaNa-Y · Pull Request #443 · devframes/devframe

X Title: fix(hub-ui): warn about shortcut conflicts across modes by SaKaNa-Y · Pull Request #443 · devframes/devframe

Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author). If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence. I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏) I hold myself to this standard for every PR, regardless of its size. Assign a shortcut to Float Mode, open the popup window, and assign the same shortcut to Open Settings. The editor gives no conflict warning because Float Mode is hidden in the popup. Both commands become available again when the popup closes, so the duplicate binding can prevent one command from receiving the shortcut. Check effective bindings across all commands that allow shortcuts, including commands hidden by the current mode. Keep the settings list filtered by mode and continue to allow saving after a warning. Tests cover hidden and nested commands, disabled shortcuts, the edited command, and cleared or overridden bindings. Validation: The author manually tested the rebuilt UI and confirmed the fix. All 15 keybinding tests pass. An isolated run of the component warning logic returns no popup conflict before the change and a conflict after it. Full lint, knip, typecheck, and build checks complete successfully. Full tests: 1,662 passed, 13 skipped, and 2 failed. The failures are the runtime and declaration API snapshots for @devframes/hub-ui-onboard, which omit the existing defaultMessages export. Both failures also reproduce with the three changed source files restored to unmodified HEAD.

Open Graph Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

X Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

Opengraph URL: https://github.com/devframes/devframe/pull/443

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ca08af47-27c4-f825-60e9-6111d1af666b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED8A:26EC7A:9B3ACA:D9E6B9:6AFB72F3
html-safe-nonce2041f86767ac606170a2d002c1b84852f011cfb7e2abb7bc80fd9d92723051d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDhBOjI2RUM3QTo5QjNBQ0E6RDlFNkI5OjZBRkI3MkYzIiwidmlzaXRvcl9pZCI6IjE3NTEzMzYwNjEzNDgwNDk2NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac379c6457129ac83c8bccb65fb81e1ecbddc8599d6350a65ac3318c349cbf2a48
hovercard-subject-tagpull_request:4769420907
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/443/files
twitter:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
og:image:altImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/443/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F443%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F443%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/443/files
Reloadhttps://github.com/devframes/devframe/pull/443/files
Reloadhttps://github.com/devframes/devframe/pull/443/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
antfuhttps://github.com/antfu
devframes:mainhttps://github.com/devframes/devframe/tree/main
SaKaNa-Y:fix/shortcut-conflicts-across-modeshttps://github.com/SaKaNa-Y/devframe/tree/fix/shortcut-conflicts-across-modes
Conversation 3 https://github.com/devframes/devframe/pull/443
Commits 2 https://github.com/devframes/devframe/pull/443/commits
Checks 12 https://github.com/devframes/devframe/pull/443/checks
Files changed https://github.com/devframes/devframe/pull/443/files
Please reload this pagehttps://github.com/devframes/devframe/pull/443/files
fix(hub-ui): warn about shortcut conflicts across modes https://github.com/devframes/devframe/pull/443/files#top
Show all changes 2 commits https://github.com/devframes/devframe/pull/443/files
b2f9b23 fix(hub-ui): warn about shortcut conflicts across modes SaKaNa-Y Oct 7, 2026 https://github.com/devframes/devframe/pull/443/commits/b2f9b23f103a95d80dd7cab8d1e9255561cf2db9
1c03be9 Merge branch 'main' into fix/shortcut-conflicts-across-modes antfu Oct 13, 2026 https://github.com/devframes/devframe/pull/443/commits/1c03be9e5a31bc3315e96ed3d1a120c4ca683b9e
Clear filters https://github.com/devframes/devframe/pull/443/files
Please reload this pagehttps://github.com/devframes/devframe/pull/443/files
Please reload this pagehttps://github.com/devframes/devframe/pull/443/files
SettingsShortcuts.vue https://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
keybindings.test.ts https://github.com/devframes/devframe/pull/443/files#diff-1df0cca98432dc70390b869e4596a62ea0dc9f3c4416e55a60310f2f7f6047ec
keybindings.ts https://github.com/devframes/devframe/pull/443/files#diff-6840d7128b262e55fc5c7e417b7e05d9349f4c01712301bb5d054078868d3868
packages/hub-ui/src/client/components/views-builtin/SettingsShortcuts.vuehttps://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
View file https://github.com/SaKaNa-Y/devframe/blob/1c03be9e5a31bc3315e96ed3d1a120c4ca683b9e/packages/hub-ui/src/client/components/views-builtin/SettingsShortcuts.vue
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/443/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
https://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
https://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
https://github.com/devframes/devframe/pull/443/files#diff-24ae785162b0bfd210e1e0c842d2fa4e03dace380ce0f5a5209969517204bec1
packages/hub-ui/src/client/state/keybindings.test.tshttps://github.com/devframes/devframe/pull/443/files#diff-1df0cca98432dc70390b869e4596a62ea0dc9f3c4416e55a60310f2f7f6047ec
View file https://github.com/SaKaNa-Y/devframe/blob/1c03be9e5a31bc3315e96ed3d1a120c4ca683b9e/packages/hub-ui/src/client/state/keybindings.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/443/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/443/files#diff-1df0cca98432dc70390b869e4596a62ea0dc9f3c4416e55a60310f2f7f6047ec
packages/hub-ui/src/client/state/keybindings.tshttps://github.com/devframes/devframe/pull/443/files#diff-6840d7128b262e55fc5c7e417b7e05d9349f4c01712301bb5d054078868d3868
View file https://github.com/SaKaNa-Y/devframe/blob/1c03be9e5a31bc3315e96ed3d1a120c4ca683b9e/packages/hub-ui/src/client/state/keybindings.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/443/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/443/files#diff-6840d7128b262e55fc5c7e417b7e05d9349f4c01712301bb5d054078868d3868
https://github.com/devframes/devframe/pull/443/files#diff-6840d7128b262e55fc5c7e417b7e05d9349f4c01712301bb5d054078868d3868
Please reload this pagehttps://github.com/devframes/devframe/pull/443/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.