René's URL Explorer Experiment


Title: fix(settings): wait for the initial client snapshot by SaKaNa-Y · Pull Request #424 · devframes/devframe · GitHub

Open Graph Title: fix(settings): wait for the initial client snapshot by SaKaNa-Y · Pull Request #424 · devframes/devframe

X Title: fix(settings): wait for the initial client snapshot by SaKaNa-Y · Pull Request #424 · devframes/devframe

Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author). If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence. I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏) I hold myself to this standard for every PR, regardless of its size. Problem When browser-side code uses settings immediately after connecting, await settings.set('theme', 'dark') can finish before the initial node-side snapshot arrives. That snapshot then restores the old value. An immediate read can also return an empty store, and an immediate deletion can be undone. Wait for RPC trust and the initial snapshot before running settings operations. If the snapshot is absent, reads return empty values without publishing a shared state. The first set creates the state. This preserves file storage when browser-side code reads settings before node-side initialization. Initialization errors propagate and clear the cached promise so the next operation can retry. Client-first write persistence is tracked separately in #423. Verification All 14 settings initialization tests pass. Coverage includes both scopes, delayed snapshots, concurrent first operations, absent stores, static mode, trust, retry, and later remote updates. Project and global storage regressions verify that a browser-side read preserves existing file values, later node-side writes reach disk, and a fresh context reads them back. These tests use real storage and shared-state code with direct RPC handler calls. Local full suite: 1,649 passed, 13 skipped (pnpm exec vitest run after the build). Local lint, knip, typecheck, and build pass. Typecheck: 40 tasks. Build: 28 tasks.

Open Graph Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

X Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

Opengraph URL: https://github.com/devframes/devframe/pull/424

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5dcd4f69-28fd-56b4-8de4-2a41a7eee7af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7CC:329C8:220D80:2FE9A7:6AFB7B8A
html-safe-noncef1aea1e42159c5fd9242613cfbe6b0e358a1e2eb8d2c5412be9c8cbb820936da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0NDOjMyOUM4OjIyMEQ4MDoyRkU5QTc6NkFGQjdCOEEiLCJ2aXNpdG9yX2lkIjoiMzQ5NDY2Njc3MDAxMjkyODkwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac821215cda0ff53e29204b9671707b33dd9ae80d1964ec235d2e36e9399f0c369
hovercard-subject-tagpull_request:4717599109
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/424/files
twitter:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
og:image:altImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/424/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F424%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F424%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/424/files
Reloadhttps://github.com/devframes/devframe/pull/424/files
Reloadhttps://github.com/devframes/devframe/pull/424/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
SaKaNa-Yhttps://github.com/SaKaNa-Y
devframes:mainhttps://github.com/devframes/devframe/tree/main
SaKaNa-Y:fix/client-settings-initializationhttps://github.com/SaKaNa-Y/devframe/tree/fix/client-settings-initialization
Conversation 3 https://github.com/devframes/devframe/pull/424
Commits 2 https://github.com/devframes/devframe/pull/424/commits
Checks 12 https://github.com/devframes/devframe/pull/424/checks
Files changed https://github.com/devframes/devframe/pull/424/files
Please reload this pagehttps://github.com/devframes/devframe/pull/424/files
fix(settings): wait for the initial client snapshot https://github.com/devframes/devframe/pull/424/files#top
Show all changes 2 commits https://github.com/devframes/devframe/pull/424/files
5f3ed0d fix(settings): wait for the initial client snapshot SaKaNa-Y Oct 2, 2026 https://github.com/devframes/devframe/pull/424/commits/5f3ed0d816e4988a2a1df0dd7dc69fcdc7b6e371
c1bedd1 fix(settings): keep empty reads from publishing state SaKaNa-Y Oct 11, 2026 https://github.com/devframes/devframe/pull/424/commits/c1bedd19f7562b3b0c02df5630ab08ce9b077437
Clear filters https://github.com/devframes/devframe/pull/424/files
Please reload this pagehttps://github.com/devframes/devframe/pull/424/files
Please reload this pagehttps://github.com/devframes/devframe/pull/424/files
rpc-shared-state.ts https://github.com/devframes/devframe/pull/424/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
scope.test.ts https://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
settings.test.ts https://github.com/devframes/devframe/pull/424/files#diff-61e6073dd9d21add1eff4e05d14e3a972c60ec5709c22207c6eb4c1582df5418
settings.ts https://github.com/devframes/devframe/pull/424/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
settings-store.ts https://github.com/devframes/devframe/pull/424/files#diff-8ad130cacac5d0f41bfc2e1b08f6011af910223f8ef922b85ab8add128f04062
packages/devframe/src/client/rpc-shared-state.tshttps://github.com/devframes/devframe/pull/424/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
View file https://github.com/SaKaNa-Y/devframe/blob/c1bedd19f7562b3b0c02df5630ab08ce9b077437/packages/devframe/src/client/rpc-shared-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/424/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/424/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/424/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/424/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
packages/devframe/src/client/scope.test.tshttps://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
View file https://github.com/SaKaNa-Y/devframe/blob/c1bedd19f7562b3b0c02df5630ab08ce9b077437/packages/devframe/src/client/scope.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/424/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/424/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
packages/devframe/src/client/settings.test.tshttps://github.com/devframes/devframe/pull/424/files#diff-61e6073dd9d21add1eff4e05d14e3a972c60ec5709c22207c6eb4c1582df5418
View file https://github.com/SaKaNa-Y/devframe/blob/c1bedd19f7562b3b0c02df5630ab08ce9b077437/packages/devframe/src/client/settings.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/424/{{ revealButtonHref }}
packages/devframe/src/client/settings.tshttps://github.com/devframes/devframe/pull/424/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
View file https://github.com/SaKaNa-Y/devframe/blob/c1bedd19f7562b3b0c02df5630ab08ce9b077437/packages/devframe/src/client/settings.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/424/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/424/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
https://github.com/devframes/devframe/pull/424/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
packages/devframe/src/settings-store.tshttps://github.com/devframes/devframe/pull/424/files#diff-8ad130cacac5d0f41bfc2e1b08f6011af910223f8ef922b85ab8add128f04062
View file https://github.com/SaKaNa-Y/devframe/blob/c1bedd19f7562b3b0c02df5630ab08ce9b077437/packages/devframe/src/settings-store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/424/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/424/files#diff-8ad130cacac5d0f41bfc2e1b08f6011af910223f8ef922b85ab8add128f04062
Please reload this pagehttps://github.com/devframes/devframe/pull/424/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.