René's URL Explorer Experiment


Title: fix(settings): persist client-first settings updates by SaKaNa-Y · Pull Request #423 · devframes/devframe · GitHub

Open Graph Title: fix(settings): persist client-first settings updates by SaKaNa-Y · Pull Request #423 · devframes/devframe

X Title: fix(settings): persist client-first settings updates by SaKaNa-Y · Pull Request #423 · devframes/devframe

Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author). If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence. I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏) I hold myself to this standard for every PR, regardless of its size. Summary When an RPC client saves scoped settings before the node side accesses them, the values disappear after a restart. I expect those settings to survive without prior node-side initialization. Resolve reserved settings keys to file storage on first access, and reuse that state for reads, snapshots, and patches. RPC client settings also wait for trust and the initial snapshot before any read or change. This prevents a delayed empty snapshot from erasing the first write. Failed snapshot reads reject the operation and allow a retry. Settings operation Wait for trust Resolve file storage and read the initial snapshot Apply the read or change Sync changes and persist them If the initial snapshot is absent, reads expose an empty store without publishing shared state. The first set creates the object. This includes all changes and tests from #424, including its empty-state fix at c1bedd19. Evidence Before: Client-first project/global updates disappeared after recreating the node context. A delayed empty snapshot also erased an immediate first write. After: Regression tests preserve the first write in both scopes and read it from a fresh node context. Before this update: Two new tests failed because reads of absent project/global stores published {}. After: All 16 client settings tests pass, including all 14 cases from #424 and two delayed-snapshot persistence cases. Coverage includes existing-file patches, storage after a browser-side read, scope isolation, escaping keys, immediate reads and deletes, static settings, trust, and failed-snapshot retries. The delayed-snapshot tests use the real settings and shared-state implementations with a controlled RPC transport. The earlier cross-process WebSocket smoke test was not rerun for this update. Validation passed: ESLint, knip, typecheck, build, and the full Vitest suite. All 1,657 tests passed across 148 files, with 13 skipped tests. Build completed 28 tasks. GitHub CI passed all 10 jobs for 4ee8c814: Linux and Windows on Node 22/24/26, lint/typecheck, end-to-end tests, and Bun/Deno smoke tests. Merge Danger Door: Two-way. Storage paths and the JSON format stay unchanged. Blast Radius: Settings and shared-state initialization. Settings operations now wait for the initial snapshot. Initial-read failures in the shared-state API now reject instead of leaving the promise pending.

Open Graph Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

X Description: ImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...

Opengraph URL: https://github.com/devframes/devframe/pull/423

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fd8e51d6-57b2-260c-82e8-434f9f58729c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA3E:394173:1452664:1BCF1E4:6AFB72F3
html-safe-nonce8bf0706b198c350b41f67ec743be5e083e9afd0f1472daa5377bac690ea14454
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTNFOjM5NDE3MzoxNDUyNjY0OjFCQ0YxRTQ6NkFGQjcyRjMiLCJ2aXNpdG9yX2lkIjoiMjU0ODM0MTg5NzIxNjI5NDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ed67d66720dc116a56755d9e3b4c01bc05268033ff6005da31e31e531d05963
hovercard-subject-tagpull_request:4717477742
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/423/files
twitter:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/185575200?s=400&v=4
og:image:altImportantPlease take a moment to read this. Thank you! I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/423/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F423%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F423%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/423/files
Reloadhttps://github.com/devframes/devframe/pull/423/files
Reloadhttps://github.com/devframes/devframe/pull/423/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
antfuhttps://github.com/antfu
devframes:mainhttps://github.com/devframes/devframe/tree/main
SaKaNa-Y:fix/client-settings-persistencehttps://github.com/SaKaNa-Y/devframe/tree/fix/client-settings-persistence
Conversation 3 https://github.com/devframes/devframe/pull/423
Commits 3 https://github.com/devframes/devframe/pull/423/commits
Checks 13 https://github.com/devframes/devframe/pull/423/checks
Files changed https://github.com/devframes/devframe/pull/423/files
Please reload this pagehttps://github.com/devframes/devframe/pull/423/files
fix(settings): persist client-first settings updates https://github.com/devframes/devframe/pull/423/files#top
Show all changes 3 commits https://github.com/devframes/devframe/pull/423/files
5451401 fix(settings): persist client-first settings updates SaKaNa-Y Oct 2, 2026 https://github.com/devframes/devframe/pull/423/commits/54514015e6a19f4efeffbd8374e2a32396923e3a
5c3e841 fix(settings): await the initial snapshot before saving SaKaNa-Y Oct 11, 2026 https://github.com/devframes/devframe/pull/423/commits/5c3e8417333217e3136610a38b54744197918951
4ee8c81 fix(settings): keep empty reads from publishing state SaKaNa-Y Oct 11, 2026 https://github.com/devframes/devframe/pull/423/commits/4ee8c8148883a5930924429c2c038b42d96b6ea4
Clear filters https://github.com/devframes/devframe/pull/423/files
Please reload this pagehttps://github.com/devframes/devframe/pull/423/files
Please reload this pagehttps://github.com/devframes/devframe/pull/423/files
rpc-shared-state.ts https://github.com/devframes/devframe/pull/423/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
scope.test.ts https://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
settings.test.ts https://github.com/devframes/devframe/pull/423/files#diff-61e6073dd9d21add1eff4e05d14e3a972c60ec5709c22207c6eb4c1582df5418
settings.ts https://github.com/devframes/devframe/pull/423/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
scope.test.ts https://github.com/devframes/devframe/pull/423/files#diff-03e2e7673023f693f2fb6824fc9488d7e862b8074ff0db7123fb928776bcf943
host-functions.ts https://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
rpc-shared-state.ts https://github.com/devframes/devframe/pull/423/files#diff-8cc18347186150a72c2d96f76fcbdc7398f546504c5b982d4bc1840f1c59d76f
settings.ts https://github.com/devframes/devframe/pull/423/files#diff-2591d4f988a3479ff6761d023d1a3fcd546bfc6aaa6958ae1efa0514691ca1de
settings-store.ts https://github.com/devframes/devframe/pull/423/files#diff-8ad130cacac5d0f41bfc2e1b08f6011af910223f8ef922b85ab8add128f04062
packages/devframe/src/client/rpc-shared-state.tshttps://github.com/devframes/devframe/pull/423/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/client/rpc-shared-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/423/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/423/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/423/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
packages/devframe/src/client/scope.test.tshttps://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/client/scope.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
https://github.com/devframes/devframe/pull/423/files#diff-f0bf6fce581ac353d9abe69781069c9b6a9c46f13f23a595035d00e46c8ad796
packages/devframe/src/client/settings.test.tshttps://github.com/devframes/devframe/pull/423/files#diff-61e6073dd9d21add1eff4e05d14e3a972c60ec5709c22207c6eb4c1582df5418
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/client/settings.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
packages/devframe/src/client/settings.tshttps://github.com/devframes/devframe/pull/423/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/client/settings.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/423/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
https://github.com/devframes/devframe/pull/423/files#diff-9ef78e74e7b30075207cef5042d633c99069e92eb48d5a15c2ffbe4e0c814983
packages/devframe/src/node/__tests__/scope.test.tshttps://github.com/devframes/devframe/pull/423/files#diff-03e2e7673023f693f2fb6824fc9488d7e862b8074ff0db7123fb928776bcf943
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/node/__tests__/scope.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/423/files#diff-03e2e7673023f693f2fb6824fc9488d7e862b8074ff0db7123fb928776bcf943
https://github.com/devframes/devframe/pull/423/files#diff-03e2e7673023f693f2fb6824fc9488d7e862b8074ff0db7123fb928776bcf943
packages/devframe/src/node/host-functions.tshttps://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
View file https://github.com/SaKaNa-Y/devframe/blob/4ee8c8148883a5930924429c2c038b42d96b6ea4/packages/devframe/src/node/host-functions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/423/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
https://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
https://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
https://github.com/devframes/devframe/pull/423/files#diff-efe5456b93a0d8e8247cfe6e91892c36dd7212a914553773de1fbee22d4626be
Please reload this pagehttps://github.com/devframes/devframe/pull/423/files
Please reload this pagehttps://github.com/devframes/devframe/pull/423/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.