René's URL Explorer Experiment


Title: fix(shared-state): avoid echoing received updates by dvcolomban · Pull Request #422 · devframes/devframe · GitHub

Open Graph Title: fix(shared-state): avoid echoing received updates by dvcolomban · Pull Request #422 · devframes/devframe

X Title: fix(shared-state): avoid echoing received updates by dvcolomban · Pull Request #422 · devframes/devframe

Description: Background A browser-side shared-state update received from the node side emits the same write back. If that write arrives after its key is deleted and recreated, the replacement accepts the old synchronization ID and loses its new value. Changes Suppress only the received state object and synchronization ID while applying a snapshot or patch. Restore the previous receive context after synchronous callbacks. Local writes, nested callback writes and writes to another key with the same ID still propagate. The production change adds 20 lines and removes 3 in one file. No public API or wire-format change. Reproduction The added tests use native RpcFunctionsHostImpl and createRpcSharedStateClientHost. Only outgoing I/O is queued. Publish { count: 5 } from the node side and deliver its update to the browser side. Hold the resulting outgoing write. Delete the state on both sides and recreate its key as { count: 6 }. Read the replacement normally. Release the held write. Unchanged code replaces 6 with 5. This fix preserves 6 for both snapshots and patches. In a disposable checkout of this branch, install the locked dependencies with pnpm install --frozen-lockfile. Run the same tests with the production file restored to the unchanged base, then with the fix: git restore --source=72d917d5a57837b748bc9c950a0216049d13363e -- packages/devframe/src/client/rpc-shared-state.ts pnpm exec vitest run --project devframe packages/devframe/src/client/rpc-shared-state-echo.test.ts # Two failures: expected { count: 6 }, received { count: 5 }. git restore --source=HEAD -- packages/devframe/src/client/rpc-shared-state.ts pnpm exec vitest run --project devframe packages/devframe/src/client/rpc-shared-state-echo.test.ts # All three cases pass. Verification Reproduced both failures on unchanged main 72d917d5, using native source only. Four focused shared-state/RPC test files pass: 18 tests, including all three regressions. ESLint on both changed files, devframe TypeScript checks and the devframe package build pass. Local source checks use a cached dependency graph with Vitest 5.0.1, TypeScript 6.0.3 and Vite 8.3.1. Full CI also passes with the current lockfile: lint, Ubuntu/Windows Node 22/24/26 test jobs, end-to-end tests and Bun/Deno runtime checks.

Open Graph Description: Background A browser-side shared-state update received from the node side emits the same write back. If that write arrives after its key is deleted and recreated, the replacement accepts the old sy...

X Description: Background A browser-side shared-state update received from the node side emits the same write back. If that write arrives after its key is deleted and recreated, the replacement accepts the old sy...

Opengraph URL: https://github.com/devframes/devframe/pull/422

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:18841587-f7c6-d4e8-a23a-1d89a364af6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA38:2F9B80:10EA94:17A5B7:6AFB6B01
html-safe-nonce7bfe540e8923044dbed217e0b9e2055313cc08b68e8546f3e80415da9d464757
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTM4OjJGOUI4MDoxMEVBOTQ6MTdBNUI3OjZBRkI2QjAxIiwidmlzaXRvcl9pZCI6IjM2MjcyNDU0MDUzNDg3ODQ4OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac61e3b15c386de946cd725eea99f2039f3a9c35967ad2c4e3bf6a28edb28a25f4
hovercard-subject-tagpull_request:4714489411
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/devframes/devframe/pull/422/files
twitter:imagehttps://avatars.githubusercontent.com/u/90617742?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/90617742?s=400&v=4
og:image:altBackground A browser-side shared-state update received from the node side emits the same write back. If that write arrives after its key is deleted and recreated, the replacement accepts the old sy...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/devframes/devframe git https://github.com/devframes/devframe.git
octolytics-dimension-user_id279879373
octolytics-dimension-user_logindevframes
octolytics-dimension-repository_id1231722386
octolytics-dimension-repository_nwodevframes/devframe
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1231722386
octolytics-dimension-repository_network_root_nwodevframes/devframe
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/devframes/devframe/pull/422/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F422%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevframes%2Fdevframe%2Fpull%2F422%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=devframes%2Fdevframe
Reloadhttps://github.com/devframes/devframe/pull/422/files
Reloadhttps://github.com/devframes/devframe/pull/422/files
Reloadhttps://github.com/devframes/devframe/pull/422/files
devframeshttps://github.com/devframes
devframehttps://github.com/devframes/devframe
Codehttps://github.com/devframes/devframe
Issues12 (12)https://github.com/devframes/devframe/issues
Pull requests13 (13)https://github.com/devframes/devframe/pulls
Actionshttps://github.com/devframes/devframe/actions
Security and qualityhttps://github.com/devframes/devframe/security
Insightshttps://github.com/devframes/devframe/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fdevframes%2Fdevframe%2Fissues%2Fnew%2Fchoose
dvcolombanhttps://github.com/dvcolomban
devframes:mainhttps://github.com/devframes/devframe/tree/main
dvcolomban:dvcol/shared-state-echohttps://github.com/dvcolomban/devframe/tree/dvcol/shared-state-echo
Conversation 1 https://github.com/devframes/devframe/pull/422
Commits 1 https://github.com/devframes/devframe/pull/422/commits
Checks 11 https://github.com/devframes/devframe/pull/422/checks
Files changed https://github.com/devframes/devframe/pull/422/files
Please reload this pagehttps://github.com/devframes/devframe/pull/422/files
fix(shared-state): avoid echoing received updates https://github.com/devframes/devframe/pull/422/files#top
Show all changes 1 commit https://github.com/devframes/devframe/pull/422/files
de9c518 fix(shared-state): avoid echoing received updates dvcolomban Oct 2, 2026 https://github.com/devframes/devframe/pull/422/commits/de9c518fbf8cdcd894a1e438215fc4a7afe2ce4d
Clear filters https://github.com/devframes/devframe/pull/422/files
Please reload this pagehttps://github.com/devframes/devframe/pull/422/files
Please reload this pagehttps://github.com/devframes/devframe/pull/422/files
rpc-shared-state-echo.test.ts https://github.com/devframes/devframe/pull/422/files#diff-a3d0a88c350470d4a8c461ae0c49091bc61316b8d15dd1adc16f254e6b24e109
rpc-shared-state.ts https://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
packages/devframe/src/client/rpc-shared-state-echo.test.tshttps://github.com/devframes/devframe/pull/422/files#diff-a3d0a88c350470d4a8c461ae0c49091bc61316b8d15dd1adc16f254e6b24e109
View file https://github.com/devframes/devframe/blob/de9c518fbf8cdcd894a1e438215fc4a7afe2ce4d/packages/devframe/src/client/rpc-shared-state-echo.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/422/{{ revealButtonHref }}
packages/devframe/src/client/rpc-shared-state.tshttps://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
View file https://github.com/devframes/devframe/blob/de9c518fbf8cdcd894a1e438215fc4a7afe2ce4d/packages/devframe/src/client/rpc-shared-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/devframes/devframe/pull/422/{{ revealButtonHref }}
https://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
https://github.com/devframes/devframe/pull/422/files#diff-7c77ed971e646bb3cc99e0ac03db6a736e4371fb730bb4c04afcaa6d06f568bc
Please reload this pagehttps://github.com/devframes/devframe/pull/422/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.