René's URL Explorer Experiment

Title: Serialize models with exclude_unset, not exclude_defaults by negz · Pull Request #208 · crossplane/function-sdk-python · GitHub

Open Graph Title: Serialize models with exclude_unset, not exclude_defaults by negz · Pull Request #208 · crossplane/function-sdk-python

X Title: Serialize models with exclude_unset, not exclude_defaults by negz · Pull Request #208 · crossplane/function-sdk-python

Description: Fixes #207 Fixes #210 resource.update and resource.update_status serialized Pydantic models with model_dump(exclude_defaults=True). This PR makes two related corrections to how those functions serialize models. exclude_defaults → exclude_unset exclude_defaults asks "is this field different from its default?". The correct question for server-side apply is "did the caller set this field?", which exclude_unset answers. exclude_defaults also regressed with newer datamodel-code-generator, which emits object defaults as a raw dict with validate_default=True; the validated instance doesn't compare equal to the declared dict default, so unset fields like spec.providerConfigRef leaked into every composed resource. exclude_unset is immune to how a default is represented (see crossplane/cli#64 (comment)) — a field the caller didn't touch is absent from model_fields_set. Add by_alias=True Neither serialization passed by_alias=True, so a field carrying a Pydantic alias was emitted under its Python attribute name rather than its alias — the resource's real wire name. datamodel-code-generator can't name a field bool, int, from, continue, or schema, so it emits a bool_ attribute aliased to bool, and so on. A function composing such a field wrote bool_: true instead of bool: true, which doesn't match the resource's schema, so the API server rejects it or silently drops it. This surfaced with Kubernetes Dynamic Resource Allocation, whose device attribute value is a one-of over string, version, bool, and int. Passing by_alias=True is a no-op for ordinary fields and corrects only the keyword-collision cases. It's also symmetric with how pydantic deserializes these models: by default an aliased field is populated only by its alias, so reads and writes now both speak wire names. It's orthogonal to the exclude_unset change: one decides which fields are emitted, the other how they're named. I have: Read and followed Crossplane's contribution process. Added or updated unit tests for my change.

Open Graph Description: Fixes #207 Fixes #210 resource.update and resource.update_status serialized Pydantic models with model_dump(exclude_defaults=True). This PR makes two related corrections to how those functions seri...

X Description: Fixes #207 Fixes #210 resource.update and resource.update_status serialized Pydantic models with model_dump(exclude_defaults=True). This PR makes two related corrections to how those functions seri...

Opengraph URL: https://github.com/crossplane/function-sdk-python/pull/208

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width