René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Basic C++ \u0026 Singleton_registry - Suggestions to GrantRostig from an expert.","articleBody":"https://github.com/cppmsg/cpp_by_example/blob/master/designp_singleton/singleton_gof_registry.hpp\r\nI've taken a look at the code in that header file.\r\nAs for some suggestions:\r\n1. That .hpp file has both declarations in it as well as function definitions. I'd suggest moving those function definitions into one or more source files or prefixing them with the \"inline\" keyword.\r\n2. The formatting is such that some lines have multiple statements on the same line. It's more common to see only a single statement per line and will be easier to read for people used to that - like myself.\r\n3. I see that file has a \"using namespace...\" statement in it. Those pollute the namespace for any users of that header file. I suggest removing it.\r\n4. The code uses a mix of qualified uses of standard library names and unqualified uses. Use only namespace qualified names for types from the standard library. So prefix mentions of types like \"string\" with \"std\" so those instead appear like \"std::string\".\r\n5. Come up with a more consistent formatting style and use it everywhere within that file. Qt Creator can be configured to auto format to some standard styles and that could be used to help for that.\r\n6. Remove the include of \u003cbits/stdc++.h\u003e from that file.\r\n7. Specifically include the standard library header files that are needed for that header file to stand alone. So for instance, there'd be includes like for \"\u003cstring\u003e\", \"\u003ccassert\u003e\", \"\u003ciostream\u003e\", \"\u003cmutex\u003e\".\r\n8. Don't use \"endl\". That appends a newline AND forces a flush of the stream buffer. If you really want both, use the newline character ('\\n') or string (\"\\n\") and follow it with an explicit \"std::flush\".\r\n9. Pick a max column width no more than like 120 for the code and then enforce that with newlines.\r\n10. \"Singleton_gof_registry::_registry\" does not need to be a pointer to a \"Registry\". That's basically a pointer to a pointer to a dynamically allocated array. Make it just of type \"Registry\" and then it doesn't need to be \"new\" allocated on first use.\r\n11. Don't mix uses of like \"end()\" member function values with \"cend()\" member function values.\r\n12. If you want to provide exclusive access to one section of code so another thread can't access those same variables, those sections need to all use the same \"std::mutex\" (or a different mechanism than \"std::mutex\" has to be used instead). So add \"mtx\" as a private member variable of \"Singleton_gof_registry\" and then the three member functions which use a \"std::mutex\" would all use the \"mtx\" member variable instead.","author":{"url":"https://github.com/grantrostig","@type":"Person","name":"grantrostig"},"datePublished":"2023-11-19T01:51:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/2/cpp_by_example/issues/2"}