Title: Fix #381 (When there are header files with the same name, the correct file cannot be found) by glankk · Pull Request #443 · cppcheck-opensource/simplecpp · GitHub
Open Graph Title: Fix #381 (When there are header files with the same name, the correct file cannot be found) by glankk · Pull Request #443 · cppcheck-opensource/simplecpp
X Title: Fix #381 (When there are header files with the same name, the correct file cannot be found) by glankk · Pull Request #443 · cppcheck-opensource/simplecpp
Description: The issue is caused by false matches in getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and another one to detect false negatives on case-insensitive systems, which would result in #pragma once breaking. I added them both in this PR because they're related, but I can move the second test to another PR if that's preferable.
Open Graph Description: The issue is caused by false matches in getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and an...
X Description: The issue is caused by false matches in getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and an...
Opengraph URL: https://github.com/cppcheck-opensource/simplecpp/pull/443
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5cb650c9-a00d-970a-53d7-14da2f70c5ac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E522:C8AE2:6352D51:8C52AD1:6A4FD834 |
| html-safe-nonce | f88f978e39c66124906f50557191be0690eb803f807f0b12fac6621e358134d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTIyOkM4QUUyOjYzNTJENTE6OEM1MkFEMTo2QTRGRDgzNCIsInZpc2l0b3JfaWQiOiIzNjc4NzkxNTA1NzUyNzgxMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 67c617f41670f48646302d5d5b2f1ff74aca8ba411f00301c7eb5261c5b01a03 |
| hovercard-subject-tag | pull_request:2588441784 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/simplecpp/pull/443/files |
| twitter:image | https://avatars.githubusercontent.com/u/10298420?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10298420?s=400&v=4 |
| og:image:alt | The issue is caused by false matches in getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/simplecpp git https://github.com/cppcheck-opensource/simplecpp.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 33434464 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/simplecpp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33434464 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/simplecpp |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width