René's URL Explorer Experiment


Title: Fix #15225 (FN arrayIndexOutOfBounds: sizeof(arr) unknown when the array dimension contains sizeof of a struct, variable or dereference) by JayToltTech · Pull Request #9037 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: Fix #15225 (FN arrayIndexOutOfBounds: sizeof(arr) unknown when the array dimension contains sizeof of a struct, variable or dereference) by JayToltTech · Pull Request #9037 · cppcheck-opensource/cppcheck

X Title: Fix #15225 (FN arrayIndexOutOfBounds: sizeof(arr) unknown when the array dimension contains sizeof of a struct, variable or dereference) by JayToltTech · Pull Request #9037 · cppcheck-opensource/cppcheck

Description: https://trac.cppcheck.net/ticket/15225 Replaces #9036, which I've closed. That one patched a single reader of the array dimension, and the review there found it gave a false positive for array parameters. Looking at why turned up the same cause in two more places, so this fixes the cause. A dimension like 10 + sizeof(struct S), 10 + sizeof(var) or 10 + sizeof(*p) is only marked known by SymbolDatabase::setArrayDimensionsUsingValueFlow(), and that runs after all the ValueFlow passes. So everything inside ValueFlow sees the dimension as unknown, and none of these get a value: sizeof(arr) sizeof(arr) / sizeof(arr[0]) sizeof(struct T) where T has an array like that as a member valueFlowNumber() now sets the dimension when the token walk gets to the end of the array declaration. Constant folding has already given the dimension token a known value by then, and declarations come before uses, so the existing sizeof code works unchanged. Chained ones like char b[sizeof(a)] work too. The pass after ValueFlow stays for dimensions that only become known later. Array parameters are the other half. sizeof of an array function parameter is the size of a pointer, but it was being evaluated as the size of the array. void f(char p[10]) gave 10 on main already, and knowing more dimensions would have spread that. It gives the pointer size now, and sizeof(p) / sizeof(p[0]) isn't evaluated as the element count. The condition is in Variable::isDecayedArrayArgument(), which CheckSizeof had inline. References to arrays and std::array by value keep their full size. Tests are in TestValueFlow::valueFlowSizeof, plus a new TestBufferOverrun::array_index_78 for the a[sizeof(a)] from the ticket. Both fail without the lib/ change. testrunner passes on macOS arm64 and runformat makes no changes. I haven't run the selfcheck locally. The const_cast on Dimension in valueflow.cpp is the same one setArrayDimensionsUsingValueFlow() already does. Change it as you see fit.

Open Graph Description: https://trac.cppcheck.net/ticket/15225 Replaces #9036, which I've closed. That one patched a single reader of the array dimension, and the review there found it gave a false positive for array...

X Description: https://trac.cppcheck.net/ticket/15225 Replaces #9036, which I've closed. That one patched a single reader of the array dimension, and the review there found it gave a false positive for a...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/9037

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e069228f-2c15-903c-0a15-38b5db6e066f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C6:385A2B:252445:34FAB1:6AFC4DBC
html-safe-nonce4f2a9f65aea53a46cb8377360905e6a53a8cf20718b5a19ca775c0a1352212ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUM2OjM4NUEyQjoyNTI0NDU6MzRGQUIxOjZBRkM0REJDIiwidmlzaXRvcl9pZCI6IjE4MDUyMjM4OTA3Mjk1ODYxMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac853459018a39e0b7c84c25ee772dbe1a9295a913c8edee0a8d52ef9c6de6d809
hovercard-subject-tagpull_request:5347096635
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/9037/files
twitter:imagehttps://avatars.githubusercontent.com/u/69092530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69092530?s=400&v=4
og:image:althttps://trac.cppcheck.net/ticket/15225 Replaces #9036, which I've closed. That one patched a single reader of the array dimension, and the review there found it gave a false positive for array...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb63557e0027d8014589e873df28328da74a4356701bb1a9eab49dbf012ba8fa6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0243355b0352c83733a042e0dfb3d75149b51261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F9037%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F9037%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
cppcheck-opensourcehttps://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Codehttps://github.com/cppcheck-opensource/cppcheck
Pull requests222 (222)https://github.com/cppcheck-opensource/cppcheck/pulls
Actionshttps://github.com/cppcheck-opensource/cppcheck/actions
Security and qualityhttps://github.com/cppcheck-opensource/cppcheck/security
Insightshttps://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
JayToltTechhttps://github.com/JayToltTech
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
JayToltTech:fix-15225-array-dim-earlyhttps://github.com/JayToltTech/cppcheck/tree/fix-15225-array-dim-early
Conversation 1 https://github.com/cppcheck-opensource/cppcheck/pull/9037
Commits 1 https://github.com/cppcheck-opensource/cppcheck/pull/9037/commits
Checks 71 https://github.com/cppcheck-opensource/cppcheck/pull/9037/checks
Files changed 7 https://github.com/cppcheck-opensource/cppcheck/pull/9037/files
Fix #15225 (FN arrayIndexOutOfBounds: sizeof(arr) unknown when the array dimension contains sizeof of a struct, variable or dereference) https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#top
Show all changes 1 commit https://github.com/cppcheck-opensource/cppcheck/pull/9037/files
370d71b Fix #15225 (FN arrayIndexOutOfBounds: sizeof(arr) unknown when the ar… JayToltTech Nov 16, 2026 https://github.com/cppcheck-opensource/cppcheck/pull/9037/commits/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/9037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
checksizeof.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-8a69c2d7e15c4c9caa0bda2ce0eba1a277bf8e45ecb01f635cc06f80a6a35545
symboldatabase.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
symboldatabase.h https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-785645684974d6e4c93d7dfcd9350022adfad766a2d9b6318a9005e8ca38c95e
valueflow.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
vf_common.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
testbufferoverrun.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
testvalueflow.cpp https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-0c918c64e1eee55c83249b2cbe2beb837af6dd0a5a4273a1ae9168cd0582ba8d
lib/checksizeof.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-8a69c2d7e15c4c9caa0bda2ce0eba1a277bf8e45ecb01f635cc06f80a6a35545
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/lib/checksizeof.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-8a69c2d7e15c4c9caa0bda2ce0eba1a277bf8e45ecb01f635cc06f80a6a35545
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-8a69c2d7e15c4c9caa0bda2ce0eba1a277bf8e45ecb01f635cc06f80a6a35545
lib/symboldatabase.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/lib/symboldatabase.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
lib/symboldatabase.hhttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-785645684974d6e4c93d7dfcd9350022adfad766a2d9b6318a9005e8ca38c95e
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/lib/symboldatabase.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-785645684974d6e4c93d7dfcd9350022adfad766a2d9b6318a9005e8ca38c95e
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-785645684974d6e4c93d7dfcd9350022adfad766a2d9b6318a9005e8ca38c95e
lib/valueflow.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/lib/valueflow.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
lib/vf_common.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/lib/vf_common.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-a5fad05aa2f42154a082d9ca2b770b9c7e5d5a3d6031ce9ac6005cf1d297087a
test/testbufferoverrun.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/test/testbufferoverrun.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-e79f66a242de2726f15567034589246e8e93448c430616ee0811d12927db1bda
test/testvalueflow.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-0c918c64e1eee55c83249b2cbe2beb837af6dd0a5a4273a1ae9168cd0582ba8d
View file https://github.com/cppcheck-opensource/cppcheck/blob/370d71b64b3540787f8d7e107b1ed0d7e4cff7f8/test/testvalueflow.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/9037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-0c918c64e1eee55c83249b2cbe2beb837af6dd0a5a4273a1ae9168cd0582ba8d
https://github.com/cppcheck-opensource/cppcheck/pull/9037/files#diff-0c918c64e1eee55c83249b2cbe2beb837af6dd0a5a4273a1ae9168cd0582ba8d
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9037/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.